January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove redundant creation of array
by tnisan＠redhat.com 20 Jan '13

20 Jan '13

Tal Nisan has submitted this change and it was merged. Change subject: core: remove redundant creation of array ...................................................................... core: remove redundant creation of array Remove redundant creation of array when creating a List object in AddStorageServerConnectionCommand Change-Id: I530513734fe6071ff190878ebcfe9dd55a1ecce6 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java 1 file changed, 5 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alissa Bonas: Verified -- To view, visit http://gerrit.ovirt.org/11224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I530513734fe6071ff190878ebcfe9dd55a1ecce6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unused method
by tnisan＠redhat.com 20 Jan '13

20 Jan '13

Tal Nisan has submitted this change and it was merged. Change subject: core: remove unused method ...................................................................... core: remove unused method remove getStorageConnection method which is not called in RemoveStorageServerConnectionCommand Change-Id: Ie8987a7f42e0241cdf82ca6645a19a31a14065b5 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alissa Bonas: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8987a7f42e0241cdf82ca6645a19a31a14065b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename method to start with lowercase
by tnisan＠redhat.com 20 Jan '13

20 Jan '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename method to start with lowercase ...................................................................... core: rename method to start with lowercase rename Connect to connect to comply with java naming conventions in ConnectStorageToVdsCommand Change-Id: I43219d69446052f6ce1c00677402896936e762f2 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alissa Bonas: Verified -- To view, visit http://gerrit.ovirt.org/11222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43219d69446052f6ce1c00677402896936e762f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: prepare to the next development iteration
by mpastern＠redhat.com 20 Jan '13

20 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: prepare to the next development iteration ...................................................................... sdk: prepare to the next development iteration Change-Id: Ic53b921539452562774a59e25a54c50e8ee4ace9 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic53b921539452562774a59e25a54c50e8ee4ace9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: prepare to the next development iteration
by mpastern＠redhat.com 20 Jan '13

20 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: prepare to the next development iteration ...................................................................... cli: prepare to the next development iteration Change-Id: I6480efe2c1619bafb48ce4c137a53e738e8732be Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M setup.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6480efe2c1619bafb48ce4c137a53e738e8732be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: prepare to the next development iteration
by mpastern＠redhat.com 20 Jan '13

20 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: prepare to the next development iteration ...................................................................... sdk: prepare to the next development iteration Change-Id: I0ff3d3904b93160dddd58849104f03c08d9b10d5 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M setup.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ff3d3904b93160dddd58849104f03c08d9b10d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Template name restricted to 40 characters for all ...
by gchaplik＠redhat.com 20 Jan '13

20 Jan '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Template name restricted to 40 characters for all OS ...................................................................... webadmin: Template name restricted to 40 characters for all OS Fixed validation of create/edit template name validation. VM name is restricted to 15 characters for Windows host, 64 characters for other hosts. VM template name is max. 40 characters long. Change-Id: Id7bb03dea4c6030a485f0d60d775dd308c4c7155 Bug-Url: https://bugzilla.redhat.com/848398 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 6 insertions(+), 14 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7bb03dea4c6030a485f0d60d775dd308c4c7155 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: cleanup
by mpastern＠redhat.com 20 Jan '13

20 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: cleanup ...................................................................... sdk: cleanup Change-Id: Ica9ed9dbcd8a8243bb0da3c2ad11401611b9bdcd Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/collection/resource.py M src/codegen/subcollection/subcollection.py M src/codegen/subcollection/subresource.py M src/ovirtsdk/infrastructure/brokers.py 4 files changed, 186 insertions(+), 186 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica9ed9dbcd8a8243bb0da3c2ad11401611b9bdcd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replaced datastore checkConnection() impl.
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Replaced datastore checkConnection() impl. ...................................................................... engine: Replaced datastore checkConnection() impl. Replaced StandaloneDataSource:checkConnection() implementation to use connection.isValid method instead of running query. Change-Id: Ia5b35703c28560b6aa01497bfef7f09319aebb3c Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/tools/engine-tools-common/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b35703c28560b6aa01497bfef7f09319aebb3c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AddDisk preview validation
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDisk preview validation ...................................................................... core: AddDisk preview validation In AddDiskCommand, moved the validation that the VM is not in preview from ImagesHandler to SnapshotValidator, which is a more logical place for it. This patch contains the following: * A new method in SnapshotValidator, vmNotInPreview(vmId) * Tests for the aforementioned method in SnapshotValidatorTest. * The usage of the aforementioned method in AddDiskCommand * Minor amendments to AddDiskToVmCommandTest's mocking in light of the previous change. Note: This patch is part of a series of patches aimed at removing the preview validation from ImagesHandler altogether. Change-Id: Ib282279a4b938d6fb3b08e9b2d127af4653bd51c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidatorTest.java 4 files changed, 49 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib282279a4b938d6fb3b08e9b2d127af4653bd51c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0