January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: VmDeviceUtils cleanup
by lhornyak＠redhat.com 20 Jan '13

20 Jan '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: VmDeviceUtils cleanup ...................................................................... engine: VmDeviceUtils cleanup - entity variable addVideoDevice was not used, removed - updateCdInVmDevice private method not used at all, removed Change-Id: Ibe329e49ce3697649001229896295863933cc1a4 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 1 insertion(+), 21 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe329e49ce3697649001229896295863933cc1a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: required space validation - destination domain
by derez＠redhat.com 20 Jan '13

20 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: core: required space validation - destination domain ...................................................................... core: required space validation - destination domain LiveMigrateVmDisksCommand -> isValidSpaceRequirements: add destination domain name to canDoActionMessage (instead of using getStorageDomain() - prevents a NPE). Change-Id: I51e0be2ccf541ee435ae04814baeedf3c3373af3 Bug-Url: https://bugzilla.redhat.com/888316 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51e0be2ccf541ee435ae04814baeedf3c3373af3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: prevent failure on concurrent live snapshots
by derez＠redhat.com 20 Jan '13

20 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: core: prevent failure on concurrent live snapshots ...................................................................... core: prevent failure on concurrent live snapshots Remove redundant freelock() to prevent SQL DuplicateKeyException on concurrent creation of live snapshots. Change-Id: Ie745fb194d6cc21ce115fd05ac8c88e852069b74 Bug-Url: https://bugzilla.redhat.com/877750 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie745fb194d6cc21ce115fd05ac8c88e852069b74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: move disks popup - fix alignment
by derez＠redhat.com 20 Jan '13

20 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: move disks popup - fix alignment ...................................................................... webadmin: move disks popup - fix alignment Remove redundant/unused panels, labels and styles (for fixing alignment when using Chrome). Change-Id: Ibbb9b6cb8b316245463955c43ae30e490224a7b6 Bug-Url: https://bugzilla.redhat.com/893984 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml 2 files changed, 4 insertions(+), 42 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbb9b6cb8b316245463955c43ae30e490224a7b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: improve error msg text in storage connection
by tnisan＠redhat.com 20 Jan '13

20 Jan '13

Tal Nisan has submitted this change and it was merged. Change subject: core: improve error msg text in storage connection ...................................................................... core: improve error msg text in storage connection Improve error message text for case when storage connection doesn't exist: Remove "internal error" because it doesn't have to be an internal error, it could be that the user entered not existing nfs path, and having "internal error" in message in UI is misleading the user. Also make "Connection" to "conection" because it's in the middle of a sentence and it shouldn't be a capital letter Change-Id: Icec819a8cf91e04051ce77244f79bb85db5f8972 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icec819a8cf91e04051ce77244f79bb85db5f8972 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: A check for possible NPE BackendVmsResource:remove ...
by asaf＠redhat.com 20 Jan '13

20 Jan '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: restapi: A check for possible NPE BackendVmsResource:remove method ...................................................................... restapi: A check for possible NPE BackendVmsResource:remove method A check for possible NPE BackendVmsResource:remove method. Change-Id: Idbf51b03bb170b34e1b6bba3d37e62c967fdd5d6 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbf51b03bb170b34e1b6bba3d37e62c967fdd5d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: show data center name for each cluster
by dfediuck＠redhat.com 20 Jan '13

20 Jan '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: show data center name for each cluster ...................................................................... webadmin: show data center name for each cluster Add Data Center column to main tab Cluster view. Change-Id: Ia05495e10004c4bd7d04cab0ede9afbf57a48883 Bug-Url: https://bugzilla.redhat.com/784521 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia05495e10004c4bd7d04cab0ede9afbf57a48883 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, db: add cluster view
by dfediuck＠redhat.com 20 Jan '13

20 Jan '13

Doron Fediuck has submitted this change and it was merged. Change subject: core, db: add cluster view ...................................................................... core, db: add cluster view Add cluster view so that webadmin can show data center name for each cluster. Change-Id: I5847d234e396fe8a83017fb25a5139f552e7c61b Bug-Url: https://bugzilla.redhat.com/784521 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/vds_groups_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java 5 files changed, 57 insertions(+), 32 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5847d234e396fe8a83017fb25a5139f552e7c61b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: A check for possible NPE in NicActivateStatusColum...
by asaf＠redhat.com 20 Jan '13

20 Jan '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: A check for possible NPE in NicActivateStatusColumn:getTooltip ...................................................................... webadmin: A check for possible NPE in NicActivateStatusColumn:getTooltip A check for a possible NPE In NicActivateStatusColumn:getTooltip. Change-Id: Ib350579b4ff7d7193a9870c83f4014df57bb3da4 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NicActivateStatusColumn.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib350579b4ff7d7193a9870c83f4014df57bb3da4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unused code and fix param name
by tnisan＠redhat.com 20 Jan '13

20 Jan '13

Tal Nisan has submitted this change and it was merged. Change subject: core: remove unused code and fix param name ...................................................................... core: remove unused code and fix param name Remove unused code and fix param name from adUser to ldapUser Change-Id: Ic242cc5da9dfe4c70c671b90f2eed49ad3d35723 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 23 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic242cc5da9dfe4c70c671b90f2eed49ad3d35723 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0