January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Switched to the official GWT maven plugin
by asaf＠redhat.com 20 Jan '13

20 Jan '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: Switched to the official GWT maven plugin ...................................................................... engine: Switched to the official GWT maven plugin Switched maven GWT plugin to the official one. Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> Change-Id: I7a0aa265716a2dd74ff74d7d191271ae149c2546 --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a0aa265716a2dd74ff74d7d191271ae149c2546 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: input controls now display localized dates (#892306...
by ydary＠redhat.com 20 Jan '13

20 Jan '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: input controls now display localized dates (#892306) ...................................................................... reports: input controls now display localized dates (#892306) Bug-Url: https://bugzilla.redhat.com/892306 Change-Id: I810041650d423882a5ba5d8a5c8a128e1a181fe3 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Start_Date.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_cluster_with_vms/P_Cluster_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_clusters_with_hosts/P_Cluster_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_entities/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_hosts/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_storage/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_vms/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/host_ic/Hosts_List.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/storage_ic/P_StorageDomain_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/vm_ic/VM_List.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/P_Cluster_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/P_Host_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/P_Host_ListID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Storage/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Storage/P_StorageDomain_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/P_Cluster_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/P_VM_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/P_VM_ListID.xml 20 files changed, 24 insertions(+), 24 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I810041650d423882a5ba5d8a5c8a128e1a181fe3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: added ic variable to allow date localzation (#89230...
by ydary＠redhat.com 20 Jan '13

20 Jan '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: added ic variable to allow date localzation (#892306) ...................................................................... reports: added ic variable to allow date localzation (#892306) Bug-Url: https://bugzilla.redhat.com/892306 Change-Id: Ifb897603a565be3dff853340069820931f82e3ef Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/jars/CustomOvirtReportsQueryManipulator/pom.xml M reports/jars/CustomOvirtReportsQueryManipulator/src/main/java/org/ovirt/jasperreports/querymodifier/CustomOvirtReportsQueryManipulator.java 2 files changed, 57 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb897603a565be3dff853340069820931f82e3ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fix execution context of SetNonOperationalVdsCommand
by masayag＠redhat.com 20 Jan '13

20 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: fix execution context of SetNonOperationalVdsCommand ...................................................................... engine: fix execution context of SetNonOperationalVdsCommand This patch sets the execution context of SetNonOperationalVdsCommand to async when it triggers migrations for the VMs which are running in the VDS. Previously the execution context of this command was always sync which caused to DataIntegrityViolationException in the following scenarion: 1. the SetNonOperationalVdsCommand was triggered 2. migrations for the VMs running in the Vds was triggered 3. the sync part of SetNonOperationalVdsCommand ended succesfully causing the job to be marked with Finished status 4. the job is cleared from the db by the periodic process that clean finished jobs 5. the migration fails, thus it's being rerun 6. the migration rerun process is trying to add step, but its job doesn't exist in the DB Change-Id: If615a9d9fdad324d535709e76b5cd9a5f94953c9 Bug-Url: https://bugzilla.redhat.com/888199 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java 2 files changed, 24 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If615a9d9fdad324d535709e76b5cd9a5f94953c9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: SnapshotValidator modifier cleanup
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: SnapshotValidator modifier cleanup ...................................................................... core: SnapshotValidator modifier cleanup Cleaned up modifiers and annotations in SnaoshotValidator and its test. Change-Id: Ieb3f71aaebd5720e2e00653768c5d70c652d2ced Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidatorTest.java 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb3f71aaebd5720e2e00653768c5d70c652d2ced Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VM is down check when adding template
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: VM is down check when adding template ...................................................................... core: VM is down check when adding template AddTemplateCommand explicitly checks if the VM is down in the canDoAction, so there is no need to recheck it again by passing true to the relevant argument of PerformImagesChecks. This patch contains the proposed fix, a test for it, and a minor refactor required to facilitate the test. Note: This patch is part of a series intended to remove the VM status check from ImagesHandler. Change-Id: Ifec2d9677765502ca6876b31835340d3c4fad5ae Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java 2 files changed, 93 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifec2d9677765502ca6876b31835340d3c4fad5ae Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: TrybackToAllSnapshots vmDown validation
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: TrybackToAllSnapshots vmDown validation ...................................................................... core: TrybackToAllSnapshots vmDown validation Added an explicit test for VM.isDown in TrybackToAllSnapshotsOfVmCommand.canDoAction() instead of using ImagesHandler.PerformImagesChecks to do it. This patch contains the aforementioned code change, a test for it, and a minor refactor required to facilitate the test. Note: This patch is part of a series intended to remove the VM status check from ImagesHandler. Change-Id: I5f8fa014e73e6f10693edd1e4ccff4656d50053b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommandTest.java 2 files changed, 76 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f8fa014e73e6f10693edd1e4ccff4656d50053b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveSnapshot vmDown validation
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveSnapshot vmDown validation ...................................................................... core: RemoveSnapshot vmDown validation Added an explicit test for VM.isDown in RemoveSnapshotCommand.canDoAction() instead of using ImagesHandler.PerformImagesChecks to do it. In order to do this neatly, such a method was added to VmValidator, which is the standard way of writing canDoActions. Note: This patch is part of a series intended to remove the VM status check from ImagesHandler. Change-Id: Ifd281aa6778a3249162517499b5f0f48b04ed6b6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java 3 files changed, 39 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd281aa6778a3249162517499b5f0f48b04ed6b6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Early return RemoveDiskCommand.canDoAction()
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Early return RemoveDiskCommand.canDoAction() ...................................................................... core: Early return RemoveDiskCommand.canDoAction() Converted RemoveDiskCommand.canDoAction() to use the early return pattern for increased readability. This patch includes the described code changes and a small unit test proving canDoAction()'s flow was not damaged. Change-Id: I32eb51e9e3cee5920f90b8f1ff8a8148a10cf2f1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java 2 files changed, 92 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32eb51e9e3cee5920f90b8f1ff8a8148a10cf2f1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Consolidate VM down check when removing disk
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Consolidate VM down check when removing disk ...................................................................... core: Consolidate VM down check when removing disk Both removing an image and a LUN disk had to check that the VM is down, and this check was done in two separate places. This patch consolidates this treatment to one function and stops using ImagesHandler to perform this check for images. Note: This patch is part of a series intended to remove the VM status check from ImagesHandler. Change-Id: Ia1a23e1f8d129bf19c1d217c7b9201dc17a2d2c0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java 2 files changed, 38 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1a23e1f8d129bf19c1d217c7b9201dc17a2d2c0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0