January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Improving EventQueueMonitor message
by mkublin＠redhat.com 20 Jan '13

20 Jan '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving EventQueueMonitor message ...................................................................... engine: Improving EventQueueMonitor message During work on the provided bug I noticed that when some event is cancelled not well formatted message is provided. So I fix it. Change-Id: Idc16b4f9846b460667733e4e473bcfd89cc953b3 Bug-Url: https://bugzilla.redhat.com/895996 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc16b4f9846b460667733e4e473bcfd89cc953b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Setting reconstruct to failed when last master was d...
by mkublin＠redhat.com 20 Jan '13

20 Jan '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Setting reconstruct to failed when last master was disabled ...................................................................... engine: Setting reconstruct to failed when last master was disabled The following commit is changing return value of reconstruct command to false when we has only last master and it was changed to InActive status. These fix is important for InitVdsOnUpCommand and also fixing an old bug - when a command was marked as successed but audit log message was "Failed to ..." Change-Id: I0e889d5e3022963bf835ea48674f23e80ca49675 Bug-Url: https://bugzilla.redhat.com/895996 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e889d5e3022963bf835ea48674f23e80ca49675 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Setting parameter inActive=true at InitVdsOnUp for R...
by mkublin＠redhat.com 20 Jan '13

20 Jan '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Setting parameter inActive=true at InitVdsOnUp for ReconstructMasterCommand ...................................................................... engine: Setting parameter inActive=true at InitVdsOnUp for ReconstructMasterCommand The following change is done because of when inActive is false a master domain will be disconnected from all hosts, these is not correct behaviour Bug-Url: https://bugzilla.redhat.com/895996 Change-Id: I51d2cdb365d866912dceaf9c9d392f3dc36daf44 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51d2cdb365d866912dceaf9c9d392f3dc36daf44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Release Mac from Pool
by msalem＠redhat.com 20 Jan '13

20 Jan '13

Muli Salem has submitted this change and it was merged. Change subject: engine: Release Mac from Pool ...................................................................... engine: Release Mac from Pool This patch makes sure the Mac address is released from pool in case the Update/Add VmInterfaceCommand fails. It moves the allocation of Mac Address from the canDoAction to the execute method, allowing rollback if necessary. Change-Id: Idcec5bbd129f4413ec077102379a417bfd945bc3 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 7 files changed, 77 insertions(+), 61 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcec5bbd129f4413ec077102379a417bfd945bc3 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in samples-uiplugins[master]: Introducing ShellBox UI plugin
by vszocs＠redhat.com 18 Jan '13

18 Jan '13

Vojtech Szocs has submitted this change and it was merged. Change subject: Introducing ShellBox UI plugin ...................................................................... Introducing ShellBox UI plugin ShellBox UI plugin - provides SSH connection to a host using shellinabox - a Web based AJAX terminal emulator (http://code.google.com/p/shellinabox/) UI additions: * Hosts main-tab -> new 'Shell Box' action button * Hosts main-tab -> new 'Shell Box' sub-tab Change-Id: I96c234e095e12b276ea6811274e17751de1f0b88 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A shellbox-plugin/README A shellbox-plugin/shellbox-files/start.html A shellbox-plugin/shellbox.json 3 files changed, 73 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96c234e095e12b276ea6811274e17751de1f0b88 Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Export ENGINE_DEFAULTS and ENGINE_VARS
by juan.hernandez＠redhat.com 18 Jan '13

18 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Export ENGINE_DEFAULTS and ENGINE_VARS ...................................................................... packaging: Export ENGINE_DEFAULTS and ENGINE_VARS The start scripts for the engine and for the tools don't export the ENGINE_DEFAULTS and ENGINE_VARS environment variables. This means that the LocalConfig class won't use its value to locate the configuration. Change-Id: I6a41287040260eb43272c0b15af0b93eba585675 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/engine-tools-common/src/main/shell/engine-prolog.sh.in M packaging/fedora/engine-service.py.in 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a41287040260eb43272c0b15af0b93eba585675 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: Dont use /etc/java/java.conf
by ydary＠redhat.com 17 Jan '13

17 Jan '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Dont use /etc/java/java.conf ...................................................................... packaging: Dont use /etc/java/java.conf The JAVA_HOME environment variable is defined in the history_service.sh script, and comes from /etc/sysconfig/ovirt-engine, so it is confusing for users if we also get it from /etc/java/java.conf. Change-Id: I4fc47a9e3b24d7a90a0ea919da53ec63144b9d86 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M data-warehouse/history_etl/history_service/ovirt-engine-dwhd 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fc47a9e3b24d7a90a0ea919da53ec63144b9d86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: added new jar to make artifact list
by ydary＠redhat.com 17 Jan '13

17 Jan '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added new jar to make artifact list ...................................................................... packaging: added new jar to make artifact list Change-Id: I634d68086b263ac415808e614fd36953890b68ee Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M Makefile 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I634d68086b263ac415808e614fd36953890b68ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed unused variable from Backend bean
by mkublin＠redhat.com 17 Jan '13

17 Jan '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removed unused variable from Backend bean ...................................................................... engine: Removed unused variable from Backend bean The following variable was used in order to cause for scheduler bean initialize before backend bean, these can be done by using DependsOn annotation Change-Id: If3f64ca53221e80b7f9ad760910c96578ee4d9a4 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3f64ca53221e80b7f9ad760910c96578ee4d9a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Moved getUpServerId to GlusterQueriesCommandBase
by sanjal＠redhat.com 17 Jan '13

17 Jan '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Moved getUpServerId to GlusterQueriesCommandBase ...................................................................... engine: Moved getUpServerId to GlusterQueriesCommandBase Moved getUpServerId() to base class GlusterQueriesCommandBase, so that other gluster queries like GetGlusterVolumeProfileInfoQuery, GetGlusterVolumeOptionsInfoQuery and GetGlusterVolumeAdvancedDetailsQuery can make use of it. Change-Id: Ia71ac0984d13adbd59af96ef00f6459d65595d29 Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQueryTest.java 5 files changed, 24 insertions(+), 57 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia71ac0984d13adbd59af96ef00f6459d65595d29 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0