January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: RemoveDiskCommand lazy getters
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveDiskCommand lazy getters ...................................................................... core: RemoveDiskCommand lazy getters Extracted lazy getters for getDisk() and getDiskImage() in RemoveDiskCommand. This is done for two reasons: 1. To avoid ugly casts all over the code 2. To avoid a DB access in the constructor, which facilitates easier unit testing. Change-Id: I5f38b27bd9456c990999660a5df0d6e4b807c207 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 40 insertions(+), 30 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f38b27bd9456c990999660a5df0d6e4b807c207 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove checkVmDown from PerformImagesChecks
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove checkVmDown from PerformImagesChecks ...................................................................... core: Remove checkVmDown from PerformImagesChecks Following a series of patches that removed all the usecases that set checkVmDown=true in ImagesHandler.PerformImagesChecks, this parameter is now useless, and can safely be removed. Change-Id: Ie931c4b2f4e26460c3696e21bec58d3529e29087 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java 13 files changed, 13 insertions(+), 23 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie931c4b2f4e26460c3696e21bec58d3529e29087 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MoveVm vmDown validation
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: MoveVm vmDown validation ...................................................................... core: MoveVm vmDown validation Added an explicit test for VM.isDown in MoveVmCommand.canDoAction() instead of using ImagesHandler.PerformImagesChecks to do it. Note: This patch is part of a series intended to remove the VM status check from ImagesHandler. Change-Id: Iec3d1d48192be7256ac55a145e7cb058480901ba Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec3d1d48192be7256ac55a145e7cb058480901ba Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ExportVm vmDown validation
by amureini＠redhat.com 20 Jan '13

20 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ExportVm vmDown validation ...................................................................... core: ExportVm vmDown validation Added an explicit test for VM.isDown in ExportVmCommand.canDoAction() instead of using ImagesHandler.PerformImagesChecks to do it. Note: This patch is part of a series intended to remove the VM status check from ImagesHandler. Change-Id: I0d48868ea1a292e7b655f27e3984606d152f9866 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d48868ea1a292e7b655f27e3984606d152f9866 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Upgrade should set SEQUENCE number to the correct valu...
by emesika＠redhat.com 20 Jan '13

20 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Upgrade should set SEQUENCE number to the correct value ...................................................................... core: Upgrade should set SEQUENCE number to the correct value Table sequences may get out of sync after database is restored. We had that in a customer database, the sequence value for generating option_id for vdc_options was 238 while the max(option_id) was 399. That resulted of course with PK violation. for more details , see: http://www.postgresql.org/docs/8.4/static/sql-createsequence.html Change-Id: Icd774770cbdbf197736a547de901826bdbec7abc Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=896552 --- M backend/manager/dbscripts/dbfunctions.sh A backend/manager/dbscripts/update_sequence_numbers.sql 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd774770cbdbf197736a547de901826bdbec7abc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Cleanup Logging in MacPoolManager
by msalem＠redhat.com 20 Jan '13

20 Jan '13

Muli Salem has submitted this change and it was merged. Change subject: engine: Cleanup Logging in MacPoolManager ...................................................................... engine: Cleanup Logging in MacPoolManager This patch cleans up the logging in MacPoolManager. Change-Id: If7d47189fe69effa90ce97ba0de83c6162a11e7f Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7d47189fe69effa90ce97ba0de83c6162a11e7f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: engine: Method Name in MacPoolManager
by msalem＠redhat.com 20 Jan '13

20 Jan '13

Muli Salem has submitted this change and it was merged. Change subject: engine: Method Name in MacPoolManager ...................................................................... engine: Method Name in MacPoolManager This patch changes a method name to be camel case. Change-Id: Ida99ea66dfc59acd3bc1e96c985e9b7972000457 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java 4 files changed, 5 insertions(+), 5 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida99ea66dfc59acd3bc1e96c985e9b7972000457 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: MacPoolManager - Read lock for Available Addresses
by msalem＠redhat.com 20 Jan '13

20 Jan '13

Muli Salem has submitted this change and it was merged. Change subject: engine: MacPoolManager - Read lock for Available Addresses ...................................................................... engine: MacPoolManager - Read lock for Available Addresses This patch adds a read lock for the getAvailableMacsCount() method. Change-Id: I2492d0d196c0f88e06677bb5d7a55fed23f20bbb Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2492d0d196c0f88e06677bb5d7a55fed23f20bbb Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Make AllowDuplicateMacAddresses Reloadable
by msalem＠redhat.com 20 Jan '13

20 Jan '13

Muli Salem has submitted this change and it was merged. Change subject: engine: Make AllowDuplicateMacAddresses Reloadable ...................................................................... engine: Make AllowDuplicateMacAddresses Reloadable This patch makes the AllowDuplicateMacAddresses ConfigValue, reloadable. Change-Id: Ic29a258a733ec085f2379b36b6f68d788742e29d Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic29a258a733ec085f2379b36b6f68d788742e29d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Support Duplicate Mac Addresses
by msalem＠redhat.com 20 Jan '13

20 Jan '13

Muli Salem has submitted this change and it was merged. Change subject: engine: Support Duplicate Mac Addresses ...................................................................... engine: Support Duplicate Mac Addresses This patch adds support to duplicate Mac addresses. It changes the cache in MacPoolManager to use Maps instead of Sets. These Maps hold counters per Mac address. When adding an existing Mac, if AllowDuplicateMacAddresses is enabled, we increment the counter. When freeing a Mac we either decrement the counter, or remove it from the Map entirely in case this is the only one. The patch also adds a new method forceAddMac(), that is meant for cases when Mac needs to be added to a MacMap, regardless of it already being use (for example, upon initialization). Change-Id: Ie96eda19de2d3a44e24806095fb690e4eba41165 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 2 files changed, 111 insertions(+), 23 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie96eda19de2d3a44e24806095fb690e4eba41165 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0