January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Allow passwordless database connection
by juan.hernandez＠redhat.com 14 Jan '13

14 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Allow passwordless database connection ...................................................................... packaging: Allow passwordless database connection Currently if no database password is provided in the configuration the engine will not be able to connect to the database, even if the database doesn't require a password (it is configured with "trust" mode). This patch changes the start script so that it will allow this passwordless connections as this is what we currently do in development environments. Change-Id: I1c51485720aa7e3289a067e2677239a44d689bf1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.xml.in 1 file changed, 16 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c51485720aa7e3289a067e2677239a44d689bf1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: log check is user admin in debug
by tnisan＠redhat.com 14 Jan '13

14 Jan '13

Tal Nisan has submitted this change and it was merged. Change subject: core: log check is user admin in debug ...................................................................... core: log check is user admin in debug Log the check "if user is an admin" as debug and not info. This check is done every 1 minute for logged in users, thus the log is filled with those messages in info level. Change-Id: I3f6e7f1ceec4b6d4935035f857281231bacc44e9 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f6e7f1ceec4b6d4935035f857281231bacc44e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : User Name modified on user login
by yzaslavs＠redhat.com 14 Jan '13

14 Jan '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core : User Name modified on user login ...................................................................... core : User Name modified on user login When a user logs into the User Portal or Admin Portal the user name is modified and it looses the domain name attached to it. This patch appends the domain name to the user name before updating the user info in database with the info from Ldap. Change-Id: I072f9aa8dc706533682b53d8b5a56e9b2dc09b82 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=892631 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072f9aa8dc706533682b53d8b5a56e9b2dc09b82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: build: add $(NULL) to end of Makefile statements
by Alon Bar-Lev 14 Jan '13

14 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: add $(NULL) to end of Makefile statements ...................................................................... build: add $(NULL) to end of Makefile statements This will ease future patches. Change-Id: I7e686f8ed17106603d2be96c7cc5af023f5513e1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile.am M build/Makefile.am M conf.d/Makefile.am M src/Makefile.am M src/bin/Makefile.am M src/interface-3/Makefile.am M src/java/Makefile.am M src/ovirt_host_deploy/Makefile.am M src/plugins/Makefile.am M src/plugins/ovirt-host-deploy/Makefile.am M src/plugins/ovirt-host-deploy/core/Makefile.am M src/plugins/ovirt-host-deploy/gluster/Makefile.am M src/plugins/ovirt-host-deploy/node/Makefile.am M src/plugins/ovirt-host-deploy/tune/Makefile.am M src/plugins/ovirt-host-deploy/vdsm/Makefile.am M src/plugins/ovirt-host-deploy/vdsmhooks/Makefile.am M tests/Makefile.am 17 files changed, 133 insertions(+), 66 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e686f8ed17106603d2be96c7cc5af023f5513e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: build: add $(NULL) to end of Makefile statements
by Alon Bar-Lev 14 Jan '13

14 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: add $(NULL) to end of Makefile statements ...................................................................... build: add $(NULL) to end of Makefile statements This will ease future patches. Change-Id: Ibfe8f18c2ae4e90377e67c79416edf0ed74af9c9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile.am M build/Makefile.am M src/Makefile.am M src/bin/Makefile.am M src/java/Makefile.am M src/otopi/Makefile.am M src/otopi/codegen/Makefile.am M src/plugins/Makefile.am M src/plugins/otopi/Makefile.am M src/plugins/otopi/core/Makefile.am M src/plugins/otopi/dialog/Makefile.am M src/plugins/otopi/network/Makefile.am M src/plugins/otopi/packagers/Makefile.am M src/plugins/otopi/services/Makefile.am M src/plugins/otopi/system/Makefile.am 15 files changed, 136 insertions(+), 66 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfe8f18c2ae4e90377e67c79416edf0ed74af9c9 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: cleanup: fix pep8 issue
by Alon Bar-Lev 14 Jan '13

14 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: cleanup: fix pep8 issue ...................................................................... cleanup: fix pep8 issue Change-Id: Ib75893d1302414bb8e37557a0b3cb463b5ff41e6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/services/rhel.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib75893d1302414bb8e37557a0b3cb463b5ff41e6 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine : NameNotFoundException when processing DNs containin...
by yzaslavs＠redhat.com 14 Jan '13

14 Jan '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : NameNotFoundException when processing DNs containing umlauts ...................................................................... engine : NameNotFoundException when processing DNs containing umlauts When umlauts or special characters are present in the user name, domain name or common name Ldap authentication throws a NameNotFoundException. This patch sets a system property that encodes the values in UTF-8 to support special characters. Change-Id: I37e136dedc8c27d1c1b4cda6780e3132421353d0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=829570 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/KerberosManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37e136dedc8c27d1c1b4cda6780e3132421353d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move status check methods from VM to VMStatus
by rgolan＠redhat.com 14 Jan '13

14 Jan '13

Roy Golan has submitted this change and it was merged. Change subject: core: Move status check methods from VM to VMStatus ...................................................................... core: Move status check methods from VM to VMStatus VM class contained methods which only check the value of the status of the VM, to see if it's one of several values that reflect some state of the VM. these methods should be places in VMStatus class (without being static methods) - instance of VMStatus should be able to return whether it reflects certain state of the VM, instead of using the previous methods. While moving those methods to VMStatus, they were renamed such that they'll be less confusing (isStatusUp is not a good name for a method that returns true even if the status is not UP for example). The method VM#isStatusUpOrPausedOrSuspended is removed as it wasn't used anywhere. The method VM#isStatusUp was renamed to VM#isRunning, to describe itself better. Change-Id: I82b4f109751773ff2d46407ccea26ea0be2661f5 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeFloppyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PauseVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/GetVmsAndNetworkInterfacesByNetworkIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java 20 files changed, 119 insertions(+), 77 deletions(-) Approvals: Roy Golan: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/10795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82b4f109751773ff2d46407ccea26ea0be2661f5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Fix firewalld installation message
by juan.hernandez＠redhat.com 14 Jan '13

14 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Fix firewalld installation message ...................................................................... packaging: Fix firewalld installation message The formatting of the message that contains the instructions to enable firewalld is incorrect, it doesn't contain any parameter but the format string includes a %s. Also the name is not very descriptive. This patch fixes both things. Change-Id: I928f88a188bec11a193c265bc57836f232996b01 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I928f88a188bec11a193c265bc57836f232996b01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: lock active snapshot during undo preview process
by mlipchuk＠redhat.com 14 Jan '13

14 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: lock active snapshot during undo preview process ...................................................................... core: lock active snapshot during undo preview process This patch prevents scenarios in which commands that are dependent on the VM's snapshot are executing in parallel to undo preview command which is changing the active snapshot of the VM. The active snapshot of the VM is being locked when the async part of the RestoreAllSnapshots command begins, and will be changed to OK when the command ends. Change-Id: Id7a2064d5130a6fa49360a8ad8e9a1004fc44da2 Bug-Url: https://bugzilla.redhat.com/868648 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 2 files changed, 36 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/10845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7a2064d5130a6fa49360a8ad8e9a1004fc44da2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>

1 0