Change in ovirt-log-collector[ovirt-log-collector-3.2]: packaging: spec: requires openssh-clients
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: requires openssh-clients
......................................................................
packaging: spec: requires openssh-clients
Added dependency on openssh-clients, needed for
having ssh command.
Bug-Url: https://bugzilla.redhat.com/1015757
Change-Id: Ic73c38e16a25acef5aefccb52cbf7cd6fa09a101
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M .gitignore
M ovirt-log-collector.spec.in
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19935
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic73c38e16a25acef5aefccb52cbf7cd6fa09a101
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: Volume transport-type column moved to general tab
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: Volume transport-type column moved to general tab
......................................................................
webadmin: Volume transport-type column moved to general tab
Moved transport Type Column of Volume to the General Sub Tab under Volumes
Change-Id: I47ee14b203448debf0ea13615c0c8834ff915555
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/VolumeTransportTypeLabel.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java
5 files changed, 75 insertions(+), 30 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47ee14b203448debf0ea13615c0c8834ff915555
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin : fixed rebalance status dialog close button issue
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin : fixed rebalance status dialog close button issue
......................................................................
webadmin : fixed rebalance status dialog close button issue
Fixed Clicking on the 'x' button does not close the status dialog.
Now,Clicking on the 'x' button closes the status dialog.
Change-Id: Ic0363784b13b26603f1f6279423adcac5e592045
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1012329
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
1 file changed, 14 insertions(+), 4 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19910
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0363784b13b26603f1f6279423adcac5e592045
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin : Rebalance status pop up title changed
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin : Rebalance status pop up title changed
......................................................................
webadmin : Rebalance status pop up title changed
Popup title changed to "Rebalance Status".
With multiple paragraphs if necessary.
Change-Id: Icac1781f5e256d4ad6c76d80c10af79bdf6a926d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014980
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19911
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icac1781f5e256d4ad6c76d80c10af79bdf6a926d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: clean CpuFlagsManager from unused methods
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: clean CpuFlagsManager from unused methods
......................................................................
core: clean CpuFlagsManager from unused methods
Change-Id: I43e65dc76232d60d8beb0675c2bff1e902c0dfdb
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
1 file changed, 0 insertions(+), 97 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19905
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43e65dc76232d60d8beb0675c2bff1e902c0dfdb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: Block multicast MAC addresses for vNICs
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Block multicast MAC addresses for vNICs
......................................................................
engine: Block multicast MAC addresses for vNICs
The patch blocks the possibility to provide a non-
unicast mac address to the vnic: neither broadcast
or multicast mac addresses aren't allowed for a vnic.
Change-Id: Ida4082be249391494053b56540d5458fecec65da
Bug-Url: https://bugzilla.redhat.com/1011912
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterfaceValidationTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/MacAddressValidation.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
15 files changed, 45 insertions(+), 43 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19891
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida4082be249391494053b56540d5458fecec65da
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: Fix broken backward compatibility of os ids
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Fix broken backward compatibility of os ids
......................................................................
core: Fix broken backward compatibility of os ids
This fix is about maintaining oss backward compatibility mappings of
old os names to the current IDs.
Vm Import/Export is using the os unique name instead of the os ID in the
OVF and since all unique names streamlined with the REST API
representation they all are not identified and fallback ID 0 - "other"
pre-osinfo exports would write the OS Windows8 while the new name is
windows_8 and so on
Solution:
Added a backward compatibility section to osinfo-default.properties
# Since Unassigned is removed we translate is to other so
backwardCompatibility.Unasigned = 0
backwardCompatibility.Other = 0
# represents the current id of old Windows8 os
backwardCompatibilty.Windows8 = 20
Bug-Url: https://bugzilla.redhat.com/1006340
Change-Id: I77c51a3bd0f4f0c264e8f895f40fd4d2bf4d689c
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImplTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M packaging/conf/osinfo-defaults.properties
5 files changed, 61 insertions(+), 11 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19774
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77c51a3bd0f4f0c264e8f895f40fd4d2bf4d689c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: utils: Preferences loader - support non-versioned keys
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: utils: Preferences loader - support non-versioned keys
......................................................................
utils: Preferences loader - support non-versioned keys
Till today the preference loader treats keys and a node with
multi-version values on it
nodeA.nodeB.value.x = 1
nodeA.nodeB.value.y = 2
so "value" is also a node and x and y are keys on the node.
this is specifig behaviour for paths in the form of a.b.c.value.x.y.z
This design is not straight forward with non-versioned keys such as:
nodeC.key = value
so we can:
Preferences nodeC = getNodeC();
nodeC.keys() # ["key"]
nodeC.get("key") # "value"
Bug-Url: https://bugzilla.redhat.com/1006340
Change-Id: I4b3bf67fbd892c37763428ae79204b59632d025d
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoader.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19794
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b3bf67fbd892c37763428ae79204b59632d025d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: removing unsed IDs from ConfigValues
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: removing unsed IDs from ConfigValues
......................................................................
core: removing unsed IDs from ConfigValues
Change-Id: I4b7835f32339c2fd6323361a5c9188f5e147dd4d
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
1 file changed, 350 insertions(+), 373 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19845
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b7835f32339c2fd6323361a5c9188f5e147dd4d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: Display size of ISO and floppy files in human read...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Display size of ISO and floppy files in human readable format
......................................................................
webadmin: Display size of ISO and floppy files in human readable format
Up until now DiskSizeRenderer which is used to render image/disk/file
sizes had 2 limitations:
1. Size appeared only in GB.
2. Size smaller than 1GB appeared as '<1GB'
>From now on, it also supports widely adopted Human Readable Format.
This patch uses new capability when rendering size of ISO files and
floppies under Storage ->ISO Storage Domain -> Images.
Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a
Bug-Url: https://bugzilla.redhat.com/1005889
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskSizeColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageIsoView.java
3 files changed, 48 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months