Change in ovirt-engine[master]: engine: Set correct size of iso files and floppies
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: engine: Set correct size of iso files and floppies
......................................................................
engine: Set correct size of iso files and floppies
Previously all iso and floppy files appeared in UI with bogus size
of '< 1 GB' although some of them are larger than that. Furthermore it
would be nice to display file size in human readable way.
The root cause of that problem is 'getIsoList' API between Engine and
VDSM which returned only a list of file names until now, so Engine set
their size to 0. It's worth mentioning before explaining API changes
that this list contained only permitted files.
Now this API returns a map with file stats including a size for all
files including not permitted files. Meantime Engine filtering out
files with wrong permissions, but they can be displayed in the future so
user would be able to know why these files are not usable.
Engine uses -1 when size is not available because old versions of VDSM
don't send it.
Change-Id: I77bd99beb8138524b25f0afdcce0815ad8664f0f
Bug-Url: https://bugzilla.redhat.com/1005889
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetFloppyListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IsoListReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HsmGetIsoListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
6 files changed, 108 insertions(+), 48 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77bd99beb8138524b25f0afdcce0815ad8664f0f
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: frontend: Correct default time-zone rendering
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Correct default time-zone rendering
......................................................................
frontend: Correct default time-zone rendering
TimeZoneModel was returning incorrect display value in case the
configured default was invalid. Now it returns display value
corresponding to ultimate fallback for given TimeZoneType.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988259
Change-Id: Ic7be050a48c78ffdf2028ea5acfd0123bf4502a7
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TimeZoneModel.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7be050a48c78ffdf2028ea5acfd0123bf4502a7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: move dialog - modified warnings and styling
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: move dialog - modified warnings and styling
......................................................................
webadmin: move dialog - modified warnings and styling
In order to provide a better indication to which of the
selected disks cannot be moved/copied:
* Added a list of problematic disks [1] into the dialog's warning.
* Added an alert icon next to the warning.
* Altered warnings position and style.
[1] Disks that cannot be moved/copied (e.g. since the source/target
domain is not available).
Change-Id: Ib327915336dfbbdd6e71665b5d3ca603a8843698
Bug-Url: https://bugzilla.redhat.com/975096
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/CopyDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
9 files changed, 53 insertions(+), 27 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19882
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib327915336dfbbdd6e71665b5d3ca603a8843698
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: [core] rename VdsStatic hostname to hostName.
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: [core] rename VdsStatic hostname to hostName.
......................................................................
[core] rename VdsStatic hostname to hostName.
Change field name to match setters and getters.
in UpdateVdsCommand changed attribute names are derived
from getters/setters while the list of changeable fields
are derived from the field name (see vdsHandler.Init())
Change-Id: Ie6461e1ed17506f7ea2a8897ad2a3847d466268f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003282
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6461e1ed17506f7ea2a8897ad2a3847d466268f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: detect display port at runtime
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: detect display port at runtime
......................................................................
packaging: setup: detect display port at runtime
previously the tool wrongly assumed that the SPICE and
the VNC port was always 5900.
It may happen however that secureDisplayPort is set to 5901
instead of 5900.
Now displayPort and secureDisplayPort are detected at runtime
querying the status of the VM.
Firewall ports 5900 and 5901 are now both open.
Change-Id: I8ae46b061b2a3ad0190f798cb141a41431120839
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
M templates/hosted-console.xml.in
2 files changed, 29 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ae46b061b2a3ad0190f798cb141a41431120839
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: detect display port at runtime
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: detect display port at runtime
......................................................................
packaging: setup: detect display port at runtime
previously the tool wrongly assumed that the SPICE and
the VNC port was always 5900.
It may happen however that secureDisplayPort is set to 5901
instead of 5900.
Now displayPort and secureDisplayPort are detected at runtime
querying the status of the VM.
Firewall ports 5900 and 5901 are now both open.
Change-Id: I8ae46b061b2a3ad0190f798cb141a41431120839
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
M templates/hosted-console.xml.in
2 files changed, 29 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19869
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ae46b061b2a3ad0190f798cb141a41431120839
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in otopi[otopi-1.1]: packaging: post otopi-1.1.2
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post otopi-1.1.2
......................................................................
packaging: post otopi-1.1.2
Change-Id: I4478425dde697e1bd467c6f8ff47724b5880671f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M configure.ac
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19924
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4478425dde697e1bd467c6f8ff47724b5880671f
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: otopi-1.1
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 2 months
Change in otopi[otopi-1.1]: packaging: otopi-1.1.2
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: otopi-1.1.2
......................................................................
packaging: otopi-1.1.2
Change-Id: Ia7793d1f9dfeeaca18c964aab581c49805a1c14d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M configure.ac
M otopi.spec.in
3 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7793d1f9dfeeaca18c964aab581c49805a1c14d
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: otopi-1.1
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: packaging: setup: Update sysconfig/nfs contents
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Update sysconfig/nfs contents
......................................................................
packaging: setup: Update sysconfig/nfs contents
conf/nfs.sysconfig.in, which is used to update /etc/sysconfig/nfs,
sets variables that are no longer used in recent fedora nfs-utils
init scripts. This change sets instead variables that are used by
the init system of both new fedora and old fedora/rhel/centos.
Bug-Url: https://bugzilla.redhat.com/1011853
Change-Id: Ibc144c85a14e967c1994d35d36c3b3e16aa5ff77
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/conf/nfs.sysconfig.in
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc144c85a14e967c1994d35d36c3b3e16aa5ff77
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 2 months
Change in otopi[otopi-1.1]: dialog: cli: fix exception show
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: dialog: cli: fix exception show
......................................................................
dialog: cli: fix exception show
Change-Id: I8d834ec974bdf7a0a40888da077f1d46cb2b03a9
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M src/plugins/otopi/dialog/cli.py
2 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d834ec974bdf7a0a40888da077f1d46cb2b03a9
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: otopi-1.1
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 2 months
