October 2013 - Engine-commits - oVirt List Archives

Change in otopi[master]: dialog: cli: fix exception show
by Alon Bar-Lev 07 Oct '13

07 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: cli: fix exception show ...................................................................... dialog: cli: fix exception show Change-Id: I8d834ec974bdf7a0a40888da077f1d46cb2b03a9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/dialog/cli.py 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d834ec974bdf7a0a40888da077f1d46cb2b03a9 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: Do not create a new db on upgrade
by sbonazzo＠redhat.com 07 Oct '13

07 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Do not create a new db on upgrade ...................................................................... packaging: setup: Do not create a new db on upgrade Before this change, the following scenario made engine-setup emit a warning and create a new db: 1. engine-setup 2. service ovirt-engine stop; service postgresql stop 3. engine-setup This change changes the warning to an error (exception) unless it's during cleanup. Bug-Url: https://bugzilla.redhat.com/1014012 Change-Id: Ia336e951860f6e1a6a829cabf5e6b5e10592089b Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/db/connection.py 1 file changed, 14 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia336e951860f6e1a6a829cabf5e6b5e10592089b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: weird message on cleanup if no db
by sbonazzo＠redhat.com 07 Oct '13

07 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: weird message on cleanup if no db ...................................................................... packaging: setup: weird message on cleanup if no db Make engine-cleanup continue gracefully if the database was manually deleted. Change-Id: Iaba0ba1563acbf8c0ef900b304aa577a3dd1f615 Bug-Url: https://bugzilla.redhat.com/1015037 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/db/pgpass.py 1 file changed, 20 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaba0ba1563acbf8c0ef900b304aa577a3dd1f615 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Support JSON serialization in ExternalId
by yzaslavs＠redhat.com 07 Oct '13

07 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Support JSON serialization in ExternalId ...................................................................... core: Support JSON serialization in ExternalId This patch adds a default constructor to the ExternalId class in order to support JSON serialization as required by the compensation mechanism. Change-Id: I51e643893b9e59cb0cacd1779398946f1babe694 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ExternalId.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ExternalIdTest.java 2 files changed, 34 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51e643893b9e59cb0cacd1779398946f1babe694 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Adding FQDN column to VmViews
by tjelinek＠redhat.com 07 Oct '13

07 Oct '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Adding FQDN column to VmViews ...................................................................... frontend: Adding FQDN column to VmViews The VM Views now also display the FQDN of the Virtual Machine Change-Id: If84c4d2a8c1f11e09f3748477a230d7d3188482b Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateVmView.java 6 files changed, 52 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If84c4d2a8c1f11e09f3748477a230d7d3188482b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Open correct bond dialog from Network/Hosts subtab
by iheim＠redhat.com 07 Oct '13

07 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Open correct bond dialog from Network/Hosts subtab ...................................................................... webadmin: Open correct bond dialog from Network/Hosts subtab Apparently the old (pre 3.1) bond dialog would open, when the newer one should. Also removed code that checked if the open dialog is the Setup Networks dialog, which as far as I know is the only possible case in this subtab (whereas in Host/Networks it could have been the pre-3.1 Host Interfaces dialog). Change-Id: Ia5cc40bda079513bfce7b08d6f279aaebe554817 Bug-Url: https://bugzilla.redhat.com/1012821 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java 1 file changed, 9 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/19896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5cc40bda079513bfce7b08d6f279aaebe554817 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: save configuration immediately as available
by ydary＠redhat.com 07 Oct '13

07 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: save configuration immediately as available ...................................................................... packaging: setup: save configuration immediately as available Change-Id: Iaf40ddc7885f7d59a779601fb57d9556c30062be Bug-Url: https://bugzilla.redhat.com/1006950 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 37 insertions(+), 19 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf40ddc7885f7d59a779601fb57d9556c30062be Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Align javadocs with methods' signatures
by amureini＠redhat.com 06 Oct '13

06 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Align javadocs with methods' signatures ...................................................................... engine: Align javadocs with methods' signatures Change-Id: Ib8007f3e800c99cf5cc18a96bce9b8ed372cbf6a Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java 2 files changed, 14 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8007f3e800c99cf5cc18a96bce9b8ed372cbf6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix NPE in UpdateVmDiskCommand
by amureini＠redhat.com 06 Oct '13

06 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Fix NPE in UpdateVmDiskCommand ...................................................................... engine: Fix NPE in UpdateVmDiskCommand The patch http://gerrit.ovirt.org/#/c/19446/ introduces a change which set quota_id as NULL instead of Guid.Empty. It causes NullPointerException in UpdateVmDiskCommand. Change-Id: If689b77cfe4b4a466b70cd9194e99f0eeafcca09 Bug-Url: https://bugzilla.redhat.com/1015872 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If689b77cfe4b4a466b70cd9194e99f0eeafcca09 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Open correct bond dialog from Network/Hosts subtab
by lvernia＠redhat.com 06 Oct '13

06 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Open correct bond dialog from Network/Hosts subtab ...................................................................... webadmin: Open correct bond dialog from Network/Hosts subtab Apparently the old (pre 3.1) bond dialog would open, when the newer one should. Also removed code that checked if the open dialog is the Setup Networks dialog, which as far as I know is the only possible case in this subtab (whereas in Host/Networks it could have been the pre-3.1 Host Interfaces dialog). Change-Id: Ia5cc40bda079513bfce7b08d6f279aaebe554817 Bug-Url: https://bugzilla.redhat.com/1012821 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java 1 file changed, 9 insertions(+), 13 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5cc40bda079513bfce7b08d6f279aaebe554817 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0