November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove unused CommandBase methods
by amureini＠redhat.com 25 Nov '13

25 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused CommandBase methods ...................................................................... core: Remove unused CommandBase methods Change-Id: I7ce604d7f5f3a7a1a49c911691e359c7b9b870fd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ce604d7f5f3a7a1a49c911691e359c7b9b870fd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Add new job update-engine-params
by eedri＠redhat.com 25 Nov '13

25 Nov '13

Eyal Edri has submitted this change and it was merged. Change subject: Add new job update-engine-params ...................................................................... Add new job update-engine-params This job will allow to test upgrades between versions. * Health page check * Supports Centos and Fedora slaves Change-Id: I1809bd55c88b17f1d7dfde3920212e6f046709a8 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- A jobs/ovirt_engine_upgrade_params/answer.file.otopi A jobs/ovirt_engine_upgrade_params/cleanup.file.otopi A jobs/ovirt_engine_upgrade_params/update_engine_params.sh 3 files changed, 264 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, approved Kiril Nesenko: Verified -- To view, visit http://gerrit.ovirt.org/21094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1809bd55c88b17f1d7dfde3920212e6f046709a8 Gerrit-PatchSet: 31 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: fix resource tab layout
by gchaplik＠redhat.com 25 Nov '13

25 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: fix resource tab layout ...................................................................... userportal: fix resource tab layout "Resources" tab on the Power User Portal unable to display all virtual machine disks. Change-Id: I43c9e7550384c2398893ef260d73070418a6f3c4 Bug-Url: https://bugzilla.redhat.com/1013860 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43c9e7550384c2398893ef260d73070418a6f3c4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Set revert operation scope for ImportVMTemplate command
by iheim＠redhat.com 25 Nov '13

25 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Set revert operation scope for ImportVMTemplate command ...................................................................... engine: Set revert operation scope for ImportVMTemplate command Setting this scope will impose ImportVMTemplate command to perform revert in case of failure. Without revert DB continue to keep leftovers from previous run so user can't re-import the same template without cloning it. Change-Id: Ic1d8220f2b4934dc9473d2ad3c4f7ceb4623e3a7 Bug-Url: https://bugzilla.redhat.com/1005788 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1d8220f2b4934dc9473d2ad3c4f7ceb4623e3a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: simplified RunVmValidator#canRunVm method
by rgolan＠redhat.com 25 Nov '13

25 Nov '13

Roy Golan has submitted this change and it was merged. Change subject: core: simplified RunVmValidator#canRunVm method ...................................................................... core: simplified RunVmValidator#canRunVm method The RunVmValidator#canRunVm should be a utility method that invoke the validations which are required for running a VM, but it was also used to have logic which determines whether to invoke images related validations or not. This patch changes the canRunVm method to invoke all the validations (until the first failure) without any filtering. Instead, The images related validations are checking whether the VM has images or not inside. Change-Id: I277a24fa26bb9aae3641aa316689ff7350e9d63f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 37 insertions(+), 29 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I277a24fa26bb9aae3641aa316689ff7350e9d63f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: remove redundant code it VmSnapshotList
by derez＠redhat.com 25 Nov '13

25 Nov '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: remove redundant code it VmSnapshotList ...................................................................... webadmin: remove redundant code it VmSnapshotList VmSnapshotListModel -> createDiskInfoList(): unused legacy method, hence, removing. Change-Id: I5a010064bf31e52ce11085e80cbc4fc33b0a7e3d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 0 insertions(+), 23 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a010064bf31e52ce11085e80cbc4fc33b0a7e3d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: spec: softened deps on websocket-proxy
by iheim＠redhat.com 25 Nov '13

25 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: spec: softened deps on websocket-proxy ...................................................................... packaging: spec: softened deps on websocket-proxy Avoid to require exact version and release on websocket-proxy just requiring an higer or equal version of it. Change-Id: I52394107ed3b35e13746cc3e09a2b971cddaab77 Bug-Url: https://bugzilla.redhat.com/1033629 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52394107ed3b35e13746cc3e09a2b971cddaab77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Log filtering progress in scheduling
by iheim＠redhat.com 25 Nov '13

25 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Log filtering progress in scheduling ...................................................................... core: Log filtering progress in scheduling This logs the filtering step for each Host removal during the scheduling operation to make debugging easier. It also improves the error popup when scheduling fails. The goal is to tell the user why his hosts were removed from the decision process. A logging is also added for the Pin To Host policy unit. https://bugzilla.redhat.com/show_bug.cgi?id=1002005 Change-Id: I4edcc33b0d280ab92e3c98d8d5a7a75386592e32 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1002005 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 164 insertions(+), 13 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4edcc33b0d280ab92e3c98d8d5a7a75386592e32 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: handle non existent OVF quota id
by iheim＠redhat.com 25 Nov '13

25 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: handle non existent OVF quota id ...................................................................... core: handle non existent OVF quota id The fix in Ibcd0b29861a43bcb77acd7c3e0bae58d7b27b8f4 treats empty quota, but not handling other un-existing quota(s) (i.e. quota that was assigned to the snapshot, and then was deleted from the setup). Leaving the former change as well since it can prevent db queries for empty UUID (quota id is set to null). Change-Id: I5de8f2c0cbc12405c34234958a61f61654f2d62d Bug-Url: https://bugzilla.redhat.com/1025773 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5de8f2c0cbc12405c34234958a61f61654f2d62d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: rename member to lowercase in BaseConditionFieldAuto...
by tnisan＠redhat.com 25 Nov '13

25 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: engine: rename member to lowercase in BaseConditionFieldAutoCompleter. ...................................................................... engine: rename member to lowercase in BaseConditionFieldAutoCompleter. Rename to start with lowercase, fixes a findbug warning. Change-Id: I57c4ff1796b595e10b225c6bf7b58067dbd242b5 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57c4ff1796b595e10b225c6bf7b58067dbd242b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0