November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi : Add /networks sub-collection under /datacenters/xx...
by oliel＠redhat.com 25 Nov '13

25 Nov '13

Ori Liel has submitted this change and it was merged. Change subject: restapi : Add /networks sub-collection under /datacenters/xxx(#741111) ...................................................................... restapi : Add /networks sub-collection under /datacenters/xxx(#741111) Adds datacenters/networks links to see specific data center networks. Change-Id: Iacc4a480e3a1270cfcab022549e7f53cfc352c6e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=741111 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNetworksByStoragePoolIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DataCenterResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworkResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworkResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworksResourceTest.java 11 files changed, 546 insertions(+), 2 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacc4a480e3a1270cfcab022549e7f53cfc352c6e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Dont replace . with _ if error not in resources
by kmayilsa＠redhat.com 25 Nov '13

25 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Dont replace . with _ if error not in resources ...................................................................... webadmin: Dont replace . with _ if error not in resources Modified to not to replace . with _ if the error message is NOT found in the resources. This was causing an issue if an error does not exist in resources, and contains full stops or valid "." (e.g. IP Address / FQDN). All of the "." were getting replaced with _ if the error message shown on the screen. Change-Id: I68c8354c7fec9e8a85fbea47bd7e4586f49defdf Bug-Url: https://bugzilla.redhat.com/1024184 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68c8354c7fec9e8a85fbea47bd7e4586f49defdf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Webadmin - Events - Search box...
by emesika＠redhat.com 24 Nov '13

24 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Webadmin - Events - Search box... ...................................................................... core: Webadmin - Events - Search box... Webadmin - Events - Search box: filtering events by time shows bogus results Change-Id: I9c6e1084553e7755849d4d3162fe58ea3f0018c7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025295 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c6e1084553e7755849d4d3162fe58ea3f0018c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: Removing leftover of rootPassword"
by emesika＠redhat.com 24 Nov '13

24 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: Revert "core: Removing leftover of rootPassword" ...................................................................... Revert "core: Removing leftover of rootPassword" This reverts commit 8147c9cbf282d0d00bc671b81083b6827f5d1add Patch breaks UT Change-Id: I2d91042247a0e2b6661ed4329f22c729acc9ff79 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d91042247a0e2b6661ed4329f22c729acc9ff79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3.1]: packaging: setup: added a test on postgres status
by ydary＠redhat.com 24 Nov '13

24 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: added a test on postgres status ...................................................................... packaging: setup: added a test on postgres status It covers for cases where the postgresql service reports status up but the server is not ready to receive connections. In such cases the setup fails on DB operations. This patch updates the change introduced by patch c048ec2d942c Change-Id: I9b5c6ebadb03077e9173e64548883407ca69b502 Bug-Url: https://bugzilla.redhat.com/1029969 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b5c6ebadb03077e9173e64548883407ca69b502 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3.1]: packaging: setup: set correct umask for execution
by ydary＠redhat.com 24 Nov '13

24 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: set correct umask for execution ...................................................................... packaging: setup: set correct umask for execution Change-Id: Ie28c067dbab0e237fa482f2f0f7358d65e1f2ecd Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie28c067dbab0e237fa482f2f0f7358d65e1f2ecd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3.1]: packaging: setup: update db cleanup instructions
by ydary＠redhat.com 24 Nov '13

24 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: update db cleanup instructions ...................................................................... packaging: setup: update db cleanup instructions Change-Id: I36b6ba3ebe1f54e4d2ad1e63bc3eb5b385d59a24 Bug-Url: https://bugzilla.redhat.com/1027378 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 17 insertions(+), 8 deletions(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36b6ba3ebe1f54e4d2ad1e63bc3eb5b385d59a24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3.1]: packaging: setup: set correct umask for execution
by ydary＠redhat.com 24 Nov '13

24 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: set correct umask for execution ...................................................................... packaging: setup: set correct umask for execution Change-Id: I7d74749c9c4c0b65cb99f3023f99b6bd1fe3d30a Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alex Lourie: Verified Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d74749c9c4c0b65cb99f3023f99b6bd1fe3d30a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: handle non existent OVF quota id
by gchaplik＠redhat.com 24 Nov '13

24 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: handle non existent OVF quota id ...................................................................... core: handle non existent OVF quota id The fix in Ibcd0b29861a43bcb77acd7c3e0bae58d7b27b8f4 treats empty quota, but not handling other un-existing quota(s) (i.e. quota that was assigned to the snapshot, and then was deleted from the setup). Leaving the former change as well since it can prevent db queries for empty UUID (quota id is set to null). Change-Id: I5de8f2c0cbc12405c34234958a61f61654f2d62d Bug-Url: https://bugzilla.redhat.com/1025773 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5de8f2c0cbc12405c34234958a61f61654f2d62d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fetch disks internally in RunVmValidator
by ofrenkel＠redhat.com 24 Nov '13

24 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fetch disks internally in RunVmValidator ...................................................................... core: fetch disks internally in RunVmValidator RunVmValidator was used to get the disks of the VM which is going to be run from outside, as a parameter of the canRunVm method. This patch changes this, such that the disks are no longer passed from outside, they are now fetched internally. Change-Id: I0c06577a1fab8c3c912f91a78a4303f83c8edcc0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 4 files changed, 19 insertions(+), 13 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c06577a1fab8c3c912f91a78a4303f83c8edcc0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0