November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: engine: Inform the user when the external scheduler is unava...
by iheim＠redhat.com 25 Nov '13

25 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Inform the user when the external scheduler is unavailable ...................................................................... engine: Inform the user when the external scheduler is unavailable If the external scheduler is configured and not responding, use the Audit log to inform the user about it. Change-Id: I5a3e56e9a8db16b58305b2ebdc2b8041297da093 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1001986 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 2 files changed, 22 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a3e56e9a8db16b58305b2ebdc2b8041297da093 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Set revert operation scope for ImportVMTemplate command
by amureini＠redhat.com 25 Nov '13

25 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Set revert operation scope for ImportVMTemplate command ...................................................................... engine: Set revert operation scope for ImportVMTemplate command Setting this scope will impose ImportVMTemplate command to perform revert in case of failure. Without revert DB continue to keep leftovers from previous run so user can't re-import the same template without cloning it. Change-Id: Ic1d8220f2b4934dc9473d2ad3c4f7ceb4623e3a7 Bug-Url: https://bugzilla.redhat.com/1005788 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1d8220f2b4934dc9473d2ad3c4f7ceb4623e3a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: rename methods to lowercase in Match classes
by amureini＠redhat.com 25 Nov '13

25 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: rename methods to lowercase in Match classes ...................................................................... webadmin: rename methods to lowercase in Match classes Rename 2 methods in the original and the overriden Match classes. Fix all usages. It solves findbug warnings Change-Id: Idd7dd197cd0f9d6761250e7570adf427ed23af58 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Match.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/RegexTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/Match.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java 6 files changed, 21 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd7dd197cd0f9d6761250e7570adf427ed23af58 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Show the notification if host added from CLI
by ofrenkel＠redhat.com 25 Nov '13

25 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: Show the notification if host added from CLI ...................................................................... gluster: Show the notification if host added from CLI The notification for import/detach in Cluster general tab was not being displayed if hosts added from CLI. Fixed the same. Change-Id: Ibc6d586c1c82b0c415a4e898c77b1cedc89e7970 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Shubhendu Tripathi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc6d586c1c82b0c415a4e898c77b1cedc89e7970 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-scheduler-proxy[master]: ovirt-scheduler-proxy-0.1.3-1
by msivak＠redhat.com 25 Nov '13

25 Nov '13

Martin Sivák has submitted this change and it was merged. Change subject: ovirt-scheduler-proxy-0.1.3-1 ...................................................................... ovirt-scheduler-proxy-0.1.3-1 Change-Id: I1eb8101a6e6bb17cab9d1bc0f4346249fed58ae6 Signed-off-by: Martin Sivak <mars(a)montik.net> --- M Makefile M ovirt-scheduler-proxy.spec M setup.py 3 files changed, 10 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1eb8101a6e6bb17cab9d1bc0f4346249fed58ae6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: send db unavailable notification as 'alert' not 'solved'
by masayag＠redhat.com 25 Nov '13

25 Nov '13

Moti Asayag has submitted this change and it was merged. Change subject: tools: send db unavailable notification as 'alert' not 'solved' ...................................................................... tools: send db unavailable notification as 'alert' not 'solved' Change-Id: I6d8637a7cafcafc94eef80a2286530d40f4236c0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007392 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d8637a7cafcafc94eef80a2286530d40f4236c0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SnapshotManager - disk devices might not represent eng...
by tnisan＠redhat.com 25 Nov '13

25 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: SnapshotManager - disk devices might not represent engine disks ...................................................................... core: SnapshotManager - disk devices might not represent engine disks When using the snapshot manager there is an attempt to remove the disks that aren't part of the snaposhot. That's being done by loading the vm disk devices, load the disk for each device and remove it if needed. If the device represented disk isn't a disk known by the engine, do not remove it (as being done for disks that aren't snappable/snapshot disks). Note - This method could be refactored to load the vm disks directly instead of the devices and then the disks. In this patch the null check is be added, while further refactor would be done in follow up changes (the device are synced multiple times, the vm disks could be loaded instead of the devices..etc). Change-Id: Ie38c39c0f0409988a73610fe1dfb9a22afee5553 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1032807 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie38c39c0f0409988a73610fe1dfb9a22afee5553 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-scheduler-proxy[master]: Add ovirt sdk to the java test dependencies
by msivak＠redhat.com 25 Nov '13

25 Nov '13

Martin Sivák has submitted this change and it was merged. Change subject: Add ovirt sdk to the java test dependencies ...................................................................... Add ovirt sdk to the java test dependencies Change-Id: Ib6a6a7152cb2dd3f9829d571f37666d4b368a11d Signed-off-by: Martin Sivak <mars(a)montik.net> --- M tests/java/pom.xml 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6a6a7152cb2dd3f9829d571f37666d4b368a11d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-scheduler-proxy[master]: Failing plugin should not cause an empty host list to be ret...
by msivak＠redhat.com 25 Nov '13

25 Nov '13

Martin Sivák has submitted this change and it was merged. Change subject: Failing plugin should not cause an empty host list to be returned ...................................................................... Failing plugin should not cause an empty host list to be returned Changes the aggregation so that if a plugin is failing, the result is ignored. This prevents the filtering engine from returning an empty host list when something goes wrong. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1002444 Change-Id: Ie1a38e7007cd50f261290bf5f31b85cb9c8c6314 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M src/ovirtscheduler/request_handler.py M src/ovirtscheduler/request_handler_test.py M src/ovirtscheduler/runner.py 3 files changed, 40 insertions(+), 6 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1a38e7007cd50f261290bf5f31b85cb9c8c6314 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename 2 methods in ovf writers to lowercase
by tnisan＠redhat.com 25 Nov '13

25 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename 2 methods in ovf writers to lowercase ...................................................................... core: rename 2 methods in ovf writers to lowercase Rename WriteAppList and WriteContentItems to lowercase. Fix in extending classes as well. Solves findbugs warnings. Change-Id: I39caf18b382473adef6f980b03833591da845631 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 3 files changed, 8 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39caf18b382473adef6f980b03833591da845631 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0