November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: don't iterate map with keyset in LinkHelper
by tnisan＠redhat.com 25 Nov '13

25 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: engine: don't iterate map with keyset in LinkHelper ...................................................................... engine: don't iterate map with keyset in LinkHelper Iterate map with entryset for more efficient iteration. Solves findbug warning of type WMI_WRONG_MAP_ITERATOR Change-Id: I62da8696f89f111b6a3872f02ec8a6dd1663fc34 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62da8696f89f111b6a3872f02ec8a6dd1663fc34 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-3.3.1]: packaging: fixed redirect to reports to not show resend dialog
by ydary＠redhat.com 25 Nov '13

25 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed redirect to reports to not show resend dialog ...................................................................... packaging: fixed redirect to reports to not show resend dialog Change-Id: I22873ff6d2c417f0e71777ce483bb38befad59d3 Bug-Url: https://bugzilla.redhat.com/1033090 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A server-customizations/WEB-INF/jsp/modules/viewReport/ViewReportState.jsp 1 file changed, 80 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22873ff6d2c417f0e71777ce483bb38befad59d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: fixed redirect to reports to not show resend dialog
by ydary＠redhat.com 25 Nov '13

25 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed redirect to reports to not show resend dialog ...................................................................... packaging: fixed redirect to reports to not show resend dialog Change-Id: Idd6f1523100d29d18eb2c8cd10356e779070702a Bug-Url: https://bugzilla.redhat.com/1033090 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A server-customizations/WEB-INF/jsp/modules/viewReport/ViewReportState.jsp 1 file changed, 80 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd6f1523100d29d18eb2c8cd10356e779070702a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Update Jackson version to 1.9.9
by emesika＠redhat.com 25 Nov '13

25 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Update Jackson version to 1.9.9 ...................................................................... core: Update Jackson version to 1.9.9 Change-Id: I3646b12c747935c091c19ba64b4dc0736160c447 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3646b12c747935c091c19ba64b4dc0736160c447 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Unsupported vnic profile features report for 3.0 clu...
by masayag＠redhat.com 25 Nov '13

25 Nov '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Unsupported vnic profile features report for 3.0 clusters ...................................................................... engine: Unsupported vnic profile features report for 3.0 clusters For 3.0 clusters the engine uses the VmOldInfoBuilder to run the VMs. It should consider the usage of unsupported features of the vnic profiles for reporting a warning to the user. Change-Id: I1f01229169e74bdd96ad989e89f7f0beaebf5a4b Bug-Url: https://bugzilla.redhat.com/1024209 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java 3 files changed, 75 insertions(+), 48 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f01229169e74bdd96ad989e89f7f0beaebf5a4b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Prevent usage of shareable disks on Gluster domains
by tnisan＠redhat.com 25 Nov '13

25 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Prevent usage of shareable disks on Gluster domains ...................................................................... core: Prevent usage of shareable disks on Gluster domains To avoid risk of split brain on Gluster domains this patch prevents the creation of shareable disks on Gluster domains as well as the update of existing disks to shareable. Also on creation of a new Gluster domain via webadmin there a message that tells to use Quorum on the Gluster server to ensure data integrity Change-Id: I6d741c93d32fa568c1d1f10429cb325a9b01c359 Bug-Url: https://bugzilla.redhat.com/1024654 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 99 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d741c93d32fa568c1d1f10429cb325a9b01c359 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix the title in error pop ups
by kmayilsa＠redhat.com 25 Nov '13

25 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Fix the title in error pop ups ...................................................................... webadmin: Fix the title in error pop ups Adding the tile of error pop ups. It was empty earlier. Change-Id: I458ab8008b44d1e245e0ece345c5eca58112a3bd Bug-Url: https://bugzilla.redhat.com/1024736 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/21293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I458ab8008b44d1e245e0ece345c5eca58112a3bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix title in About pop up
by kmayilsa＠redhat.com 25 Nov '13

25 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Fix title in About pop up ...................................................................... webadmin: Fix title in About pop up Adding the title for about pop up Change-Id: Ie62c348bdb4ea108217ad4f5a00a032969628d3a Bug-Url: https://bugzilla.redhat.com/1029414 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AboutPopupView.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/21294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie62c348bdb4ea108217ad4f5a00a032969628d3a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename method to start w/lowercase in OvfWriter
by ofrenkel＠redhat.com 25 Nov '13

25 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: rename method to start w/lowercase in OvfWriter ...................................................................... core: rename method to start w/lowercase in OvfWriter Solves a findbug warning. Change-Id: I18912375615114a8b4dacc9eb64f3f812c2154a0 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18912375615114a8b4dacc9eb64f3f812c2154a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: bad keys in osinfo props
by ofrenkel＠redhat.com 25 Nov '13

25 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: bad keys in osinfo props ...................................................................... core: bad keys in osinfo props Change-Id: I8a0170bc33b4aa261743eb361ece5aa8da10180c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1032652 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a0170bc33b4aa261743eb361ece5aa8da10180c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0