November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Don't add permissions via user/roles
by mpastern＠redhat.com 25 Nov '13

25 Nov '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Don't add permissions via user/roles ...................................................................... restapi: Don't add permissions via user/roles Currently permissions can be added using the /api/users/{user:id}/roles collection and doing it results in adding system permissions. The support for adding system permissions has been moved to /api/permissions in a previous patch. This patch makes the /api/users/{user:id}/roles read only so that the only way to add system permissions will be the /api/permissions resource. Change-Id: Id0acfd16d14965cfb7988556ed1b0ec1d3605c1d Bug-Url: https://bugzilla.redhat.com/1018552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedRolesResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResourceTest.java 4 files changed, 2 insertions(+), 246 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0acfd16d14965cfb7988556ed1b0ec1d3605c1d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add system permissions resource
by mpastern＠redhat.com 25 Nov '13

25 Nov '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Add system permissions resource ...................................................................... restapi: Add system permissions resource Currently there is no resource to manage system permissions directly, they are managed indirectly using the users and groups resources. This patch adds a new resource avaiable in /ovirt-engine/api/permissions that will handle these permissions. Change-Id: I3119384b3e7036b0d793a71739d77a1ac5a9cf44 Bug-Url: https://bugzilla.redhat.com/1018552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/SystemPermissionsResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSystemPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEntityAssignedPermissionsResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSystemAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermissionMapper.java 11 files changed, 202 insertions(+), 12 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3119384b3e7036b0d793a71739d77a1ac5a9cf44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: softened deps on websocket-proxy
by sbonazzo＠redhat.com 25 Nov '13

25 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: softened deps on websocket-proxy ...................................................................... packaging: spec: softened deps on websocket-proxy Avoid to require exact version and release on websocket-proxy just requiring an higer or equal version of it. Change-Id: I52394107ed3b35e13746cc3e09a2b971cddaab77 Bug-Url: https://bugzilla.redhat.com/1033629 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52394107ed3b35e13746cc3e09a2b971cddaab77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Run activate if remove bricks task is FINISHED
by kmayilsa＠redhat.com 25 Nov '13

25 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: restapi: Run activate if remove bricks task is FINISHED ...................................................................... restapi: Run activate if remove bricks task is FINISHED Modified to allow activate action only if the remove bricks task is completed and currently marked as FINISHED in engine. Change-Id: Ifd5731b43132943a808bccae68fbcf0efaeeef89 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/Messages.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java M backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties 4 files changed, 24 insertions(+), 3 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd5731b43132943a808bccae68fbcf0efaeeef89 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Cleanup XmlUtils
by rgolan＠redhat.com 25 Nov '13

25 Nov '13

Roy Golan has submitted this change and it was merged. Change subject: core: Cleanup XmlUtils ...................................................................... core: Cleanup XmlUtils Remove commented-out code from XmlUtils. Change-Id: Ica7575d2c36f381a60a1e038a087f1e54f05be54 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/XmlUtils.java 1 file changed, 0 insertions(+), 70 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica7575d2c36f381a60a1e038a087f1e54f05be54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix FindBugs filter for XmlNode.innerText
by rgolan＠redhat.com 25 Nov '13

25 Nov '13

Roy Golan has submitted this change and it was merged. Change subject: core: Fix FindBugs filter for XmlNode.innerText ...................................................................... core: Fix FindBugs filter for XmlNode.innerText Commit d377d275416edbbd3f4b1d57047ee04840412bba renamed XmlNode's InnerText field to innerText, but neglected to update the FindBugs filter referring to it. This patch corrects that mistake. Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/exclude-filters.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused XmlDocument.nameTable
by rgolan＠redhat.com 25 Nov '13

25 Nov '13

Roy Golan has submitted this change and it was merged. Change subject: core: Remove unused XmlDocument.nameTable ...................................................................... core: Remove unused XmlDocument.nameTable XmlDocument.nameTable is never initialized and therefore is always null. Since it holds no data, it can safely be removed. The only place this field was ever referenced was by calls to new XmlNamespaceManager(Object), which simply ignored the passed object. Since this parameter is not used anyway, and is always called with XmlDocument.nameTable, the constructor was changed and the parameter was removed. Change-Id: Ie922fdd01d85a6f61fadaccd2a20263c7d013f85 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlDocument.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlNamespaceManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 4 files changed, 3 insertions(+), 4 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie922fdd01d85a6f61fadaccd2a20263c7d013f85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove unused class StorageDomainGuidListReturnForXmlRpc
by tnisan＠redhat.com 25 Nov '13

25 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: remove unused class StorageDomainGuidListReturnForXmlRpc ...................................................................... core: remove unused class StorageDomainGuidListReturnForXmlRpc Change-Id: Ib7ef7b40745326653392ffceca6768abdc9dbefb Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StorageDomainGuidListReturnForXmlRpc.java 1 file changed, 0 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7ef7b40745326653392ffceca6768abdc9dbefb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename methods in VdsStatic to lowercase
by tnisan＠redhat.com 25 Nov '13

25 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename methods in VdsStatic to lowercase ...................................................................... core: rename methods in VdsStatic to lowercase Solve several findbugs warnings. Change-Id: Ic43671534043bb43103c38607210c2ba121ac286 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VdsStaticTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 3 files changed, 8 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic43671534043bb43103c38607210c2ba121ac286 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix method to lowercase in ErrorTranslator
by tnisan＠redhat.com 25 Nov '13

25 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: fix method to lowercase in ErrorTranslator ...................................................................... core: fix method to lowercase in ErrorTranslator Change-Id: Id3d032edc4124692312de2f95d6a68b9d239a86e Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3d032edc4124692312de2f95d6a68b9d239a86e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0