November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: backend: prevent live storage migration on live snapshot fai...
by iheim＠redhat.com 18 Nov '13

18 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: backend: prevent live storage migration on live snapshot failure ...................................................................... backend: prevent live storage migration on live snapshot failure Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018876 Change-Id: I7c69f663836e74691c968f4a15c5f3012479a8b0 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 3 files changed, 20 insertions(+), 11 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c69f663836e74691c968f4a15c5f3012479a8b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Do not delete /etc/exports in cleanup
by iheim＠redhat.com 18 Nov '13

18 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: Do not delete /etc/exports in cleanup ...................................................................... packaging: setup: Do not delete /etc/exports in cleanup Bug-Url: https://bugzilla.redhat.com/1031557 Change-Id: If3aabc22e69c2a4dfae69915d8994c97f0265330 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3aabc22e69c2a4dfae69915d8994c97f0265330 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor refactoring in RunVmValidator
by ofrenkel＠redhat.com 18 Nov '13

18 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor refactoring in RunVmValidator ...................................................................... core: minor refactoring in RunVmValidator - rename methods which are validating network related stuff to being with 'validate' - moved CanRunVm to the top of the class - organized the class methods order such that the validation methods would be grouped together and the utility method be in the buttom Change-Id: I80ac05cb4028578364ef710603a674834a33a1a2 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 185 insertions(+), 178 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80ac05cb4028578364ef710603a674834a33a1a2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Add support for email notifications
by gpadgett＠redhat.com 18 Nov '13

18 Nov '13

Greg Padgett has submitted this change and it was merged. Change subject: Add support for email notifications ...................................................................... Add support for email notifications This adds a support for configurable email notifications. Currently only state machine transitions generate a notification event. The event is then processed by broker and email is sent to recipients. Events are filtered according to a config file broker.conf. If the event type exists as a key in [notify] section and the detail field contains the value assigned to that key (case insen- sitive regex matching applies) then the email is sent. Change-Id: Ibb466b8b130b75705f3cc9f817e377e79b3e81ba Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/Makefile.am A ovirt_hosted_engine_ha/broker/broker.conf M ovirt_hosted_engine_ha/broker/constants.py.in M ovirt_hosted_engine_ha/broker/listener.py A ovirt_hosted_engine_ha/broker/notifications.py A ovirt_hosted_engine_ha/broker/notifications/Makefile.am A ovirt_hosted_engine_ha/broker/notifications/state_transition.txt M ovirt_hosted_engine_ha/env/Makefile.am M ovirt_hosted_engine_ha/lib/brokerlink.py 12 files changed, 193 insertions(+), 2 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb466b8b130b75705f3cc9f817e377e79b3e81ba Gerrit-PatchSet: 11 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Perform hotunplug checks only when dettaching activate...
by iheim＠redhat.com 18 Nov '13

18 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Perform hotunplug checks only when dettaching activated disk ...................................................................... core: Perform hotunplug checks only when dettaching activated disk When detaching a disk from a vm, the hotplug related checks should be performed only if the disk is actually plugged to the vm. Change-Id: Ifc1ac3f30a1f144314cbff51c9c51703d1fb48b1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029853 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc1ac3f30a1f144314cbff51c9c51703d1fb48b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: make RunVmValidator stateful
by ofrenkel＠redhat.com 18 Nov '13

18 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: make RunVmValidator stateful ...................................................................... core: make RunVmValidator stateful RunVmValidator, as implied by its name, contains validations that should be checked before running a VM. The relevant information for those validations is the VM which is going to be run, the parameters for the run command and whether the run command is internal or not. This patch changes RunVmValidator to take the information it needs, which is mentioned above, at creation time (i.e as arguments in its constructor) and save it as part of the instance state. That way, we won't need to pass it on each invocation from outside of this class. Change-Id: I5f2f0ce4a0a92ff610f5c2a8be1e084f0c188f77 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 4 files changed, 35 insertions(+), 50 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f2f0ce4a0a92ff610f5c2a8be1e084f0c188f77 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent: don't crash on failed migrateStatus
by gpadgett＠redhat.com 18 Nov '13

18 Nov '13

Greg Padgett has submitted this change and it was merged. Change subject: agent: don't crash on failed migrateStatus ...................................................................... agent: don't crash on failed migrateStatus A failed migration would trigger an unexpected failure within the agent. Instead, catch the failure and process it appropriately. Change-Id: I9da40599098446e6915a2bd675096d00fa07516d Bug-Url: https://bugzilla.redhat.com/1026377 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 23 insertions(+), 15 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9da40599098446e6915a2bd675096d00fa07516d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent: fixes for startup
by gpadgett＠redhat.com 18 Nov '13

18 Nov '13

Greg Padgett has submitted this change and it was merged. Change subject: agent: fixes for startup ...................................................................... agent: fixes for startup Various changes to help track agent logic during startup and allow the startup to succeed. Change-Id: I6e0c0dbeb50c2181b29565f0d933ad56ec05bb7b Bug-Url: https://bugzilla.redhat.com/1018849 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e0c0dbeb50c2181b29565f0d933ad56ec05bb7b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: enforce NFS storage
by sbonazzo＠redhat.com 18 Nov '13

18 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: enforce NFS storage ...................................................................... packaging: setup: enforce NFS storage enforce NFS storage until glusterfs issues will be solved. Change-Id: Ic446dc976e435e490d76c6ec6d9076f9cb8322ee Bug-Url: https://bugzilla.redhat.com/1031510 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 22 insertions(+), 17 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic446dc976e435e490d76c6ec6d9076f9cb8322ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: cloud-init - rest api for start vm
by ofrenkel＠redhat.com 18 Nov '13

18 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: restapi: cloud-init - rest api for start vm ...................................................................... restapi: cloud-init - rest api for start vm Support using cloud-init to perform initial setup of virtual machines. Further details available at: http://www.ovirt.org/Features/Cloud-Init_Integration This patch adds support for specifying Cloud-Init configuration when starting a VM using the REST API. Change-Id: I6ad0bfeca23cf8d4b2887010081d63c258032611 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PayloadEncoding.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/CloudInitValidator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/VmValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 9 files changed, 353 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ad0bfeca23cf8d4b2887010081d63c258032611 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0