November 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-reports[ovirt-3.3.1]: reports: enable full text in ods export format

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: reports: enable full text in ods export format ...................................................................... reports: enable full text in ods export format Change-Id: Ia1cc67532ae76b7cde12b9cf9ed9f22e57cfe44f Bug-Url: https://bugzilla.redhat.com/722819 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M server-customizations/WEB-INF/classes/jasperreports.properties 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1cc67532ae76b7cde12b9cf9ed9f22e57cfe44f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: change Win 2008 sound device to ac97

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: change Win 2008 sound device to ac97 ...................................................................... core: change Win 2008 sound device to ac97 Change-Id: Ie55a00f9dfbc93507bebf47298dfa8fb9dcde77c Signed-off-by: Roy Golan <rgolan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025000 --- M packaging/conf/osinfo-defaults.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie55a00f9dfbc93507bebf47298dfa8fb9dcde77c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: rename methods to lowercase in AsyncTaskManager

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: rename methods to lowercase in AsyncTaskManager ...................................................................... core: rename methods to lowercase in AsyncTaskManager Change-Id: Idd78086c1628422ab24f229927115c6bdf6670ba Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alissa Bonas: Verified -- To view, visit http://gerrit.ovirt.org/21417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd78086c1628422ab24f229927115c6bdf6670ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: ui: use equals comparison for alignment attribute

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: ui: use equals comparison for alignment attribute ...................................................................... ui: use equals comparison for alignment attribute Using string equals comparison instead of by reference. Note: StringHelper is deprecated - using stringsEqual just for keeping the current convention and ease later cleanup of the class. Change-Id: I5769aa78f4bc740c7fad7ca22af996c9a221ba76 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5769aa78f4bc740c7fad7ca22af996c9a221ba76 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: rename find methods to lowercase in DirectorySearcher

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: rename find methods to lowercase in DirectorySearcher ...................................................................... core: rename find methods to lowercase in DirectorySearcher Change-Id: I143b39bb7520e5d43fecc1c2723e0425c6567692 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapChangeUserPasswordCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdGroupByGroupIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserNameCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchGroupsByQueryCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchUserByQueryCommand.java 9 files changed, 10 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I143b39bb7520e5d43fecc1c2723e0425c6567692 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Host shouldn't move to UP if it's already connected to...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: Host shouldn't move to UP if it's already connected to other pool ...................................................................... core: Host shouldn't move to UP if it's already connected to other pool When host fails to connect to the pool, it shouldn't move to UP if it's already connected to other pool regardless of the master domain status. Regardless of this change, the error handling in ConnectStoragePoolVdsCommand should be changed as well as the error handling in it's callers, this change handles InitVdsOnUp. Change-Id: Ifd3d8268516b010f7831b59bbc6331cfd70efec1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1023732 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 14 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd3d8268516b010f7831b59bbc6331cfd70efec1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: InitVdsOnUp - flow fixes

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: InitVdsOnUp - flow fixes ...................................................................... core: InitVdsOnUp - flow fixes 1. If the master domain is inactive/unknown - a host shouldn't fail this phase of the flow if it respondes to getVdsStats. 2. If the master domain is inactive/unknown - the host shouldn't fail the flow according to it's domain report. Examples for relevant scenarios: 1. When there are no active hosts, all the domains are marked as "unknown", if we will attempt to activate a host and it won't be able to connect to the pool because of VDS_NETWORK_ERROR, the host won't move to UP because of the check of it's domain report. 2. When there are no active hosts and a host is being activated, successfully connects to the pool and it can't see any of the domains it won't move to UP because of it's domain report. Change-Id: I61fcc58be133efdecf264c22015609f6ee3ed942 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031632 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 19 insertions(+), 18 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61fcc58be133efdecf264c22015609f6ee3ed942 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: gluster: Remove non-readable characters in gluster volume wa...

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Remove non-readable characters in gluster volume warning messages ...................................................................... gluster: Remove non-readable characters in gluster volume warning messages Remove <br/> characters and updated with \n in UIConstants.java file for distributed replicate volume warning messages. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021982 Change-Id: I1cc9a1fc33fdc28abb930f8fefbb65432436919a Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cc9a1fc33fdc28abb930f8fefbb65432436919a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: avoid confusing messages on db credentials

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid confusing messages on db credentials ...................................................................... packaging: setup: avoid confusing messages on db credentials removed confusing message: Using existing credentials If we're not asking for credentials, if we're not provisioning it's implicit and if we're provisioning it's not true. Change-Id: I0a83fb945c49c7c2c2b4ad49d0dbd87e42144d54 Bug-Url: https://bugzilla.redhat.com/1030829 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/db/connection.py 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a83fb945c49c7c2c2b4ad49d0dbd87e42144d54 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: backend: unlock images when GetImageInfo fails

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: backend: unlock images when GetImageInfo fails ...................................................................... backend: unlock images when GetImageInfo fails In BaseImagesCommand.endSuccessfully() we try to update the image information contacting VDSM. If VDSM is down or for any other error we should fail gracefully (logging) and release the locks on the image. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018876 Change-Id: I980e60ba5ad4fcc07752d065c3eaca03af025896 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 17 insertions(+), 10 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I980e60ba5ad4fcc07752d065c3eaca03af025896 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2013