November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: rename method to lowercase in StoragePoolStatusHandler
by tnisan＠redhat.com 18 Nov '13

18 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename method to lowercase in StoragePoolStatusHandler ...................................................................... core: rename method to lowercase in StoragePoolStatusHandler Change-Id: I0fee3a61d67f68fef7ad57897b2a78756ef6ba5b Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolStatusHandler.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fee3a61d67f68fef7ad57897b2a78756ef6ba5b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename methods to lowercase
by tnisan＠redhat.com 18 Nov '13

18 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename methods to lowercase ...................................................................... core: rename methods to lowercase Change-Id: I3c66ffea5392c0e6287b9f22a34351d614c3d805 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetHardwareInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 6 files changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Alissa Bonas: Verified -- To view, visit http://gerrit.ovirt.org/21346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c66ffea5392c0e6287b9f22a34351d614c3d805 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Set min connection pool size to 1
by iheim＠redhat.com 18 Nov '13

18 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Set min connection pool size to 1 ...................................................................... core: Set min connection pool size to 1 In a previous patch we changed the default minimum database connection pool size to 75 (it used to be 1). This was done in order to have database connections ready from the very beginning and thus improve performance. But in practice this means that 75 PostgreSQL processes are created wether they are needed or not. These consume approx 2.1 GiB of RAM. In machines with a total of 4 GiB this evantually triggers the out of memory killer of the kernel, which will in turn select the process that is using more memory, which usually happens to be the engine itself, so it is killed. This patch changes the default minimum size back to 1 to avoid this issue. Change-Id: I9de2c9e6999cb22a4be99eabb66a7216e673d0d2 Bug-Url: https://bugzilla.redhat.com/1026100 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9de2c9e6999cb22a4be99eabb66a7216e673d0d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: make sdk agnostic to base URI of api
by mpastern＠redhat.com 18 Nov '13

18 Nov '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: make sdk agnostic to base URI of api ...................................................................... sdk: make sdk agnostic to base URI of api Change-Id: Iff1c103aba94d2006ae8be44c18c0bdede4cddbf Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/web/connection.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff1c103aba94d2006ae8be44c18c0bdede4cddbf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.2]: UX: remove alarming warning
by sbonazzo＠redhat.com 18 Nov '13

18 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: remove alarming warning ...................................................................... UX: remove alarming warning After upgrading from 3.1 users was warned about a legacy config still present in conf files if the user forgot to update .conf file with the one provided by the package as .rpmnew. The tool is able to use the legacy configuration so no need to alarm the user about that. Change-Id: I9759186af11f6894c9bb45735b39bb9ddee2bf30 Bug-Url: https://bugzilla.redhat.com/1031607 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9759186af11f6894c9bb45735b39bb9ddee2bf30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: DetachDiskFromVm - redundant checks and ctor usage
by tnisan＠redhat.com 18 Nov '13

18 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: DetachDiskFromVm - redundant checks and ctor usage ...................................................................... core: DetachDiskFromVm - redundant checks and ctor usage When executing DetachDiskFromVm command, the used parameters c'tor was always called with true for "isPlugUnplug" property. That means that the relevant checks within the command where always relevant to that value only. This patch removes the unneeded CDA check and move the callers of the command to use the two parameters c'tor. Change-Id: I48536a5baf4851c68f6d7053e4751d53a54f56a1 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 4 files changed, 6 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48536a5baf4851c68f6d7053e4751d53a54f56a1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: don't send cloud-init drive automatically
by iheim＠redhat.com 18 Nov '13

18 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: don't send cloud-init drive automatically ...................................................................... core: don't send cloud-init drive automatically Currently cloud init is sent automatically on first run, just as sysprep is sent for windows vms. The problem is that currently cloud init configuration is not stored in the engine db, while sysprep does (in sysprep files). Until this gap is implemented, this patch changes the logic not to send cloud init drive automatically, only on user request. Change-Id: I94e36467b9f9002105e3eedda34c53ec43f590e1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014194 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94e36467b9f9002105e3eedda34c53ec43f590e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: ignore non-working legacy pgpass
by iheim＠redhat.com 18 Nov '13

18 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: ignore non-working legacy pgpass ...................................................................... packaging: setup: ignore non-working legacy pgpass Bug-Url: https://bugzilla.redhat.com/1022932 Change-Id: Iddad631ff679f3ba2e338c0925e046ff569b587e Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/legacy/database.py 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddad631ff679f3ba2e338c0925e046ff569b587e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: vdsm: packages: adjust to new method of vdsm configure
by Alon Bar-Lev 18 Nov '13

18 Nov '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: packages: adjust to new method of vdsm configure ...................................................................... vdsm: packages: adjust to new method of vdsm configure Change-Id: Iec69d6ab5cdd00132198f882b0f1d0a1ff790f8b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/packages.py 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved Yaniv Bronhaim: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec69d6ab5cdd00132198f882b0f1d0a1ff790f8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Adapt RSDL To New URL
by mpastern＠redhat.com 18 Nov '13

18 Nov '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Adapt RSDL To New URL ...................................................................... restapi: Adapt RSDL To New URL Change-Id: Ifcb36ceebfc032a2984176087aade97bfda25f4b Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 355 insertions(+), 355 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcb36ceebfc032a2984176087aade97bfda25f4b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0