November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: setup: enforce NFS storage
by sbonazzo＠redhat.com 18 Nov '13

18 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: enforce NFS storage ...................................................................... packaging: setup: enforce NFS storage enforce NFS storage until glusterfs issues will be solved. Change-Id: Ic446dc976e435e490d76c6ec6d9076f9cb8322ee Bug-Url: https://bugzilla.redhat.com/1031510 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 22 insertions(+), 17 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic446dc976e435e490d76c6ec6d9076f9cb8322ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename methods get/setData to lowercase in SessionData...
by tnisan＠redhat.com 18 Nov '13

18 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename methods get/setData to lowercase in SessionDataContainer ...................................................................... core: rename methods get/setData to lowercase in SessionDataContainer Change-Id: I08450d9055fda669a2d00a8e2dfdbe902bf567c8 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/session/SessionDataContainerTest.java 2 files changed, 37 insertions(+), 37 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08450d9055fda669a2d00a8e2dfdbe902bf567c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[cli_3.3]: cli: release 3.3.0.6-1
by mpastern＠redhat.com 18 Nov '13

18 Nov '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.3.0.6-1 ...................................................................... cli: release 3.3.0.6-1 Change-Id: I4b32baaaefa56490ccb9e4def5573b5d3e079b97 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b32baaaefa56490ccb9e4def5573b5d3e079b97 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.3 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename methods in VdsManager
by tnisan＠redhat.com 18 Nov '13

18 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename methods in VdsManager ...................................................................... core: rename methods in VdsManager Rename to lowercase to solve findbugs warnings, and all usages accordingly. Change-Id: Ib7e36fab1e64786e323bf33bb82eff99b660f582 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/UpdateVdsVMsClearedVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 5 files changed, 13 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7e36fab1e64786e323bf33bb82eff99b660f582 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: workaround for Firefox favicon bug
by vszocs＠redhat.com 18 Nov '13

18 Nov '13

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal, webadmin: workaround for Firefox favicon bug ...................................................................... userportal, webadmin: workaround for Firefox favicon bug Workaround for Firefox bug https://bugzilla.mozilla.org/show_bug.cgi?id=519028, 'change location.hash leads to location bar icon (favicon) disappearance.' The symptom is that the favicon disappears in Firefox on the initial hashchange when logging in. The workaround is to simply detach and re-attach the favicon link element on hashchange by overriding ApplicationPlaceManager.onValueChange, and only in Firefox by checking the user-agent. Change-Id: Ia4b0d8a0176eb9299aec01ae6772297409ef3108 Bug-Url: https://bugzilla.redhat.com/999436 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/favicon.tag M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/UserPortalPlaceManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/WebAdminPlaceManager.java 4 files changed, 43 insertions(+), 7 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4b0d8a0176eb9299aec01ae6772297409ef3108 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: UX: remove alarming warning
by sbonazzo＠redhat.com 18 Nov '13

18 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: remove alarming warning ...................................................................... UX: remove alarming warning After upgrading from 3.1 users was warned about a legacy config still present in conf files if the user forgot to update .conf file with the one provided by the package as .rpmnew. The tool is able to use the legacy configuration so no need to alarm the user about that. Change-Id: I20a8ab68463e96acf5ca864c28b1d6662b734123 Bug-Url: https://bugzilla.redhat.com/1031604 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20a8ab68463e96acf5ca864c28b1d6662b734123 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.2]: UX: remove alarming warning
by sbonazzo＠redhat.com 18 Nov '13

18 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: remove alarming warning ...................................................................... UX: remove alarming warning After upgrading from 3.1 users was warned about a legacy config still present in conf files if the user forgot to update .conf file with the one provided by the package as .rpmnew. The tool is able to use the legacy configuration so no need to alarm the user about that. Change-Id: I2c2d666b57721ec5f3fbb7dc70319a5745521908 Bug-Url: https://bugzilla.redhat.com/1031605 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c2d666b57721ec5f3fbb7dc70319a5745521908 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[master]: agent, broker, lib: less logging at INFO level
by gpadgett＠redhat.com 18 Nov '13

18 Nov '13

Greg Padgett has submitted this change and it was merged. Change subject: agent, broker, lib: less logging at INFO level ...................................................................... agent, broker, lib: less logging at INFO level Decrease the amount of output going to the logs at INFO level. Accomplished via: - moving some logging calls from INFO to DEBUG - log agent metadata only occasionally or when changed - fix the log filter which assists intermittent logging - apply said filter to additional log statements to silence some redundant updates Also double retention to 8 log files rather than 4. Change-Id: I8b4614a6ea23c2813c0341e03171328e24f148c8 Bug-Url: https://bugzilla.redhat.com/1019471 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/agent-log.conf.in M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/broker-log.conf.in M ovirt_hosted_engine_ha/broker/storage_broker.py M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py M ovirt_hosted_engine_ha/broker/submonitors/mem_free.py M ovirt_hosted_engine_ha/broker/submonitors/mem_load.py M ovirt_hosted_engine_ha/broker/submonitors/mgmt_bridge.py M ovirt_hosted_engine_ha/broker/submonitors/ping.py M ovirt_hosted_engine_ha/lib/brokerlink.py M ovirt_hosted_engine_ha/lib/log_filter.py 12 files changed, 124 insertions(+), 74 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b4614a6ea23c2813c0341e03171328e24f148c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename method to to lowercase in command DetachUserFro...
by tnisan＠redhat.com 18 Nov '13

18 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename method to to lowercase in command DetachUserFromVmFromPoolCommand ...................................................................... core: rename method to to lowercase in command DetachUserFromVmFromPoolCommand Rename method to start with lowercase to solve a findbug warning. Change-Id: I1098c2dcdfe3f460ebf11ab51399639ab036a00c Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1098c2dcdfe3f460ebf11ab51399639ab036a00c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename method to lowercase in VmPoolHandler
by tnisan＠redhat.com 18 Nov '13

18 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename method to lowercase in VmPoolHandler ...................................................................... core: rename method to lowercase in VmPoolHandler Change-Id: I3508a78bfb15a39c41eb8147f83297fd4b4456bf Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java 7 files changed, 8 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3508a78bfb15a39c41eb8147f83297fd4b4456bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0