November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: packaging: setup: update DB configuration reading
by ydary＠redhat.com 12 Nov '13

12 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: update DB configuration reading ...................................................................... packaging: setup: update DB configuration reading This new implementation requires engine and dwh to be run and set up correctly before reports package can be setup. In case engine's or dwh settings are not found, the setup will exit with the corresponding message. Also it updates DB conf to be defined in a spec file. Change-Id: I430eee10a06fabeab24c9f4f240373a7b830878a Bug-Url: https://bugzilla.redhat.com/1026089 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile A packaging/10-setup-database-reports.conf M packaging/ovirt-engine-reports-setup.py M packaging/ovirt-engine-reports.spec.in 4 files changed, 22 insertions(+), 20 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I430eee10a06fabeab24c9f4f240373a7b830878a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "engine : Remove unneeded VdsDynamic updates"
by emesika＠redhat.com 12 Nov '13

12 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: Revert "engine : Remove unneeded VdsDynamic updates" ...................................................................... Revert "engine : Remove unneeded VdsDynamic updates" This reverts commit 2bf66f81ba2a203c0b36640352070aaf9c1f952f. Change-Id: I5ba3d7cde9631304f021dbb856436a2d38c24c5a Signed-Off-By: lzelkha(a)redhat.com --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ba3d7cde9631304f021dbb856436a2d38c24c5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Require a lock fo VdsNonReposonding treatment
by rgolan＠redhat.com 12 Nov '13

12 Nov '13

Roy Golan has submitted this change and it was merged. Change subject: core: Require a lock fo VdsNonReposonding treatment ...................................................................... core: Require a lock fo VdsNonReposonding treatment this is an addition for 1026811 work Change-Id: I709ea327b5f66ab5a676e5e13776752ca650d4be Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026811 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I709ea327b5f66ab5a676e5e13776752ca650d4be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Changed VdcBllErrors.InvalidPhysDev
by amureini＠redhat.com 12 Nov '13

12 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Changed VdcBllErrors.InvalidPhysDev ...................................................................... core: Changed VdcBllErrors.InvalidPhysDev Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev gave a cryptic error message - Invalid physical device. The message was amended into "Multipath cannot access physical device". The error key was changed according to the new message content. The error code remains the same. The corresponding exception was also changed in vdsm - I648ee519873c51573e6e6306b79380f54bb25d2e , though there's no dependency between the two patches (communicate through code, which remains the same). Change-Id: I50d91d159766ba9071f532fa56b6b90bd9d5d766 Bug-Url: https://bugzilla.redhat.com/852003 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 5 files changed, 5 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/21168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50d91d159766ba9071f532fa56b6b90bd9d5d766 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: update Makefile and spec to include DB set...
by ydary＠redhat.com 12 Nov '13

12 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: update Makefile and spec to include DB settings ...................................................................... packaging: setup: update Makefile and spec to include DB settings Related-To: https://bugzilla.redhat.com/1026089 Change-Id: I8bbe4b4b3a156d127a938cac089272c3ae3fcd90 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile A packaging/10-setup-database-dwh.conf M packaging/ovirt-engine-dwh.spec.in 3 files changed, 8 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bbe4b4b3a156d127a938cac089272c3ae3fcd90 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: add 3 exclude to findbugs filter.
by tnisan＠redhat.com 12 Nov '13

12 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: userportal: add 3 exclude to findbugs filter. ...................................................................... userportal: add 3 exclude to findbugs filter. Similar to webadmin, the *Presenter classes have a redundant warning on selectedItems field. It should be ignored by findbugs. Change-Id: I7c2c7846358d135c9c19fb4cde585f47e50f5ad2 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml 1 file changed, 37 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c2c7846358d135c9c19fb4cde585f47e50f5ad2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: cleanup: pep8 fixes
by sbonazzo＠redhat.com 12 Nov '13

12 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: cleanup: pep8 fixes ...................................................................... cleanup: pep8 fixes Change-Id: Ida936c5ace6067538dd46d7580565e0e56df0955 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/domain_type.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/21157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida936c5ace6067538dd46d7580565e0e56df0955 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix Junit issue Add caching to VdsStatic, VdsDynamic...
by emesika＠redhat.com 12 Nov '13

12 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: engine: Fix Junit issue Add caching to VdsStatic, VdsDynamic, VdsGroup and VdsSpmIdMap ...................................................................... engine: Fix Junit issue Add caching to VdsStatic, VdsDynamic, VdsGroup and VdsSpmIdMap Add caching to VdsStatic, VdsDynamic, VdsGroup and VdsSpmIdMap introduced a failure in unit test Change-Id: If114e0a7ef3c5260e507c28715479b486524e33e Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommandTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategyTest.java 8 files changed, 11 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If114e0a7ef3c5260e507c28715479b486524e33e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Disable Host/Interfaces subtab refresh pre-3.1
by lvernia＠redhat.com 12 Nov '13

12 Nov '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Disable Host/Interfaces subtab refresh pre-3.1 ...................................................................... webadmin: Disable Host/Interfaces subtab refresh pre-3.1 In pre-3.1 clusters, host networking is setup through the subtab, and refreshing the subtab (for the statistics) makes that hard to do as it resets the row selection. Change-Id: Idb1d14be079936eac2fb302320eb7000e970bc32 Bug-Url: https://bugzilla.redhat.com/1027597 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java 4 files changed, 31 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb1d14be079936eac2fb302320eb7000e970bc32 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: sp name should start with upper case letter
by gchaplik＠redhat.com 12 Nov '13

12 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: db: sp name should start with upper case letter ...................................................................... db: sp name should start with upper case letter Change-Id: Ida29145a5004ba39929ea0931b23e4c0e13be68f Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M packaging/dbscripts/image_storage_domain_map_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida29145a5004ba39929ea0931b23e4c0e13be68f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0