November 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine-cli[cli_3.3]: cli: x-identifier auto-completion doesn't work in permission...

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: x-identifier auto-completion doesn't work in permissions(#1027281) ...................................................................... cli: x-identifier auto-completion doesn't work in permissions(#1027281) append of -identifier suffix for vm object at permission auto-completion doesn't work for list/show/remove commands. Change-Id: Id9b1578dada8a3810bec766951e346c59abad61f Bug-Url: https://bugzilla.redhat.com/1027281 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/utils/autocompletionhelper.py 1 file changed, 24 insertions(+), 6 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9b1578dada8a3810bec766951e346c59abad61f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.3 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: x-identifier auto-completion doesn't work in permission...

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: x-identifier auto-completion doesn't work in permissions(#1027281) ...................................................................... cli: x-identifier auto-completion doesn't work in permissions(#1027281) append of -identifier suffix for vm object at permission auto-completion doesn't work for list/show/remove commands. Change-Id: Id9b1578dada8a3810bec766951e346c59abad61f Bug-Url: https://bugzilla.redhat.com/1027281 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/utils/autocompletionhelper.py 1 file changed, 24 insertions(+), 6 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/21046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9b1578dada8a3810bec766951e346c59abad61f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: prevent split brain caused by fence commands

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: prevent split brain caused by fence commands ...................................................................... core: prevent split brain caused by fence commands This fix aims to run fence command mutually exclusive. RestartVds is running Stop, FenceManually and Start. This flow is marking VMs as down and playing them again on other hosts. 2 parallel calls to this flow or interleacing RestartVds with other Stop or FenceManaually could end up marking again VMs whic currently starting up by flow 1 as down, causing them to start and new instance on other host and leading to 2 instances of the same VM. To Achieve this mutually exclusive run: * Added exclusive lock on VDS_FENCE + vdsId on RestartVds, Stop, FenceManually and Start commands * Shared the lock from parent RestartVds with childs Stop, FenceManually and start * overriden freeLock() method of Stop, FenceManually and Start to release the lock only if we have been invoked without RestartVds as a parent command Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026811 Change-Id: Iaf021010188e3c3662fbf8a057da4c58f2600c02 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 130 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf021010188e3c3662fbf8a057da4c58f2600c02 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: update VDSM deps configuration

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: update VDSM deps configuration ...................................................................... packaging: setup: update VDSM deps configuration Updated VDSM deps configuration using the new VDSM command line tool. Requires: http://gerrit.ovirt.org/20100 Change-Id: I735111e33dd7435067854ec7694b137f4bc62da2 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py 2 files changed, 19 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I735111e33dd7435067854ec7694b137f4bc62da2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-reports[master]: packaging: setup: update psql version detection

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: update psql version detection ...................................................................... packaging: setup: update psql version detection Change-Id: I17c11b9a99a3f2d56e9a27596bc822663bf2380d Bug-Url: https://bugzilla.redhat.com/1026765 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 9 insertions(+), 20 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17c11b9a99a3f2d56e9a27596bc822663bf2380d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Changed by reference check to by value (findbugs)

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Changed by reference check to by value (findbugs) ...................................................................... webadmin: Changed by reference check to by value (findbugs) When setting a model's change prohibition reason, the check whether the value is different than the preceding value, in order to see if an event has to be raised, was being done by reference rather than by value. It doesn't really matter because all strings passed to the method are constants, but the norm with triggering value change events is to check by value. Change-Id: Ibca529d23718dfaa5bf120d0bc157c259f016911 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibca529d23718dfaa5bf120d0bc157c259f016911 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: userportal: error flow of RDP RdpPluginImpl broken

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: userportal: error flow of RDP RdpPluginImpl broken ...................................................................... userportal: error flow of RDP RdpPluginImpl broken There were the following issues which caused the error not to be propagated: - a regression caused by 625b7452d840793df5e72764193c98c5ba121cdf which did bring back the crashing of IE if the RDP connection is not successful (originally fixed by fa10641c3484ea10d0b1b33ef8e3d656b5e6dd35). - by the same commit (625b7452d840793df5e72764193c98c5ba121cdf) the new method setParentModel has been introduced but it was not called. It caused a NPE on RdpPluginImpl.rdpDisconnected:66. Fixed by calling this method on the relevant places. This patch differs from the 34d4bbcbe8f01297b8770bf69b445b08dcf1b1f7 from which is this backported in a way that the AbstractRdp.getUserPassword already handles the null correctly in this branch (e.g. no change required in this class). Change-Id: I85fc3b32c4f544f23864db2aefa5ebcd4d896b75 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014710 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpPluginImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java 3 files changed, 5 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85fc3b32c4f544f23864db2aefa5ebcd4d896b75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: utils: remove servlet interaction from PKIResources

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: utils: remove servlet interaction from PKIResources ...................................................................... utils: remove servlet interaction from PKIResources got some notes that better to move the code upward into the servlets, there was an option to add this to ServletUtils but it is way to specific to do so. so moving this into servlet and the upcoming registration servlet will use the same method. Change-Id: I7b8f18444afd9be981f195e153fd9328d9fc376c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 2 files changed, 4 insertions(+), 21 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b8f18444afd9be981f195e153fd9328d9fc376c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: services: pki-resources: cleanup: use servlet init() instead...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: services: pki-resources: cleanup: use servlet init() instead of init(config) ...................................................................... services: pki-resources: cleanup: use servlet init() instead of init(config) Change-Id: I1da2e42577eba20e065ad7d5964d2e95ba0fab21 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1da2e42577eba20e065ad7d5964d2e95ba0fab21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: servies: pki-resources: reduce warning of missing serialization

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: servies: pki-resources: reduce warning of missing serialization ...................................................................... servies: pki-resources: reduce warning of missing serialization Change-Id: I1b54b03be992057d36f6754b79dd0e1b92426711 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b54b03be992057d36f6754b79dd0e1b92426711 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2013