December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: Fix --vm-status when maintenance mode has never been enabled
by sbonazzo＠redhat.com 13 Dec '13

13 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix --vm-status when maintenance mode has never been enabled ...................................................................... Fix --vm-status when maintenance mode has never been enabled Change-Id: I2b1a4f91e826a95d22a4e8b93a044aec2baf9003 Bug-Url: https://bugzilla.redhat.com/1041203 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vm_status.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b1a4f91e826a95d22a4e8b93a044aec2baf9003 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.3.2]: build: ovirt-log-collector-3.3.2-2
by sbonazzo＠redhat.com 13 Dec '13

13 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-log-collector-3.3.2-2 ...................................................................... build: ovirt-log-collector-3.3.2-2 Change-Id: I5774b25b596b25ccaf170a24360d6ef72ec904ea Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-log-collector.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5774b25b596b25ccaf170a24360d6ef72ec904ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.3.2]: sos: postgresql: always use db host
by sbonazzo＠redhat.com 13 Dec '13

13 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: postgresql: always use db host ...................................................................... sos: postgresql: always use db host Previously it was possible to access the database through unix socket. Now the access for user engine is limited to tcp connection. Changed the call to sosreport for passing db host to postgresql plugin. Change-Id: Ibb4ac5e03e3b6f1f6d7b499c969bdeb5ed9026cb Bug-Url: https://bugzilla.redhat.com/1039747 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 10 insertions(+), 38 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb4ac5e03e3b6f1f6d7b499c969bdeb5ed9026cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3.2]: packaging: ovirt-engine-3.3.2
by iheim＠redhat.com 12 Dec '13

12 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.3.2 ...................................................................... packaging: ovirt-engine-3.3.2 Change-Id: Id7e8498834ac3b558286e815d7ae9cde768fd633 Bug-Url: https://bugzilla.redhat.com/1027349 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M version.mak 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7e8498834ac3b558286e815d7ae9cde768fd633 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: handle cpu load duration
by iheim＠redhat.com 12 Dec '13

12 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: scheduling: handle cpu load duration ...................................................................... core: scheduling: handle cpu load duration Move the logic into SchedulerManager. Change-Id: I231aa54ccc0cadbd9456b090fe08ae85dd926957 Bug-Url: https://bugzilla.redhat.com/1031353 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 7 files changed, 44 insertions(+), 74 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/22350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I231aa54ccc0cadbd9456b090fe08ae85dd926957 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: [Fix] PCI limit in add VM template NIC
by masayag＠redhat.com 12 Dec '13

12 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: core: [Fix] PCI limit in add VM template NIC ...................................................................... core: [Fix] PCI limit in add VM template NIC The AddVmTemplateInterfaceCommand didn't account for all the existing NICs while passing the "interfaces" list to the checkPciAndIdeLimits procedure, so a limitless number of NICs could be created. This change fix this behaviour. Change-Id: I7e9ead27a7a3fe73093160b06d37159e8b6c3099 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e9ead27a7a3fe73093160b06d37159e8b6c3099 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add new event notifiers
by emesika＠redhat.com 12 Dec '13

12 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: engine: Add new event notifiers ...................................................................... engine: Add new event notifiers Add notification support for the following existing event types: - AuditLogType.VM_DOWN_ERROR - AuditLogType.VDS_INITIATED_RUN_VM_FAILED Since both of these events relate specifically to problems running a VM, place them in the EventNotificationEntity.Vm category. Signed-off-by: Adam Litke <alitke(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009005 Change-Id: Ib1ad9508893adb11b745b86747bf368115eaaea2 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties A packaging/dbscripts/upgrade/03_04_0230_vm_down_error_and_vds_initiated_run_fail_event_map.sql 4 files changed, 10 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1ad9508893adb11b745b86747bf368115eaaea2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Eylon <yaniv.eylon(a)gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Vms - Vms:Hosts autocomplete is incorrect
by emesika＠redhat.com 12 Dec '13

12 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: webadmin: Vms - Vms:Hosts autocomplete is incorrect ...................................................................... webadmin: Vms - Vms:Hosts autocomplete is incorrect In Vms tab the search autocompletion displays Vms:Hosts the right completion should be Vms:Host Change-Id: I9d3403dc91462cd9c1ad788c3bd763efb59638aa Bug-Url: https://bugzilla.redhat.com/1005787 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmCrossRefAutoCompleter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d3403dc91462cd9c1ad788c3bd763efb59638aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: allow current master domain to be selected as the new ...
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: allow current master domain to be selected as the new master ...................................................................... core: allow current master domain to be selected as the new master Currently the current master domain cannot be selected as the new master, which can cause to the system to not be able to recover in case that it's the only available domain. This patch allows to perform reconstruct using the master domain in case that we know that it's accessible - 1. Getting WrongMasterDomain error from vdsm means that we could get to the master domain metadata. NOTE: in that case, the reconstruct command will be executed with parameter indicating that the current master can be selected as the new master - but the host that return the WrongMasterDomain error or the master domain id as the master domain id as the id of the domain to reconstruct to aren't being passed to the command - this is being done to avoid possible issues (for example: failing to reconstruct to that domain although we can read the metadata, keep trying through the same host..etc). The intention here is to improve the current situation for most of the usecases. 2. When the master domain info in the db is different then the info received from getStoragePoolInfo. Change-Id: I705298d4f94b4afacc3ca028bb0a4e6080ac5a46 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1016118 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 7 files changed, 73 insertions(+), 40 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I705298d4f94b4afacc3ca028bb0a4e6080ac5a46 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unneeded disconnect when reconstructing
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unneeded disconnect when reconstructing ...................................................................... core: rm unneeded disconnect when reconstructing When performing reconstruct in the case that the old master status isn't changed to inactive there is a call to disconnect from it. This operation is wrong, there is no need to disconnect from the current master which can only cause issues. Change-Id: Ic3a0a3014d19ae78ddb47ef1a8ad4aa950539a9c Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1016118 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3a0a3014d19ae78ddb47ef1a8ad4aa950539a9c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0