Change in ovirt-engine[master]: core: remove unused methods
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: remove unused methods
......................................................................
core: remove unused methods
Remove unused methods in RunVmCommand
Change-Id: Iabe99ebc6ce6cca069f9333ac3d0b4117f3dfd3b
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22071
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabe99ebc6ce6cca069f9333ac3d0b4117f3dfd3b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core, webadmin: Show only supported watchdogs
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core, webadmin: Show only supported watchdogs
......................................................................
core, webadmin: Show only supported watchdogs
This change displays only supported watchdogs compatible with the
selected operating system.
Change-Id: Ib23f7357751025ff71c0deceda02aa51c2d8542c
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/OsQueryParameters.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M packaging/conf/osinfo-defaults.properties
8 files changed, 101 insertions(+), 6 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib23f7357751025ff71c0deceda02aa51c2d8542c
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: adding remote console related events
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: adding remote console related events
......................................................................
core: adding remote console related events
When users connect to the console, no event notification is available to
specify that it happened.
This patch adds two events:
1. SetVmTicket event - when the user initiated the session
2. ClientIp changed event - when the user connects (this event requires
having a guest agent installed on the guest)
Change-Id: Id345f413f83d82ef3a14fa35c1be7b65699d3298
Bug-Url: https://bugzilla.redhat.com/1039862
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
A packaging/dbscripts/upgrade/03_04_0220_add_console_events.sql
8 files changed, 30 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22223
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id345f413f83d82ef3a14fa35c1be7b65699d3298
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: packaging: api: redirect /api to /ovirt-engine/api by duplic...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: packaging: api: redirect /api to /ovirt-engine/api by duplicating war installation
......................................................................
packaging: api: redirect /api to /ovirt-engine/api by duplicating war installation
Using forward servlet is not a complete solution as there is some
limitation of sharing context.
So java based solution is not easily possible.
Jboss rewrite rules cannot be used as it ignores the matrix ';' suffix.
Using apache has side effect is a redirect between /api and /api/ as apache
must normalize the directory due to internal limitation.
We end up installing war twice one per context.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031597
Change-Id: I021c98bb6b5dcd0812db2b130967ebea27fad4e9
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
M ear/pom.xml
M ovirt-engine.spec.in
M packaging/conf/ovirt-engine-proxy.conf.v2.in
M packaging/setup/plugins/ovirt-engine-setup/apache/ovirt_engine.py
6 files changed, 10 insertions(+), 24 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I021c98bb6b5dcd0812db2b130967ebea27fad4e9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: tools: Fixing edit action of manage-domains
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: Fixing edit action of manage-domains
......................................................................
tools: Fixing edit action of manage-domains
Bug-Url: https://bugzilla.redhat.com/1037894
The following patches fixes the edit action of
manage-domains tool to support edit of values provided
by the "ldapServers" argument.
Prior to this fix, the change was not stored at the
proper location at the vdc_options table.
Bare in mind that if -ldapServers is not provided during
the edit action no change will be made to the entry.
Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosConfigCheck.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
2 files changed, 29 insertions(+), 17 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Yair Zaslavsky: Verified
Objections:
Yair Zaslavsky: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/22314
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: Fixing PM options caching
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fixing PM options caching
......................................................................
core: Fixing PM options caching
fencingOptionMapping cache map was declared as static
as a result if it was initialized once with the 'general' version
the values of this version was used for all instances no matter which
version is given to the constructor.
This eliminates new agents added in later versions to function and
display supported port/slot/secure fields correctly
Change-Id: I03e4a98919105bbb0d7ef382234b8810db044215
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020344
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03e4a98919105bbb0d7ef382234b8810db044215
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: webadmin: Dashboard results an error, when reports is not de...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: webadmin: Dashboard results an error, when reports is not deployed
......................................................................
webadmin: Dashboard results an error, when reports is not deployed
Reports tab shows error page when accessed after a server restart
before the reports web app has been deployed
A new Status servlet has been added to Reports app which is
used by the webadmin to check the deployment status of report
webapp before showing reports in reports tab
Change-Id: Ib6f63fe75110a6f799d355e78ed1fc0af2bd7d06
Bug-Url: https://bugzilla.redhat.com/1037667
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java
2 files changed, 77 insertions(+), 6 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6f63fe75110a6f799d355e78ed1fc0af2bd7d06
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: remove host if it is already detached in gluster
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: remove host if it is already detached in gluster
......................................................................
engine: remove host if it is already detached in gluster
Handle the error returned from VDSM while removing a host. If
the host is already detached from Gluster through Gluster CLI then
remove the host from engine .
Change-Id: Ib83bffebe99ef5553ffcb2ce8ef03d4bba4c12b3
Bug-Url:i https://bugzilla.redhat.com/1024183
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
6 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit http://gerrit.ovirt.org/22240
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib83bffebe99ef5553ffcb2ce8ef03d4bba4c12b3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: Fix potential NumberFormatException in OsRepositoryImpl
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: engine: Fix potential NumberFormatException in OsRepositoryImpl
......................................................................
engine: Fix potential NumberFormatException in OsRepositoryImpl
Added NumberFormatException check in getInt method
to guard against bad number format.
Change-Id: I3ec4c9704d35b7f2955ed41761d4f019969897c1
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17117
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ec4c9704d35b7f2955ed41761d4f019969897c1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: packaging: setup: Clean up treatment of /etc/exports
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Clean up treatment of /etc/exports
......................................................................
packaging: setup: Clean up treatment of /etc/exports
Without this change, /etc/exports:
- gets overwritten on setup if there is no /etc/exports.d
- is added empty lines when edited by setup
- is not restored to previous content on cleanup
With this change:
- If there is /etc/exports.d:
-- Setup writes there a file with the iso domain path, which is removed
on cleanup (if not changed since setup)
-- Setup removes this path from /etc/exports if it's there (supposedly
added by a previous legacy Setup), and this change is not reverted on
cleanup
- If there is only /etc/exports:
-- Setup adds to it the path if it's not there already
-- Cleanup reverts this change if the line was not changed since setup
Bug-Url: https://bugzilla.redhat.com/1035511
Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py
1 file changed, 80 insertions(+), 45 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years