Change in ovirt-engine[master]: core: Architecture related checks for VMs and templates
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Architecture related checks for VMs and templates
......................................................................
core: Architecture related checks for VMs and templates
This change introduces architecture related checks during the creation
and modification of VMs, Templates and Pools. These checks include:
* Verifies if the selected template has the same architecture of the
selected cluster when adding VMs and pools;
* Verifies if the selected cluster has a undefined architecture when
updating and adding VMs, templates and pools;
* Does not allow VMs to change their clusters if the destination cluster
has a different architecture.
Change-Id: Ia877dd2d13525de6693883e43d0ca786f77f9310
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
13 files changed, 88 insertions(+), 0 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia877dd2d13525de6693883e43d0ca786f77f9310
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: CDA to block disk alignment scan on file SDs
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: CDA to block disk alignment scan on file SDs
......................................................................
core: CDA to block disk alignment scan on file SDs
The current implementation of disk alignment scanning is useless for
file domains, and fails on NFS storage in particular.
This patch blocks such operations by a canDoAction(), to prevent any
useless calls to VDSM.
Change-Id: Ib7a9505ac16c9dd3cf14b584b8ec7e7292d68e98
Bug-Url: https://bugzilla.redhat.com/1046031
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 23 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7a9505ac16c9dd3cf14b584b8ec7e7292d68e98
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: disable scan alignment for non-block SDs
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: disable scan alignment for non-block SDs
......................................................................
webadmin: disable scan alignment for non-block SDs
VMs -> Disks sub-tab:
disable scan alignment action for non-block storage domains
(as it's applicable only for block domains).
Disks main-tab:
scan alignment will be blocked on canDoAction in a separate patch.
Change-Id: I2f4150f72332fb071a90001e63858a5212a0db0a
Bug-Url: https://bugzilla.redhat.com/1046031
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f4150f72332fb071a90001e63858a5212a0db0a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: tools: Notifier code cleanup
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: tools: Notifier code cleanup
......................................................................
tools: Notifier code cleanup
Removes unused attribute log in NotificationProperties.
Removes unused attribute pidFile in EngineMonitorService.
Removes unnecessary @SuppressWarning in Notifier.
Reformats code in Notifier.
Change-Id: I0ddf6dbb01baa0e3fd1a8349f26aead0cd6a5fde
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
3 files changed, 5 insertions(+), 13 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ddf6dbb01baa0e3fd1a8349f26aead0cd6a5fde
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: ux: rephrase confirm installation dialog
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ux: rephrase confirm installation dialog
......................................................................
ux: rephrase confirm installation dialog
Change-Id: Iee730d02e3b3b69cfc7ec3455cc07a1cde546089
Bug-Url: https://bugzilla.redhat.com/1046145
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/core/misc.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee730d02e3b3b69cfc7ec3455cc07a1cde546089
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: ux: rephrase screen usage text
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ux: rephrase screen usage text
......................................................................
ux: rephrase screen usage text
Change-Id: I9d281d803d0c083d0835ad7ebdc88c10dc8e81a7
Bug-Url: https://bugzilla.redhat.com/1046146
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/core/shell.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d281d803d0c083d0835ad7ebdc88c10dc8e81a7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core+webadmin: reordering VM NICs
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core+webadmin: reordering VM NICs
......................................................................
core+webadmin: reordering VM NICs
This patch adds a reordering functionality to the VM interfaces.
The logic is as follows:
1. All templated NICs that have a PCI address are left as is.
2. All the remaining NICs are given MAC addresses with the same NIC name
ordering.
Change-Id: I7d02e3eff9466d9094bc16cd489503d25c9f4bef
Bug-Url: https://bugzilla.redhat.com/1040630
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ReorderVmNicsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallback.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceCreatingManager.java
6 files changed, 139 insertions(+), 18 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d02e3eff9466d9094bc16cd489503d25c9f4bef
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: handle nic ordering when adding or importing a VM
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: handle nic ordering when adding or importing a VM
......................................................................
core: handle nic ordering when adding or importing a VM
This patch handles the NIC ordering when creating or importing a VM, as follows:
1. When creating a VM from template
a. If the template has PCI addresses, then sort the NICs according
to that, allocating MAC addresses with the same ordering
b. If the template doesn't contain PCI addresses, allocate MAC
addresses with an ordering identical to the naming of the NICs
2. When creating a VM from snapshot
a. Follow logic in 1a.
b. If the snapshot doesn't contain PCI addresses, but it does contain
the MAC addresses, allocate new MAC addresses with the same ordering as
in the original snapshot
c. If no PCI and no MAC addresses are available, order by the NIC name
3. When importing a VM - same as VM creation (but no template in this
case, just the exported VM is the reference to compare to).
Change-Id: I46b4ffc4ecaab824b90bf8b8ecdfe4ebad3074bf
Bug-Url: https://bugzilla.redhat.com/1040630
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java
6 files changed, 117 insertions(+), 29 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46b4ffc4ecaab824b90bf8b8ecdfe4ebad3074bf
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.0]: agent: use certificate common name to identify host
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: agent: use certificate common name to identify host
......................................................................
agent: use certificate common name to identify host
The name the host calls itself in the global metadata must match the
libvirt certificate's Common Name, else migrations will fail. Use this
name when available, and fall back to the hostname in other cases.
Change-Id: Ie9de4537685b11f8ecbe55b3c1b6845654f59311
Bug-Url: https://bugzilla.redhat.com/1039614
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/hosted_engine.py
2 files changed, 35 insertions(+), 1 deletion(-)
Approvals:
Greg Padgett: Verified
Doron Fediuck: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9de4537685b11f8ecbe55b3c1b6845654f59311
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.0
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: ux: provide default gw for pingable address.
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ux: provide default gw for pingable address.
......................................................................
ux: provide default gw for pingable address.
Change-Id: Id73ecc9d929e0afe9c62773975c9564b35c38da7
Bug-Url: https://bugzilla.redhat.com/1046147
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/network/gateway.py
1 file changed, 23 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/22678
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id73ecc9d929e0afe9c62773975c9564b35c38da7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months