Change in ovirt-engine[master]: core: Fix typo in VmDevice
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix typo in VmDevice
......................................................................
core: Fix typo in VmDevice
Change-Id: I19de1f4e391aa7bab33c299170fe7a5a4e35c52c
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19de1f4e391aa7bab33c299170fe7a5a4e35c52c
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: Change DeactivateStorageDomain CDA to use failCanDoAction
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Change DeactivateStorageDomain CDA to use failCanDoAction
......................................................................
core: Change DeactivateStorageDomain CDA to use failCanDoAction
Changing all the return false in the CDA to use one line of
failCanDoAction
Change-Id: I9caac7939290b1429e67d4ef3a041ea29a8766ef
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
1 file changed, 5 insertions(+), 10 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22639
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9caac7939290b1429e67d4ef3a041ea29a8766ef
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: Add label column to network
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add label column to network
......................................................................
engine: Add label column to network
Extending the network table to persist the label
entity so it can managed as part of the network
entity.
Change-Id: I4e3c309cef92e63ebe6f1f48f19f8848e9bceb70
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/03_04_0300_add_label_column_to_networks.sql
7 files changed, 62 insertions(+), 8 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22634
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e3c309cef92e63ebe6f1f48f19f8848e9bceb70
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: Findbugs exclussions in JBoss modules plugin
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Findbugs exclussions in JBoss modules plugin
......................................................................
core: Findbugs exclussions in JBoss modules plugin
The code generated by Maven for the JBoss modules plugin contains a
class that has an minor issue pointed out by findbugs. These issue has
already been reported to the maven developers:
http://jira.codehaus.org/browse/MPLUGIN-255
While this is solved in Maven we are adding a findbugs configuration to
ignore it. This configuration is the same used in all the rest of the
engine modules, the only difference is the exclussions list.
Change-Id: I76106b935e0e987db04d99e36f89adc536754021
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A build-tools-root/jboss-modules-maven-plugin/exclude-filters.xml
M build-tools-root/jboss-modules-maven-plugin/pom.xml
2 files changed, 52 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22659
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76106b935e0e987db04d99e36f89adc536754021
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: Move setupNetworkSupported to NetworkHelper
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Move setupNetworkSupported to NetworkHelper
......................................................................
engine: Move setupNetworkSupported to NetworkHelper
The method is moved to a static class so it can be reused
from various network commands.
Change-Id: Ice92f998275a7f206c0c349519a86c22b6c53163
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
2 files changed, 10 insertions(+), 7 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice92f998275a7f206c0c349519a86c22b6c53163
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: Clear eclipse warnings
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Clear eclipse warnings
......................................................................
engine: Clear eclipse warnings
Change-Id: Ib12a2c115231503940fd4d6914877976712fa987
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoDbFacadeImpl.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22633
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib12a2c115231503940fd4d6914877976712fa987
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: ui: rename members to start with lowercase in NotifyCollecti...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: ui: rename members to start with lowercase in NotifyCollectionChangedEventsArgs
......................................................................
ui: rename members to start with lowercase in
NotifyCollectionChangedEventsArgs
Change-Id: I6d7fb60760548e661cc3b1b512313513c17783d4
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/NotifyCollectionChangedEventArgs.java
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d7fb60760548e661cc3b1b512313513c17783d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: removed volume rebalance actions
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: removed volume rebalance actions
......................................................................
webadmin: removed volume rebalance actions
Gluster Volume Rebalance feature is not fully implemented
in ovirt-engine-3.3. Removing the actions for now
Change-Id: I0768d48f432235f405e9a6d8fee36794e2a72628
Bug-Url: https://bugzilla.redhat.com/1046000
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
1 file changed, 0 insertions(+), 28 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22680
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0768d48f432235f405e9a6d8fee36794e2a72628
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: disable scan alignment for non-block SDs
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: disable scan alignment for non-block SDs
......................................................................
webadmin: disable scan alignment for non-block SDs
VMs -> Disks sub-tab:
disable scan alignment action for non-block storage domains
(as it's applicable only for block domains).
Disks main-tab:
scan alignment will be blocked on canDoAction in a separate patch.
Change-Id: I2f4150f72332fb071a90001e63858a5212a0db0a
Bug-Url: https://bugzilla.redhat.com/1046031
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f4150f72332fb071a90001e63858a5212a0db0a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: core: CDA to block disk alignment scan on file SDs
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: CDA to block disk alignment scan on file SDs
......................................................................
core: CDA to block disk alignment scan on file SDs
The current implementation of disk alignment scanning is useless for
file domains, and fails on NFS storage in particular.
This patch blocks such operations by a canDoAction(), to prevent any
useless calls to VDSM.
Change-Id: Ib7a9505ac16c9dd3cf14b584b8ec7e7292d68e98
Bug-Url: https://bugzilla.redhat.com/1046031
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 23 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7a9505ac16c9dd3cf14b584b8ec7e7292d68e98
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years