December 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Validate network label format

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Validate network label format ...................................................................... core: Validate network label format The network label will be limited to the following format: [0-9a-zA-Z_-]+ Change-Id: Id645a96af80ef5de4d6239de64faba04026c8cd2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 9 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id645a96af80ef5de4d6239de64faba04026c8cd2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: resolve findbugs warning in HumanReadableTimeRende...

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: resolve findbugs warning in HumanReadableTimeRenderer. ...................................................................... webadmin: resolve findbugs warning in HumanReadableTimeRenderer. Resolve warning of type BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION Change-Id: Ia14f49fd458f3384ba4829d2e4fc4301ad6de4ee Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/HumanReadableTimeRenderer.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia14f49fd458f3384ba4829d2e4fc4301ad6de4ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-dwh[master]: build: reintroduce routines jars as it is used by the advanc...

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: build: reintroduce routines jars as it is used by the advancedPersistentLookupLib ...................................................................... build: reintroduce routines jars as it is used by the advancedPersistentLookupLib Change-Id: I949c9753e42c65ee73840c6c9d3cee7cea43ce65 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M Makefile M ovirt-engine-dwh.spec.in M ovirt-engine-dwh/advancedPersistentLookupLib/pom.xml M ovirt-engine-dwh/dependencies/pom.xml M ovirt-engine-dwh/dependencies/src/main/modules/org/ovirt/engine/dwh/main/module.xml M ovirt-engine-dwh/pom.xml A ovirt-engine-dwh/routines/pom.xml R ovirt-engine-dwh/routines/src/main/java/routines 8 files changed, 63 insertions(+), 5 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I949c9753e42c65ee73840c6c9d3cee7cea43ce65 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

11 years

1
0
0 / 0

Change in jasperreports-server-rpm[master]: packaging: fixed spec file for JRS 5.5.0

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed spec file for JRS 5.5.0 ...................................................................... packaging: fixed spec file for JRS 5.5.0 Change-Id: Ia2fb32ef21b41b87401d71c70d98ae3d8ce20b62 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jasperreports-server.spec 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2fb32ef21b41b87401d71c70d98ae3d8ce20b62 Gerrit-PatchSet: 3 Gerrit-Project: jasperreports-server-rpm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

11 years

1
0
0 / 0

Change in ovirt-engine[master]: engine: Extract base class NetworkParametersBuilder

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract base class NetworkParametersBuilder ...................................................................... engine: Extract base class NetworkParametersBuilder The class will serve as a base class for setupNetworks parameters builders in the various scenarios: sync networks, adding networks or removing a network. Change-Id: I936cc52bf2c0badf0289e1afbd4af1c1617aa6b2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 2 files changed, 26 insertions(+), 16 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I936cc52bf2c0badf0289e1afbd4af1c1617aa6b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[master]: engine: Refactor InterfaceDaoDbFacadeImpl

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Refactor InterfaceDaoDbFacadeImpl ...................................................................... engine: Refactor InterfaceDaoDbFacadeImpl Reduced amount of duplicated code, cleared eclipse warnings and mostly shortening this class. There is still way to go: changing this class to inherit from DefaultGenericDaoDbFacade. Change-Id: I4a46cf2ea27c163ab5ed4fd7c03be37314d9e354 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java 1 file changed, 38 insertions(+), 88 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a46cf2ea27c163ab5ed4fd7c03be37314d9e354 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[master]: engine: Add labels to host interface

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add labels to host interface ...................................................................... engine: Add labels to host interface Adding the labels property to the host nic entity to manage the networks to be attach to the nic by that label. Change-Id: I6552eb2b8414c7cff77407872ae72bd0ae72f8c2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/03_04_0310_add_labels_column_to_vds_interfaces.sql 6 files changed, 41 insertions(+), 11 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6552eb2b8414c7cff77407872ae72bd0ae72f8c2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-log-collector[master]: config: added backward compatibilty

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: added backward compatibilty ...................................................................... config: added backward compatibilty Added backward compatibility supporting upgrade from 3.1 version which used the keyword engine-ca instead of cert-file. Change-Id: I43befe3fa63e1fb5c624fd528399e867c2b5e882 Bug-Url: https://bugzilla.redhat.com/1046309 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43befe3fa63e1fb5c624fd528399e867c2b5e882 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-image-uploader[master]: config: added backward compatibilty

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: added backward compatibilty ...................................................................... config: added backward compatibilty Added backward compatibility supporting upgrade from 3.1 version which used the keyword engine-ca instead of cert-file. Change-Id: Ie4b06eea10a31b675fac0cae98465988dd66894d Bug-Url: https://bugzilla.redhat.com/1046303 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4b06eea10a31b675fac0cae98465988dd66894d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

11 years

1
0
0 / 0

Change in ovirt-iso-uploader[master]: config: added backward compatibilty

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: added backward compatibilty ...................................................................... config: added backward compatibilty Added backward compatibility supporting upgrade from 3.1 version which used the keyword engine-ca instead of cert-file. Change-Id: Ibdfae742e8dfea58eb19b61987e347003b69b57b Bug-Url: https://bugzilla.redhat.com/1032689 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdfae742e8dfea58eb19b61987e347003b69b57b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2013