Change in ovirt-engine[engine_3.2]: engineencryptutils: cleanup
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: engineencryptutils: cleanup
......................................................................
engineencryptutils: cleanup
Remove dead code.
Remove redundant variables.
Rework to reach somewhat similar structure between functions.
Remove the use of StringHelper.
Not that the result is good... but at least something in the right way.
Change-Id: I9c1004e42ee92347cbf97011e3216a1ac5c23173
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/engineencryptutils/pom.xml
M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java
2 files changed, 20 insertions(+), 114 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11532
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1004e42ee92347cbf97011e3216a1ac5c23173
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[engine_3.2]: compat: remove unsafe and unneeded Encoding class
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: compat: remove unsafe and unneeded Encoding class
......................................................................
compat: remove unsafe and unneeded Encoding class
Left over from legacy code.
Base64 usage is thread unsafe.
String usage is not required.
Change-Id: Ie7a540d9c69b55ce8431839c1164927024161d30
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/compat/pom.xml
D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Encoding.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlDocument.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java
D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/EncodingTest.java
M backend/manager/modules/engineencryptutils/pom.xml
M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Ticketing.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
10 files changed, 24 insertions(+), 112 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7a540d9c69b55ce8431839c1164927024161d30
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: api: Current:currents needs to be static to avoid deadly emb...
by asaf＠redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: api: Current:currents needs to be static to avoid deadly embrace.
......................................................................
api: Current:currents needs to be static to avoid deadly embrace.
Discovered by findbugs:
org.ovirt.engine.api.common.invocation.Current$1 needs
to be _static_ to avoid a deadly embrace
with org.ovirt.engine.api.common.invocation.Current.currentsFirst.
By definition: ThreadLocal instances are typically private static
fields in classes that wish to associate state with a thread.
Change-Id: I86516044e758aa526f7bab570d41567b35176029
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86516044e758aa526f7bab570d41567b35176029
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[engine_3.2]: packaging: use APP_NAME in /etc/exports comments
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: use APP_NAME in /etc/exports comments
......................................................................
packaging: use APP_NAME in /etc/exports comments
when configuring /etc/exports use APP_NAME instead of the
hardcoded value "rhev installer".
Change-Id: Ie7c343408d586f756251247da51a3412a5a9afdd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904149#c3
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 20775e7818f6e036f014b7e3f1ffbdaa801d9815)
---
M packaging/fedora/setup/engine-setup.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7c343408d586f756251247da51a3412a5a9afdd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[engine_3.2]: packaging: suggest path for local storage during AIO setup
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: suggest path for local storage during AIO setup
......................................................................
packaging: suggest path for local storage during AIO setup
When running AIO setup, the installer suggest a default location
(/var/lib/images) for the Local storage domain path the same way
we suggest for the local ISO domain.
Renamed generateIsoDomainName in generateIsoDomainPath in
engine-setup to be more accurate.
Bug-Url: https://bugzilla.redhat.com/896465
Change-Id: I9ddc2810ab3a6c2c20ce8b7663a813e89312f4d1
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit b1e0cf6614cc67d4832cf41e90e3f7898b78fd06)
---
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/plugins/all_in_one_100.py
2 files changed, 16 insertions(+), 5 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11705
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ddc2810ab3a6c2c20ce8b7663a813e89312f4d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 4 months
Change in ovirt-dwh[master]: etl: fixed error events reporting in jobs (#902028)
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: fixed error events reporting in jobs (#902028)
......................................................................
etl: fixed error events reporting in jobs (#902028)
BugUrl: https://bugzilla.redhat.com/902028
Change-Id: Ic050e6fc8b65fc76ddd6b4c7d2c7c995d03e967a
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/dailytimekeepingjob_3_2/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/deletetimekeepingjob_3_2/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/hourlytimekeepingjob_3_2/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/parallelrun_3_2/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/sampletimekeepingjob_3_2/contexts/Default.properties
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/dailytimekeepingjob_3_2/DailyTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/deletetimekeepingjob_3_2/DeleteTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/historyetl_3_2/HistoryETL.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/hourlytimekeepingjob_3_2/HourlyTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/parallelrun_3_2/ParallelRun.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_3_2/SampleTimeKeepingJob.java
A data-warehouse/history_etl/tos_project/configuration/ExpressionBuilder/SampleTimeKeepingJob.xml
M data-warehouse/history_etl/tos_project/context/connectionJDBC_3.2.item
M data-warehouse/history_etl/tos_project/context/connectionJDBC_3.2.properties
M data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.2.item
M data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.2.properties
M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.2.item
M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.2.properties
M data-warehouse/history_etl/tos_project/process/HistoryETL_3.2.item
M data-warehouse/history_etl/tos_project/process/HistoryETL_3.2.properties
M data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.2.item
M data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.2.properties
M data-warehouse/history_etl/tos_project/process/ParallelRun_3.2.item
M data-warehouse/history_etl/tos_project/process/ParallelRun_3.2.properties
M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.2.item
M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.2.properties
26 files changed, 10,775 insertions(+), 2,816 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic050e6fc8b65fc76ddd6b4c7d2c7c995d03e967a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: core: GetAllDisksBySD - fetch disks snapshots
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: GetAllDisksBySD - fetch disks snapshots
......................................................................
core: GetAllDisksBySD - fetch disks snapshots
* GetAllDisksByStorageDomainIdQuery:
fetch disks' snapshots for calculating the actual size
(DiskImage -> getActualDiskWithSnapshotsSize).
* Remove redundant GetImagesByStorageId SP.
Change-Id: I055e317ea21a9eabea126e9ca17af61db659cd10
Bug-Url: https://bugzilla.redhat.com/905595
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/dbscripts/disk_images_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java
5 files changed, 31 insertions(+), 41 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11640
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I055e317ea21a9eabea126e9ca17af61db659cd10
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: userportal: refactor in UserPortalListModel & BootSequenceMo...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: refactor in UserPortalListModel & BootSequenceModel
......................................................................
userportal: refactor in UserPortalListModel & BootSequenceModel
- extract the code that set the boot from network option for a given vm
from UserPortalListModel#RunOnce to a new private method to make it a
little bit shorter
- extract the common code in BootSequenceModel#getHardDiskOption,
BootSequenceModel#getNetworkOption, BootSequenceModel#getCdromOption
to a new private method to reduce the code duplication
Change-Id: I841bedf241e82f6f89e88a66d6cd4e4ea681102f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
2 files changed, 21 insertions(+), 30 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11736
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I841bedf241e82f6f89e88a66d6cd4e4ea681102f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: userportal: no boot from hard disk for diskless VM
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: no boot from hard disk for diskless VM
......................................................................
userportal: no boot from hard disk for diskless VM
This patch disable the boot from hard disk option, presented in Run Once
dialog, for VM that doesn't have bootable disk
Change-Id: Ie2752fb8308731c1e922600a81e410a374b0ba38
Bug-Url: https://bugzilla.redhat.com/885994
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
4 files changed, 97 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11735
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2752fb8308731c1e922600a81e410a374b0ba38
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: core: replace negative with positive check in RunVmCommand
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: replace negative with positive check in RunVmCommand
......................................................................
core: replace negative with positive check in RunVmCommand
Minor refactoring in RunVmCommand changing negative check with positive
one in a ternary structure - making it more readable
Change-Id: I6588f22bf6a5f8e2bc2dcd5a01f147f8c6a09c99
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11793
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6588f22bf6a5f8e2bc2dcd5a01f147f8c6a09c99
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
11 years, 4 months