February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Removed unnecessary calls to StringFormat & StringHelp...
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed unnecessary calls to StringFormat & StringHelper ...................................................................... core: Removed unnecessary calls to StringFormat & StringHelper Replaced calls to StringFormat.format to String.format where possible (i.e. not code that compiles to GWT) and to simple String concatenation where possible. Also replaced calls to StringHelper.EqOp calls in String.equals calls in cases that at least one of the args was not null. Added @Override annotation to methods in the edited classes where needed Change-Id: I57dc0d9d30f9e5cd4f0beacc8bfd35fe5023afc1 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringFormat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeSpan.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java 8 files changed, 48 insertions(+), 55 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57dc0d9d30f9e5cd4f0beacc8bfd35fe5023afc1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: updated user prompts for stopping ovirt-engine se...
by oschreib＠redhat.com 05 Feb '13

05 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: updated user prompts for stopping ovirt-engine service during setup ...................................................................... packaging: updated user prompts for stopping ovirt-engine service during setup * If the engine service is in state not running, and only in this state, avoid to ask for stopping the service. The script doesn't check for service up and running, avoiding a regression on RHBZ #837812. * Avoid to stop the engine service if already stopped and not configured. Change-Id: I01da6e908a9f396bf4211afe863475d9fc2093be Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=896694 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit b1da51482448ddabaa9b9f5c27c06188266d4e4a) --- M packaging/fedora/setup/engine-setup.py 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified Alex Lourie: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01da6e908a9f396bf4211afe863475d9fc2093be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed MatchCollection class
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed MatchCollection class ...................................................................... core: Removed MatchCollection class Removed the class MatchCollection from the compat module and all it's usages Change-Id: Ifc8ccf733c85caa257390595b2eb79f9546c2fdd Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/MatchCollection.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Regex.java 2 files changed, 0 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc8ccf733c85caa257390595b2eb79f9546c2fdd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: build: prepare for ovirt-log-collector-3.2.0 release
by kroberts＠redhat.com 05 Feb '13

05 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: build: prepare for ovirt-log-collector-3.2.0 release ...................................................................... build: prepare for ovirt-log-collector-3.2.0 release Change-Id: I5bbdf1197b452962480eaeb57768f97a4ccca2f5 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Kiril Nesenko: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bbdf1197b452962480eaeb57768f97a4ccca2f5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: build: prepare for ovirt-image-uploader-3.2.0 release
by kroberts＠redhat.com 05 Feb '13

05 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: build: prepare for ovirt-image-uploader-3.2.0 release ...................................................................... build: prepare for ovirt-image-uploader-3.2.0 release Change-Id: Ida8837ac9e84110e0f2e5b7e691d43653c738c71 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Kiril Nesenko: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida8837ac9e84110e0f2e5b7e691d43653c738c71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: build: prepare for ovirt-iso-uploader-3.2.0 release
by kroberts＠redhat.com 05 Feb '13

05 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: build: prepare for ovirt-iso-uploader-3.2.0 release ...................................................................... build: prepare for ovirt-iso-uploader-3.2.0 release Change-Id: Ica283e5276591b6852fe6b0a886ec5db7c0cab10 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Kiril Nesenko: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica283e5276591b6852fe6b0a886ec5db7c0cab10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: uicommonweb: timezone reset when os type change in VM popup
by tjelinek＠redhat.com 05 Feb '13

05 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: uicommonweb: timezone reset when os type change in VM popup ...................................................................... uicommonweb: timezone reset when os type change in VM popup It is done by caching the timezone value string for windows timezone and general timezone Change-Id: I322df5bae018c4d8d1a0647057634daf05c01ec7 Signed-off-by: plysan <plysab(a)gmail.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I322df5bae018c4d8d1a0647057634daf05c01ec7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ly pan <plysab(a)gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed DoubleCompat class
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed DoubleCompat class ...................................................................... core: Removed DoubleCompat class Change-Id: Ia5f3cb48bf49064de543c9478bbb2b445055bbb0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DoubleCompat.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml 4 files changed, 28 insertions(+), 37 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5f3cb48bf49064de543c9478bbb2b445055bbb0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed NumberStyles class
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed NumberStyles class ...................................................................... core: Removed NumberStyles class Removed the class NumberStyles from the compat module, also removed the methods using it, all of which did not have any references Change-Id: I0abe40050c1bafb0e25c11a917b5e722fea0d7e0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/IntegerCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/LongCompat.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NumberStyles.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml 4 files changed, 0 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0abe40050c1bafb0e25c11a917b5e722fea0d7e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed the LongCompat class
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed the LongCompat class ...................................................................... core: Removed the LongCompat class Removed the LongCompat class and replaced all calls in Long.parse with catching NumberFormatException, there are error handling anyway in each of the references so it added no boilerplate code Change-Id: If2b672f3406ce7b3316a5ff1b50379d92eedb062 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/LongCompat.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtilsSeedingRule.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml 5 files changed, 12 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2b672f3406ce7b3316a5ff1b50379d92eedb062 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0