Change in ovirt-engine[master]: core: Removed the unused GetStorageStatisticsQuery
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Removed the unused GetStorageStatisticsQuery
......................................................................
core: Removed the unused GetStorageStatisticsQuery
This patch removes the unused GetStorageStatisticsQuery and its
corresponding constant in VdcQueryType.
Note that the query's code was commented out anyway.
Change-Id: I31475d3394c1446653678e0a5cd4f910d7fccb00
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStorageStatisticsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 0 insertions(+), 15 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13226
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31475d3394c1446653678e0a5cd4f910d7fccb00
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: Remove unused licensing VdcQueryTypes.
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused licensing VdcQueryTypes.
......................................................................
core: Remove unused licensing VdcQueryTypes.
Removed the enum constants GetLicenseProperties and
GetLicenseProductType, as their corresponding query objects no longer
exist, and on their own they are useless.
Change-Id: I02cc5f5d99c2a016320c4a397e872e3a7ace8842
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 1 insertion(+), 4 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02cc5f5d99c2a016320c4a397e872e3a7ace8842
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: Remove GetAdGroupsAttechedToTimeLeaseVmPool
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetAdGroupsAttechedToTimeLeaseVmPool
......................................................................
core: Remove GetAdGroupsAttechedToTimeLeaseVmPool
GetAdGroupsAttechedToTimeLeaseVmPoolQuery is not used anywhere in the
code, and thus should be removed.
This patch removes the following:
1. The GetAdGroupsAttechedToTimeLeaseVmPoolQuery class.
2. The GetAdGroupsAttechedToTimeLeaseVmPoolParameters class only
used by the aforementioned query class.
3. The GetAdGroupsAttechedToTimeLeaseVmPool constant in VdcQueryType
corresponding to the aforementioned query class.
4. The getAllTimeLeasedForPool(int) method from AdGroupDAO and its
implementation. Note that the underlying stored procedure called
from this method no longer exists, so it could not have worked
anyway.
Change-Id: Idd4265f3f979a76f70d9dcabf5b69e05fc9a0708
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAdGroupsAttachedToTimeLeasedVmPoolQuery.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAdGroupsAttachedToTimeLeasedVmPoolParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AdGroupDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AdGroupDAODbFacadeImpl.java
5 files changed, 0 insertions(+), 52 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd4265f3f979a76f70d9dcabf5b69e05fc9a0708
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: Removed unused GetXXXMessageQurey classes
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Removed unused GetXXXMessageQurey classes
......................................................................
core: Removed unused GetXXXMessageQurey classes
The GetXXXMessagesQuery classes are no longer in use, and thus are
removed from the code base.
This path contains the following:
1. Removing the GetXXMessagesQuery classes.
2. Removing the GetXXMessagesParameteres classes used by the
aforementioned query classes.
3. Removing the constants in VdcQueryType that correspond to the
aforementioned removed queries.
4. Removing the GetMessagesByIdParameterBase which was the base class
for all the aforementioned parameter classes and modifying
GetAllEventMessagesQuery, which was the only query to use
GetMessagesByIdParameterBase directyly to use
VdcQueryParameterBase instead of it.
5. Removing the UserMessageController class which was only used by the
GetUserMessageQuery class.
Change-Id: I747d1bc71bda99717e7816a6674d30e99ed007c8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllEventMessagesQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEventMessagesQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTemplateMessagesQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserMessageQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserMessagesQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsMessagesQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsMessagesQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserMessageController.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetEventMessagesParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetMessagesByIdParametersBase.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTemplateMessagesParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUserMessageParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUserMessagesParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsMessagesParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsMessagesParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java
17 files changed, 6 insertions(+), 294 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13282
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I747d1bc71bda99717e7816a6674d30e99ed007c8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: Remove GetResourceUsage constant
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetResourceUsage constant
......................................................................
core: Remove GetResourceUsage constant
Removed the enum constant VdcQueryType.GetResourceUsage since the
GetResourceUsageQuery class it represents is long gone, and is no longer
available in the code base.
Change-Id: Ie0ec4b45f293ea15f97155175695edbd7888bb99
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0ec4b45f293ea15f97155175695edbd7888bb99
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: Remove GetVmsRunningOnVDS
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetVmsRunningOnVDS
......................................................................
core: Remove GetVmsRunningOnVDS
GetVmsRunningOnVDSQuery is not used anywhere in the
code, and thus should be removed.
This patch removes the following:
1. The GetVmsRunningOnVDSQuery class.
2. The GetVmsRunningOnVDSParameters class only
used by the aforementioned query class.
3. The GetVmsRunningOnVDS constant in VdcQueryType
corresponding to the aforementioned query class.
Change-Id: I519f1c4c74eb641b7251a830f5eb2317d868a9db
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnVDSQuery.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
3 files changed, 0 insertions(+), 38 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I519f1c4c74eb641b7251a830f5eb2317d868a9db
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: prevent rollback on VmReplicateDiskFinish success
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: prevent rollback on VmReplicateDiskFinish success
......................................................................
core: prevent rollback on VmReplicateDiskFinish success
Preventing rollback on execution success
(moved rollback avoidance logic to revertTask).
Change-Id: I06a8d395c729e915ece4e0ff413cb006542d4785
Bug-Url: https://bugzilla.redhat.com/923992
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java
1 file changed, 4 insertions(+), 6 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13306
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06a8d395c729e915ece4e0ff413cb006542d4785
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: LiveMigrateDisk - check isRunningOrPaused VMStatus
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: LiveMigrateDisk - check isRunningOrPaused VMStatus
......................................................................
core: LiveMigrateDisk - check isRunningOrPaused VMStatus
LiveMigrateDiskCommand - check isRunningOrPaused VMStatus instead of
isUpOrPaused [to prevent command failure when the VM changes
running status (e.g. RebootInProgress) while live migrating)].
Change-Id: I546dbe5e225ee0db5ca190d3237b70c5a425e004
Bug-Url: https://bugzilla.redhat.com/923992
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I546dbe5e225ee0db5ca190d3237b70c5a425e004
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
11 years, 1 month
Change in otopi[master]: core: support overriding environment
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: support overriding environment
......................................................................
core: support overriding environment
Useful for distro settings.
Change-Id: Ib619c87ac41374ef5007beb3d6de068fcfeb3ff5
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/bin/otopi
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13316
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib619c87ac41374ef5007beb3d6de068fcfeb3ff5
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: engine: fixed NPE in add host
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: engine: fixed NPE in add host
......................................................................
engine: fixed NPE in add host
The patch http://gerrit.ovirt.org/13001 modified setVds to set the
mVdsId to Empty in case VDS is passed as null. This results in an
NPE as AddVdsCommand explicitly sets VDS to null, and later calls
getVdsIdRef(), expecting it to be null, but is now Empty.
Hence modifying setVds() to not set it to Empty in case of null, but
leave it as null itself.
Change-Id: I369203472969e707cb515bf593f12849b13b694c
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Shireesh Anjal: Verified
--
To view, visit http://gerrit.ovirt.org/13325
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I369203472969e707cb515bf593f12849b13b694c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 1 month
