March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[engine_3.2]: packaging: Move dependencies to a JBoss module
by juan.hernandez＠redhat.com 11 Mar '13

11 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Move dependencies to a JBoss module ...................................................................... packaging: Move dependencies to a JBoss module Currently we package dependencies as .jar files in the lib directories of the .ear and in the .war of RESTAPI. This has the inconvenient that those dependencies don't have an associated artifact and also can't be shared from different applications. This patch moves all those dependencies to the dependencies jboss module, so that they are added to the corresponding artifact, and can then be easily installed and shared. Change-Id: I9a211b4c24dd02c6e018c6be62beee2d1f5f9afe Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e8081ab1b6e560ada7a26240e97dfc65ec475423) --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/org/ovirt/engine/core/dependencies/main/module.xml M backend/manager/modules/restapi/webapp/pom.xml M ear/pom.xml M ear/src/main/resources/META-INF/MANIFEST.MF M packaging/fedora/spec/ovirt-engine.spec.in 6 files changed, 367 insertions(+), 258 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a211b4c24dd02c6e018c6be62beee2d1f5f9afe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: core: Create artifact for PostgreSQL module
by juan.hernandez＠redhat.com 11 Mar '13

11 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Create artifact for PostgreSQL module ...................................................................... core: Create artifact for PostgreSQL module Currently we are deploying the PostgreSQL module using the "setup" profile, but we don't have an artifact for the required module. This patch reuses the module description that we had and uses it to build a new "dependencies" artifact that can then be easily installed. Change-Id: Ibcb409420a724dd30bf1485a78f0c9828903fd21 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit b70f24c0ecf0eda2deeaef632d1e553158790c83) --- M Makefile A backend/manager/dependencies/pom.xml R backend/manager/dependencies/src/main/modules/org/postgresql/main/module.xml M backend/manager/pom.xml M ear/pom.xml M packaging/fedora/spec/ovirt-engine.spec.in 6 files changed, 68 insertions(+), 36 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcb409420a724dd30bf1485a78f0c9828903fd21 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: core: Maven plugin to generate JBoss modules
by juan.hernandez＠redhat.com 11 Mar '13

11 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Maven plugin to generate JBoss modules ...................................................................... core: Maven plugin to generate JBoss modules This change introduces a new maven plugin that generates .zip files containing JBoss modules and attaches them as artifacts. Change-Id: I8f1f106046c2924429d3b766c84b0c1ac307ec2a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9b3e223cf8b9828f96f36fb2e3490babef729b7f) --- A build-tools-root/jboss-modules-maven-plugin/pom.xml A build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/Module.java A build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java M build-tools-root/pom.xml M pom.xml 5 files changed, 373 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f1f106046c2924429d3b766c84b0c1ac307ec2a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: core: Make explicit version of maven war plugin
by juan.hernandez＠redhat.com 11 Mar '13

11 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Make explicit version of maven war plugin ...................................................................... core: Make explicit version of maven war plugin Currently we don't explicitly specify the version of the maven war plugin that we use. This patch makes it explicit in the plugin management section of the root POM. Change-Id: I75a6a4e6bc164a01448b73fae33f36e60a7c9c31 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit d1b25b148aab648a78ea5c6d9bcc948b27527512) --- M pom.xml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75a6a4e6bc164a01448b73fae33f36e60a7c9c31 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: core: Make antrun plugin version explicit
by juan.hernandez＠redhat.com 11 Mar '13

11 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Make antrun plugin version explicit ...................................................................... core: Make antrun plugin version explicit Currently we don't explicitly specify the version of the maven ant plugin that we use. This means that we use an old version. This patch udpates to version 1.7 and makes it explicit in the parent POM. Change-Id: Id3297da17facdcf72878ecb2891d142a54634dee Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 913b958cac7176f965c16524a69e505f7ebe3e46) --- M ear/pom.xml M pom.xml 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3297da17facdcf72878ecb2891d142a54634dee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: core: Make explicit version of maven ear plugin
by juan.hernandez＠redhat.com 11 Mar '13

11 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Make explicit version of maven ear plugin ...................................................................... core: Make explicit version of maven ear plugin Currently we don't explicitly specify the version of the maven ear plugin that we use. This patch makes it explicit in the plugin management section of the root POM. Change-Id: Ia0718385df3f3cc8e4113210294890c774de6209 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e7efd1f61f1ac879fb0a0a62a91539592189d6d0) --- M pom.xml 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0718385df3f3cc8e4113210294890c774de6209 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: core: Don't use commons collections clone method
by juan.hernandez＠redhat.com 11 Mar '13

11 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Don't use commons collections clone method ...................................................................... core: Don't use commons collections clone method The commons collections package provides a mechanism to clone an object doing serialization and then deserialization. Unfortunatelly the implementation uses its own class loader (the class loader that loaded commons collections itself) to load the class of the serialized object. This means that the deserialization will fail if commons collections happens to use be loaded by a class loader that doesn't have access to the class being cloned. This is what happens if we try to use a JBoss module instead of dropping commons-collections in the lib directory of the ear. This patch implements the clone method so that it uses the context class loader if possible, this solves the issue with separate class loaders. Change-Id: Ie563237017e19c9c1462f549c9211fd3c3779999 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit c85128b91ddd69084f0d2cf64b8b069a646492ec) --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/CopyOnAccessMap.java 1 file changed, 70 insertions(+), 9 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie563237017e19c9c1462f549c9211fd3c3779999 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: core: Move encryption utilities to utils
by juan.hernandez＠redhat.com 11 Mar '13

11 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Move encryption utilities to utils ...................................................................... core: Move encryption utilities to utils We have only two utility classes in the engineencryptutils project, and they fit will in the utils project. Change-Id: Idc40671d65d8f47d051302506a7a64f7b1240b33 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit d70b98882fedecac0130d5e9486ea7a8901f1dd1) --- M Makefile M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java M backend/manager/modules/bll/src/test/resources/log4j.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DomainsPasswordMap.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DomainsPasswordMapTest.java D backend/manager/modules/engineencryptutils/pom.xml D backend/manager/modules/engineencryptutils/src/test/java/ca.der D backend/manager/modules/engineencryptutils/src/test/java/ca.pfx D backend/manager/modules/engineencryptutils/src/test/resources/key.p12 D backend/manager/modules/engineencryptutils/src/test/resources/log4j.xml M backend/manager/modules/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/pki/PKIResourceServlet.java M backend/manager/modules/utils/pom.xml R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EncryptionUtils.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHDialog.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/EncryptionUtilsTest.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtilsTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java M backend/manager/modules/utils/src/test/resources/log4j.xml M backend/manager/tools/pom.xml M backend/manager/tools/src/main/conf/engine-config-log4j.xml M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java M backend/manager/tools/src/main/shell/engine-config.sh M backend/manager/tools/src/main/shell/engine-manage-domains.sh M backend/manager/tools/src/main/shell/engine-notifier.sh M ear/pom.xml M packaging/fedora/spec/ovirt-engine.spec.in 35 files changed, 20 insertions(+), 146 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc40671d65d8f47d051302506a7a64f7b1240b33 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: core: Remove Encr?ptionManagerMessages
by juan.hernandez＠redhat.com 11 Mar '13

11 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove Encr?ptionManagerMessages ...................................................................... core: Remove Encr?ptionManagerMessages There are two classes with this name, one with "y" and one with "i". None of them is used. Change-Id: I22a6c6a76e4be670d222fd701fcc63016653f813 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 5f112ba0549304a8e50e02f1b59aafb257170f56) --- D backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncriptionManagerMessages.java D backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionManagerMessages.java 2 files changed, 0 insertions(+), 61 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22a6c6a76e4be670d222fd701fcc63016653f813 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: tools: Consolidate all tools to single project
by juan.hernandez＠redhat.com 11 Mar '13

11 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: tools: Consolidate all tools to single project ...................................................................... tools: Consolidate all tools to single project Currently the source files used by the tools are located in several projects and this makes locating and working with them difficult. This patch moves all the files related to the tools to a single maven project with a single artifact. Change-Id: Ib793c35c95857d19c76675da9802fef35134668a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit a504dee1329aa0c0dd5d3c36a1d9c52c98f82830.) --- M .gitignore M Makefile M backend/manager/modules/utils/pom.xml D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/LdapAuthModeEnum.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/LdapModeEnum.java D backend/manager/tools/engine-config/pom.xml D backend/manager/tools/engine-notifier/engine-notifier-resources/pom.xml D backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/assembly/assembly.xml D backend/manager/tools/engine-notifier/engine-notifier-service/pom.xml D backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/log4j.xml D backend/manager/tools/engine-notifier/pom.xml D backend/manager/tools/engine-tools-common/pom.xml D backend/manager/tools/engine-tools-common/src/test/resources/log4j.xml M backend/manager/tools/pom.xml R backend/manager/tools/src/main/conf/engine-config-log4j.xml R backend/manager/tools/src/main/conf/engine-config.conf R backend/manager/tools/src/main/conf/engine-config.properties A backend/manager/tools/src/main/conf/engine-manage-domains-log4j.xml R backend/manager/tools/src/main/conf/engine-manage-domains.conf R backend/manager/tools/src/main/conf/engine-notifier-log4j.xml R backend/manager/tools/src/main/conf/engine-notifier.conf R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/AppConfig.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/ConfigFile.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigMap.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigUtils.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/KeysConfig.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/OptionKey.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDAO.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDaoImpl.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CustomPropertiesValueHelper.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/IntegerValueHelper.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringMultipleValueHelper.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/ValidationResult.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/ValueHelper.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ConfigActionType.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/EngineConfigValidator.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/EngineConfigValidatorFactory.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/GetValidator.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/SetValidator.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ValidatorType.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/DomainsConfigurationEntry.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/FailedReadingConfigValueException.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/LdapAuthModeEnum.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/LdapModeEnum.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsConfiguration.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsDAO.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsDAOImpl.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsResult.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsResultEnum.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/PasswordDomainsConfigurationEntry.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationServiceException.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/EventMethodFiller.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodFactory.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodFactoryEmailImpl.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodMapBuilder.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationConfigurator.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/EventSender.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/EventSenderResult.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventMessageContent.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventSenderMailImpl.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/MessageBody.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/MessageHelper.java R backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java R backend/manager/tools/src/main/shell/engine-config.sh A backend/manager/tools/src/main/shell/engine-manage-domains.sh R backend/manager/tools/src/main/shell/engine-notifier-service.sh R backend/manager/tools/src/main/shell/engine-notifier.sh R backend/manager/tools/src/main/shell/engine-prolog.sh.in R backend/manager/tools/src/main/test/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSourceTest.java R backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigCLIParserTest.java R backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigLogicTest.java R backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigTest.java R backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigValidatorTest.java R backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/EngineMonitorServiceTest.java R backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/NotificationServiceTest.java R backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/NotificationConfiguratorTest.java R backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/mail/MailSenderTest.java R backend/manager/tools/src/test/resources/conf/connection-test-notifier.conf R backend/manager/tools/src/test/resources/conf/error-notifier.conf R backend/manager/tools/src/test/resources/conf/notifier.conf R backend/manager/tools/src/test/resources/engine-config.conf R backend/manager/tools/src/test/resources/engine-config.properties R backend/manager/tools/src/test/resources/engine-config_es_ES.properties R backend/manager/tools/src/test/resources/engine-config_he_IL.properties R backend/manager/tools/src/test/resources/engine-config_iw_IL.properties R backend/manager/tools/src/test/resources/log4j.xml M packaging/fedora/setup/basedefs.py M packaging/fedora/spec/ovirt-engine.spec.in M pom.xml 104 files changed, 322 insertions(+), 466 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib793c35c95857d19c76675da9802fef35134668a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0