Change in ovirt-engine[master]: core: Locale docs servlet.
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: core: Locale docs servlet.
......................................................................
core: Locale docs servlet.
- Added DocsServlet to automatically redirect users if
the servlet cannot find the documentation in the users locale.
- Added a check to make sure we are being passed a valid locale.
- Added an intermediate page to inform the user that the
documentation in their locale does not exist and how to install
it.
- Added unit tests for all used classes.
Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c5
Bug-Url: https://bugzilla.redhat.com/885823
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/root/pom.xml
A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/DocsServlet.java
M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/FileServlet.java
A backend/manager/modules/root/src/main/webapp/WEB-INF/help/no_lang.jsp
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
A backend/manager/modules/root/src/test/java/org/ovirt/engine/core/DocsServletTest.java
A backend/manager/modules/root/src/test/java/org/ovirt/engine/core/FileServletTest.java
A backend/manager/modules/root/src/test/resources/org/ovirt/engine/core/filetest/en-US/index.html
A backend/manager/modules/root/src/test/resources/org/ovirt/engine/core/filetest/fr/index.html
A backend/manager/modules/root/src/test/resources/org/ovirt/engine/core/filetest/index.html
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocaleUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ServletUtils.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/LocaleUtilsTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ServletUtilsTest.java
A backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/zerosize
15 files changed, 1,130 insertions(+), 70 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c5
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: userportal: Fix compilation error
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: Fix compilation error
......................................................................
userportal: Fix compilation error
Fix unused import checkstyle violation introduced by
f4fcac9d9a6873ea294ab1f14c24a83a61264d07
Change-Id: I167902214c3ed88fc8955883eb5b6197ed0c2795
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Martin Beták: Verified
--
To view, visit http://gerrit.ovirt.org/13845
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I167902214c3ed88fc8955883eb5b6197ed0c2795
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Beták <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: engine: Frontend support for setting per-VM VncKeyboardLayou...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: Frontend support for setting per-VM VncKeyboardLayout
......................................................................
engine: Frontend support for setting per-VM VncKeyboardLayout
Added combobox to EditVM dialog for setting the VncKeyboardLayout per
individual VM.
Change-Id: I8f143e5b8425805ea87651ec382f0bc95f584591
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=916866
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
16 files changed, 81 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Beták: Verified
--
To view, visit http://gerrit.ovirt.org/12787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f143e5b8425805ea87651ec382f0bc95f584591
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Beták <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: userportal, webadmin: cleanup console utils usage
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: cleanup console utils usage
......................................................................
userportal,webadmin: cleanup console utils usage
Following cleanups:
- removed code which was copy/pasted to configurator
- moved common configurator configuration from UtilsModule to BaseUtilsModule
- removed couple of unused declarations
Change-Id: If073bd036a46d9bae3aa21f088cc76c83af613ee
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUtilsModule.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UtilsModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/UtilsModule.java
5 files changed, 10 insertions(+), 58 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If073bd036a46d9bae3aa21f088cc76c83af613ee
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: packaging: fixing fqdn validation
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: fixing fqdn validation
......................................................................
packaging: fixing fqdn validation
if _getPatternFromNslookup returns an empty set,
the validation will have caused a traceback.
Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/fedora/setup/engine_validators.py
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Mark Huth <mhuth(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Remove GetEventSubscribersBySubscriberId
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Remove GetEventSubscribersBySubscriberId
......................................................................
core: Remove GetEventSubscribersBySubscriberId
GetEventSubscribersBySubscriberIdQuery is not used anywhere in
the code, and hence should be removed.
This patch removes the following:
1. The GetEventSubscribersBySubscriberIdQuery class.
2. The GetEventSubscribersBySubscriberId constant representing
it in VdcQueryType.
Change-Id: Ib58c99f7e73ac7cd3baff5fe6f53955c328e1c9b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEventSubscribersBySubscriberIdQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 0 insertions(+), 19 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib58c99f7e73ac7cd3baff5fe6f53955c328e1c9b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Remove GetAllEventSubsribers
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Remove GetAllEventSubsribers
......................................................................
core: Remove GetAllEventSubsribers
GetAllEventSubsribersQuery is not used anywhere in
the code, and hence should be removed.
This patch removes the following:
1. The GetAllEventSubsribersQuery class.
2. The GetAllEventSubsribers constant representing
it in VdcQueryType.
3. The getAll() method in EvetDAO, its
implementation, test and underlying stored procedure, as this
method was only used by the aforementioned query.
Change-Id: Ic49e45cfdec1b08d2688d1e33f62a32176510547
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/dbscripts/event_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllEventSubscribersQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java
6 files changed, 0 insertions(+), 59 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13604
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic49e45cfdec1b08d2688d1e33f62a32176510547
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Remove GetNotificationEventMap
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Remove GetNotificationEventMap
......................................................................
core: Remove GetNotificationEventMap
GetNotificationEventMapQuery is not used anywhere in
the code, and hence should be removed.
This patch removes the following:
1. The GetNotificationEventMapQuery class.
2. The GetNotificationEventMap constant representing
it in VdcQueryType.
3. The getAllEventMaps() method in EvetDAO, its
implementation, test and underlying stored procedure, as this
method was only used by the aforementioned query.
Change-Id: Icfb382d6d294ac4ce940646cc0ef33f35d9e10cc
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/dbscripts/event_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNotificationEventMapQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java
6 files changed, 0 insertions(+), 53 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfb382d6d294ac4ce940646cc0ef33f35d9e10cc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Remove GetEventNotificationMethodByType
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Remove GetEventNotificationMethodByType
......................................................................
core: Remove GetEventNotificationMethodByType
GetEventNotificationMethodByTypeQuery is not used anywhere in
the code, and hence should be removed.
This patch removes the following:
1. The GetEventNotificationMethodByTypeQuery class.
2. The GetEventNotificationMethodByType constant representing
it in VdcQueryType.
3. The GetEventNotificationMethodByTypeParameters class only used by
the aforementioned query.
3. The getAllEventNotificationMethodByTppe() method in EvetDAO, its
implementation, test and underlying stored procedure, as this
method was only used by the aforementioned query.
Change-Id: Ib347d2f60c84924f2b3e3904066c3e9582e8f736
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/dbscripts/event_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEventNotificationMethodByTypeQuery.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetEventNotificationMethodByTypeParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java
7 files changed, 0 insertions(+), 80 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13602
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib347d2f60c84924f2b3e3904066c3e9582e8f736
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Remove GetEventNotificationMethods
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Remove GetEventNotificationMethods
......................................................................
core: Remove GetEventNotificationMethods
GetEventNotificationMethodsQuery is not used anywhere in
the code, and hence should be removed.
This patch removes the following:
1. The GetEventNotificationMethodsQuery class.
2. The GetEventNotificationMethods constant representing
it in VdcQueryType.
3. The getAllEventNotificationMethods() method in EvetDAO, its
implementation, test and underlying stored procedure, as this
method was only used by the aforementioned query.
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
Change-Id: I9ab37e8fb5a1602b0d8d0d9b1107c596dd33093b
---
M backend/manager/dbscripts/event_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEventNotificationMethodsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java
6 files changed, 5 insertions(+), 63 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13601
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ab37e8fb5a1602b0d8d0d9b1107c596dd33093b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 2 months