April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: ClassCastException in VmSnapshotListModel fix
by gchaplik＠redhat.com 10 Apr '13

10 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: frontend: ClassCastException in VmSnapshotListModel fix ...................................................................... frontend: ClassCastException in VmSnapshotListModel fix The change in AsyncDataProvider.GetCustomPropertiesList in ada6bac1 caused ClassCastException. This patch fixes handling result of this method in VmSnapshotListModel. Change-Id: Ie23f1994d218742133a7d963173e416d8e94cfcc Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 2 insertions(+), 14 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie23f1994d218742133a7d963173e416d8e94cfcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Run tests without data source location retry
by sanjal＠redhat.com 10 Apr '13

10 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: core: Run tests without data source location retry ...................................................................... core: Run tests without data source location retry Since commit fd6835 the application retries the location of the data source, this means that some tests will take a long time to run because the data source is never deployed in the testing environment. To prevent that this change adds configuration parameters to run those tests with an alternative configuration that disables the retry. Change-Id: I8583da699ae46ce571bb96aa79809031d8d54990 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/pom.xml A backend/manager/modules/bll/src/test/resources/engine.conf A backend/manager/modules/bll/src/test/resources/engine.conf.defaults 3 files changed, 14 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8583da699ae46ce571bb96aa79809031d8d54990 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Enable Gluster hooks
by kmayilsa＠redhat.com 10 Apr '13

10 Apr '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Enable Gluster hooks ...................................................................... webadmin: Enable Gluster hooks Enable action added for Gluster Hooks sub tab in cluster. Change-Id: If4b3af2c0669278e1fc776420e1ed8bf70ddbe5f Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java 3 files changed, 85 insertions(+), 16 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4b3af2c0669278e1fc776420e1ed8bf70ddbe5f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Enable gluster hook on cluster
by sanjal＠redhat.com 10 Apr '13

10 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Enable gluster hook on cluster ...................................................................... engine: Enable gluster hook on cluster Added Bll command to enable a given gluster hook on all available up servers in the gluster cluster. This command will be invoked from the hook management UI. Once the BLL command is invoked, - VDS command is called to enable hook on each of the server. - Hook's status is changed to enabled in DB. - If there are errors enabling the hook on any of the servers in the cluster, the conflict status of hook is updated in DB to indicate that there is a status conflict. Added an abstract class GlusterHookStatusChangeCommand that EnableGlusterHookCommand extends from. This class uses ThreadPoolUtil to invoke the VDS commands simultaneously. Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ClusterUtils.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterHookParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 18 files changed, 578 insertions(+), 5 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Fix notifier to safely handle MAIL_SERVER
by yzaslavs＠redhat.com 10 Apr '13

10 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fix notifier to safely handle MAIL_SERVER ...................................................................... tools: Fix notifier to safely handle MAIL_SERVER Change-Id: Ica12831cbb0b1ccae3d1f93c5d67e3ef9e5ae024 signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica12831cbb0b1ccae3d1f93c5d67e3ef9e5ae024 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Host with no display network should not be selected ...
by alkaplan＠redhat.com 10 Apr '13

10 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Host with no display network should not be selected to run VMs ...................................................................... engine: Host with no display network should not be selected to run VMs If ConfigValue.OnlyRequiredNetworksMandatoryForVdsSelection is false, or if the cluster's display network is not attached to the host, the host shouldn't be selected/eligible to run VMs in that cluster. Change-Id: Ie90e2821f2299be85b1d4c9a6f064a4053f93e73 Bug-Url: https://bugzilla.redhat.com/949434 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 82 insertions(+), 15 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie90e2821f2299be85b1d4c9a6f064a4053f93e73 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, core: enable edit Posix storage domains
by amureini＠redhat.com 10 Apr '13

10 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin, core: enable edit Posix storage domains ...................................................................... webadmin, core: enable edit Posix storage domains Enable editing path of Posix storage domains via UI. Domains can be edited when in maintenance, the edited properties are path, vfstype and mount options. Change-Id: I8904ffab80e9d6e6bfdee4b8375872d1ff64b4d4 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 269 insertions(+), 94 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8904ffab80e9d6e6bfdee4b8375872d1ff64b4d4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Support 3.1 network topologies by AttachNetwork
by mkolesni＠redhat.com 10 Apr '13

10 Apr '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Support 3.1 network topologies by AttachNetwork ...................................................................... engine: Support 3.1 network topologies by AttachNetwork The patch provides support for 3.1 network topologies by the AttachNetworkCommand, also exposed via the api by: api/hosts/{host:id}/nics/{nic:id}/attach The supported network topologies over a nic are: 1. Attach a VM network (with/without vlan) 2. Attach a non-VM network (with/without vlan) 3. Attach a non-VM network to a nic which a vlan is already attached to. 4. Attach a vlan to a nic which a non-VM network is already attached to. The unsupported network topologies are: 1. Attaching any network to a nic which a non-vlan VM network is already attached to. 2. Attach a non-vlan VM network to a nic which any network is already attached to. 3. Attach a non-VM network to a nic which a non-VM network is already attached to. 4. Attach any network to a nic if unmanaged network is already attached to. Change-Id: I9e1abe84e2877171be5af41c9bb3ab590fed3653 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java 1 file changed, 82 insertions(+), 23 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/13722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e1abe84e2877171be5af41c9bb3ab590fed3653 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing perfomance issue between VdsRunTimeInfo and R...
by mkublin＠redhat.com 10 Apr '13

10 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing perfomance issue between VdsRunTimeInfo and RunVmCommandBase ...................................................................... engine: Fixing perfomance issue between VdsRunTimeInfo and RunVmCommandBase After introducing atomic update, no need for special lock inside of RunVmCommandBase.decreasePendingVms() In order to keep functionality for delay: SynchronousQueue will be used. The thread will stuck until time out or some other thread will add some object to queue Change-Id: Ia6c6e26c79dc6c06c9621e1938ecd034e9ce7ec7 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsMonitor.java 2 files changed, 21 insertions(+), 48 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c6e26c79dc6c06c9621e1938ecd034e9ce7ec7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Compare and set instead of updateVdsDynamic in VM sc...
by mkublin＠redhat.com 10 Apr '13

10 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Compare and set instead of updateVdsDynamic in VM scenarios ...................................................................... engine: Compare and set instead of updateVdsDynamic in VM scenarios The following patch should solve a following problems: 1. Deadlock between RunVmCommandBase.decreasePendingVms and VdsUpdateRuntimeInfo.AfterRefreshTreatment line with code: ResourceManager.getInstance().getEventListener().processOnVmPoweringUp(...); 2. Replace get for vds dynamic , update some values, and after that update in db by single db update. The old way creates a dirty state fot host status field, fix will reduce a noise in host life cycle scenarios 3. Performance improved: less db access, less locks acquired, no deadlocks What is not solved (problems which were before and should be solved in next patches) 1. Race between VdsManager.OnTimer() and RunVmCommandBase.decreasePendingVms() 2. RunVmDelayer.evaluated can be based on not updated data 3. Interaction of loop over ResourceManager.getInstance().getEventListener().processOnVmPoweringUp(...) inside VdsUpdateRuntimeInfo.AfterRefreshTreatment with RunVmCommands - it is a war for locks, or "code of death" for all system during RunVm scenarious Change-Id: I363afc5c3411b0c13e6d6c9ed5b16004738b6ca7 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpdateVdsDynamicDataVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/UpdateVdsDynamicDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 13 files changed, 142 insertions(+), 169 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I363afc5c3411b0c13e6d6c9ed5b16004738b6ca7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0