Change in ovirt-engine[master]: webadmin: Gateway is not defined after bonding the RHEVM int...
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Gateway is not defined after bonding the RHEVM interface.
......................................................................
webadmin: Gateway is not defined after bonding the RHEVM interface.
When detaching the network its parameters (boot protocol, address, subnet
and gateway- for managenemt network) are saved for the next attach.
The bug was that in case of managemnet network the gateway parameter was
always determined from the nicEntity.
But if the management network is over vlan it should be taken from the
vlanNic.
Change-Id: I7deff4305d04a6cfc943bb38cb795373ea7ff6e4
Bug-Url: https://bugzilla.redhat.com/923443
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13790
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7deff4305d04a6cfc943bb38cb795373ea7ff6e4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: proxy: rename proxy httpd conf.d file
......................................................................
packaging: proxy: rename proxy httpd conf.d file
In rhel the mod_proxy_ajp module is loaded in its own conf.d file named
proxy_ajp.conf.
Our proxy configuration should be loaded after this configuration file
to make sure the proxy is loaded and the proxy_ajp_module symbol is
available.
Change-Id: Ic37b672d262985b38ea253c165ae2234d70963d2
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/ovirt-engine-proxy.conf.in
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13751
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic37b672d262985b38ea253c165ae2234d70963d2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: validate vfstype is not empty for Posix conn
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: validate vfstype is not empty for Posix conn
......................................................................
core: validate vfstype is not empty for Posix conn
Add validation when adding a new Posix storage connection that
vfsType is not empty.
Change-Id: I38bf5820ed6c6220bd2c9b9d6be1fa6dd31934ea
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
2 files changed, 73 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13760
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38bf5820ed6c6220bd2c9b9d6be1fa6dd31934ea
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: packaging: do not fail if /var/tmp/ovirt-engine missing
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: do not fail if /var/tmp/ovirt-engine missing
......................................................................
packaging: do not fail if /var/tmp/ovirt-engine missing
Change-Id: If189b0380911f857b5b412436b966801bb4827a2
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/engine-upgrade.py
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If189b0380911f857b5b412436b966801bb4827a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Allow skipping management network validation
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Allow skipping management network validation
......................................................................
engine: Allow skipping management network validation
The management network validation is skipped when refresh capabilities
is being executed as part of the host activation flow. In this flow
there is a change the host wasn't configured to have the management
network, therefore management network is removed from the network
validation and it be performed as part of the setup network sequence
in which the management network will be created on the host.
Change-Id: Idf4bf4affcd901b23e2d4d55ba85763928180fcd
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java
3 files changed, 26 insertions(+), 7 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11307
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf4bf4affcd901b23e2d4d55ba85763928180fcd
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Update host activeNic on GetCapabilities
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Update host activeNic on GetCapabilities
......................................................................
engine: Update host activeNic on GetCapabilities
The patch saves the value of activeNic provided by VDSM property
lastClientIface and returns the vds element which contains it as
a return value of the activate command.
Change-Id: I04e6452078a56e1aba0b57464ffde529285fb34d
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ActivateVdsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
3 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04e6452078a56e1aba0b57464ffde529285fb34d
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Add activeNic attribute to VDS class
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Add activeNic attribute to VDS class
......................................................................
core: Add activeNic attribute to VDS class
Added activeNic attribute to VDS class which represents the last
NIC used to communicate with the host.
Change-Id: I95b14d4f8315f85d15b12dde1b67524f5ffe9ae3
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95b14d4f8315f85d15b12dde1b67524f5ffe9ae3
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: userportal: fix SD selection on clone VM from template
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: userportal: fix SD selection on clone VM from template
......................................................................
userportal: fix SD selection on clone VM from template
Fixing storage domain selection when creating a VM
from template using clone allocation.
DisksAllocationModel -> getImageToDestinationDomainMap()
should be passed to AddVmFromTemplateParameters
(for getting user's selected values).
Change-Id: I67e6c4af0ffed01f37bf3c5798654a250e45a018
Bug-Url: https://bugzilla.redhat.com/928410
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
3 files changed, 9 insertions(+), 41 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13770
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67e6c4af0ffed01f37bf3c5798654a250e45a018
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 8 months
Change in ovirt-log-collector[ovirt-log-collector-3.2]: Added error handling on -H option
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: Added error handling on -H option
......................................................................
Added error handling on -H option
If an unknown host is specified using -H option, output an error
and exit with critical error code.
(cherry picked from dd7085ce5054f8306749b81674ab7ef4cb2423b1)
Change-Id: I4939cf66ba787c6970b7c457f2bdd605118a61c6
Bug-Url: https://bugzilla.redhat.com/918020
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4939cf66ba787c6970b7c457f2bdd605118a61c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-log-collector[master]: Added error handling on -H option
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: Added error handling on -H option
......................................................................
Added error handling on -H option
If an unknown host is specified using -H option, output an error
and exit with critical error code.
Change-Id: I4939cf66ba787c6970b7c457f2bdd605118a61c6
Bug-Url: https://bugzilla.redhat.com/918020
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13783
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4939cf66ba787c6970b7c457f2bdd605118a61c6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months