Change in ovirt-engine[master]: core: remove auto suspend of VM.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: remove auto suspend of VM.
......................................................................
core: remove auto suspend of VM.
Auto suspend is a feature which is no longer being used, therefore should
be deleted.
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: I7d9eb342e4ab04c87bc30545cc0831b11c21337a
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
M packaging/dbscripts/create_dwh_views.sql
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_03_0380_remove_auto_suspend.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
24 files changed, 13 insertions(+), 86 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d9eb342e4ab04c87bc30545cc0831b11c21337a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: tools: Trusted Compute Pools - Open Attestation integration ...
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: tools: Trusted Compute Pools - Open Attestation integration with oVirt engine proposal
......................................................................
tools: Trusted Compute Pools - Open Attestation integration with oVirt engine proposal
Detailed description: http://wiki.ovirt.org/Trusted_compute_pools
in this patchset, follow changes has been introduced:
1. Add a new flag TrustedService in ovf file to record whether the VM is exported from a trusted cluster.
2. Code cleanup.
Change-Id: I0f42f848798706be58acf1291c1841da1135d76d
Signed-off-by: Jimmy <gang.wei(a)intel.com>
Signed-off-by: Zhang Lijuan <lijuan.zhang(a)intel.com>
Signed-off-by: Dave Chen <wei.d.chen(a)intel.com>
Signed-off-by: Quan Xu <quan.xu(a)intel.com>
Signed-off-by: Dave Chen <wei.d.chen(a)intel.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M packaging/dbscripts/create_views.sql
9 files changed, 39 insertions(+), 1 deletion(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f42f848798706be58acf1291c1841da1135d76d
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gang Wei <gang.wei(a)intel.com>
Gerrit-Reviewer: Dave Chen <wei.d.chen(a)intel.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Emily Zhang <lijuan.zhang(a)intel.com>
Gerrit-Reviewer: Gang Wei <gang.wei(a)intel.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: restapi: Trusted Compute Pools - Open Attestation integratio...
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: restapi: Trusted Compute Pools - Open Attestation integration with oVirt engine proposal
......................................................................
restapi: Trusted Compute Pools - Open Attestation integration with oVirt engine proposal
Detailed description: http://wiki.ovirt.org/Trusted_compute_pools
In this patchset, add RESTful API to create a trusted Cluster.
Change-Id: Ib345054072e4998346c7be6d815d5ea8f3eace4e
Signed-off-by: Jimmy <gang.wei(a)intel.com>
Signed-off-by: Zhang Lijuan <lijuan.zhang(a)intel.com>
Signed-off-by: Dave Chen <wei.d.chen(a)intel.com>
Signed-off-by: Quan Xu <quan.xu(a)intel.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ClusterMapperTest.java
4 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14692
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib345054072e4998346c7be6d815d5ea8f3eace4e
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gang Wei <gang.wei(a)intel.com>
Gerrit-Reviewer: Dave Chen <wei.d.chen(a)intel.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Emily Zhang <lijuan.zhang(a)intel.com>
Gerrit-Reviewer: Gang Wei <gang.wei(a)intel.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: wedadmin: Trusted Compute Pools - Open Attestation integrati...
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: wedadmin: Trusted Compute Pools - Open Attestation integration with oVirt engine proposal
......................................................................
wedadmin: Trusted Compute Pools - Open Attestation integration with oVirt engine proposal
In this patchset, follow changes has been introduced:
1. Divide "cluster policy" side tab into two sections, "scheduling policy" and "additional properties" with an "Enable Trusted Service" checkbox.
2. Fix bug1: can't save cluster when not click Trusted service button.
3. Fix bug2: when click Trusted service must click Virt service.
4. Fix bug3: host existed in the cluster, disable the function for switching between trust cluster and non-trust cluster, and also, we will write log message.
Change-Id: I59396a68708797b868bcd871abb08b3dd514f757
Signed-off-by: Jimmy <gang.wei(a)intel.com>
Signed-off-by: Zhang Lijuan <lijuan.zhang(a)intel.com>
Signed-off-by: Dave Chen <wei.d.chen(a)intel.com>
Signed-off-by: Quan Xu <quan.xu(a)intel.com>
Signed-off-by: Dave Chen <wei.d.chen(a)intel.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
7 files changed, 142 insertions(+), 10 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59396a68708797b868bcd871abb08b3dd514f757
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gang Wei <gang.wei(a)intel.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dave Chen <wei.d.chen(a)intel.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Emily Zhang <lijuan.zhang(a)intel.com>
Gerrit-Reviewer: Gang Wei <gang.wei(a)intel.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: engine:Trusted Compute Pools - Open Attestation integration ...
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine:Trusted Compute Pools - Open Attestation integration with oVirt engine proposal
......................................................................
engine:Trusted Compute Pools - Open Attestation integration with oVirt engine proposal
Detailed description: http://wiki.ovirt.org/Trusted_compute_pools
In this patchset, follow changes has been introduced:
1. Remove Cache, and add hashmap<String, AttestationResultEnum> which for each VDS hostname it maps to the attested status.
2. Add initialization mechanism when engine reboot and set up a thread to support 2-phase aggregated attestation.
3. Bug fixing and code cleanup.
Change-Id: I8ce3448a821c74521d277f92f2c8d63ba0accfed
Signed-off-by: Jimmy <gang.wei(a)intel.com>
Signed-off-by: Zhang Lijuan <lijuan.zhang(a)intel.com>
Signed-off-by: Quan Xu <quan.xu(a)intel.com>
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
Signed-off-by: Dave Chen <wei.d.chen(a)intel.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestThread.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AttestationResultEnum.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/pom.xml
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationValue.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
A packaging/dbscripts/upgrade/03_03_0370_add_trusted_service_to_vds_groups.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/dbscripts/vds_groups_sp.sql
24 files changed, 546 insertions(+), 9 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ce3448a821c74521d277f92f2c8d63ba0accfed
Gerrit-PatchSet: 30
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gang Wei <gang.wei(a)intel.com>
Gerrit-Reviewer: Dave Chen <wei.d.chen(a)intel.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Emily Zhang <lijuan.zhang(a)intel.com>
Gerrit-Reviewer: Gang Wei <gang.wei(a)intel.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
10 years, 10 months
Change in ovirt-log-collector[ovirt-log-collector-3.2]: config: use .pgpass for db password
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: config: use .pgpass for db password
......................................................................
config: use .pgpass for db password
database connection parameters read from .pgpass were
all passed to the config parser as defaults with
the exception of the pg_pass default.
This patch set pg_pass with the value read from .pgpass
if not specified by command line or config file.
Change-Id: I60adef202e00cf9a49f9b512e499064ae705a4f1
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/16061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60adef202e00cf9a49f9b512e499064ae705a4f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: core: Move getEntityPermissions[ForUserAndGroup]
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Move getEntityPermissions[ForUserAndGroup]
......................................................................
core: Move getEntityPermissions[ForUserAndGroup]
Moved getEntityPermissions and getEntityPermissionsForUserAndGroups from
DbFacade to PermissionsDAO, where they belong.
Tests were moved from DbFacadeDAOTest to PremissionsDAOTest.
Change-Id: I6085afd4eca6bbd0c5f5ab615d6f06cd242f620a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HasAdElementReconnectPermissionQuery.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDAOTest.java
7 files changed, 97 insertions(+), 83 deletions(-)
Approvals:
Allon Mureinik: Verified
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6085afd4eca6bbd0c5f5ab615d6f06cd242f620a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: Move getOrderedVmGuidsForRunMultipleActions
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Move getOrderedVmGuidsForRunMultipleActions
......................................................................
core: Move getOrderedVmGuidsForRunMultipleActions
Moved getOrderedVmGuidsForRunMultipleActions(List<Guid>) from DbFacade
(which it has nothing to do with) to VmStaticDao, where it makes sense.
The tests for the method were moved from DbFacadeDAOTest to
VmStaticDAOTest.
A neat side bonus of this refactoring is getting all the capabilities of
BaseDbFacadeDAO for free, allowing the method's code to be made much
clearer.
Change-Id: Ide46b9ad358a5de2815b8d41df2f86f950c9127c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVMActionRunner.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java
6 files changed, 196 insertions(+), 232 deletions(-)
Approvals:
Allon Mureinik: Verified
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide46b9ad358a5de2815b8d41df2f86f950c9127c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: format DbFacadeDAOTest
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: format DbFacadeDAOTest
......................................................................
core: format DbFacadeDAOTest
Apply the project's code formatting to DbFacadeDAOTest in order to
facilitate future refactoring without any formatting "noise".
Change-Id: Ib1ed3d47fd50ff1b69f83ee03502f396ce209081
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java
1 file changed, 44 insertions(+), 30 deletions(-)
Approvals:
Allon Mureinik: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16384
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1ed3d47fd50ff1b69f83ee03502f396ce209081
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: Move Guid constants
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Move Guid constants
......................................................................
core: Move Guid constants
Moved the constant Guid instances to be initialized after Guid's
static fields to ensure that these Guids aren't partly initialized.
This patch addresses the FindBugs wanring
SI_INSTANCE_BEFORE_FINALS_ASSIGNED - "Static initializer for
org.ovirt.engine.core.compat.Guid creates instance before all static
final fields assigned"
Change-Id: If239587d8bddba89e19253ec1e147ef770b60e85
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16278
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If239587d8bddba89e19253ec1e147ef770b60e85
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months