January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: Fixing broken VMs search
by iheim＠redhat.com 30 Jan '14

30 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: Fixing broken VMs search ...................................................................... Fixing broken VMs search The work done to support the cloud init feature removed the vm_domain column however this column was not removed from the search. Therefore , searching on VMs tab with for example "VMs:vm1" throws the following exception Position: 208: org.springframework.jdbc.BadSqlGrammarException: StatementCallback; bad SQL grammar [SELECT * FROM (SELECT * FROM vms WHERE ( vm_guid IN (SELECT vms_with_tags.vm_guid FROM vms_with_tags WHERE ( vms_with_tags.vm_pool_name ILIKE '%vm1%' OR vms_with_tags.run_on_vds_name ILIKE '%vm1%' OR vms_with_tags.vm_domain ILIKE '%vm1%' OR vms_with_tags.tag_name ILIKE '%vm1%' OR vms_with_tags.guest_cur_user_name ILIKE '%vm1%' OR vms_with_tags.vm_name ILIKE '%vm1%' OR vms_with_tags.vm_description ILIKE '%vm1%' OR vms_with_tags.quota_name ILIKE '%vm1%' OR vms_with_tags.vm_host ILIKE '%vm1%' OR vms_with_tags.vm_ip ILIKE '%vm1%' OR vms_with_tags.storage_pool_name ILIKE '%vm1%' OR vms_with_tags.vds_group_name ILIKE '%vm1%' OR vms_with_tags.vm_comment ILIKE '%vm1%' ) )) ORDER BY vm_name ASC ) as T1 OFFSET (1 -1) LIMIT 100]; nested exception is org.postgresql.util.PSQLException: ERROR: column vms_with_tags.vm_domain does not exist This patch removes the vm_domain column from the search engine code as well. Change-Id: Id4085ca3cff220442a042e0038134c75d7860e61 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Shahar Havivi: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4085ca3cff220442a042e0038134c75d7860e61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: bin: instruct answer file at --config-appe...
by iheim＠redhat.com 30 Jan '14

30 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: bin: instruct answer file at --config-append usage ...................................................................... packaging: setup: bin: instruct answer file at --config-append usage Change-Id: I715a4d3f2037a147a0442e81b73029807651483b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/bin/ovirt-engine-remove M packaging/setup/bin/ovirt-engine-rename M packaging/setup/bin/ovirt-engine-setup 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715a4d3f2037a147a0442e81b73029807651483b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: [Fix] NPE in update vm/template (via rest)
by iheim＠redhat.com 30 Jan '14

30 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: core: [Fix] NPE in update vm/template (via rest) ...................................................................... core: [Fix] NPE in update vm/template (via rest) Boolean null is casted to boolean. Change-Id: If715acc7a0cbcf719f636cad6b9327f65cf3813c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1059780 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Gustavo Frederico Temple Pedrosa: Verified Martin Betak: Looks good to me, but someone else must approve Frank Kobzik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If715acc7a0cbcf719f636cad6b9327f65cf3813c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix NPE during OS selection
by derez＠redhat.com 30 Jan '14

30 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fix NPE during OS selection ...................................................................... webadmin: Fix NPE during OS selection This fixes some NPEs in the oSType_SelectedItemChanged() method of 3 behaviors associated with the UnitVmModel class. These were caused by an implicit cast from Integer to int of the currently selected OS. Change-Id: I94b2aef851431fad201c77eec97a74a0fe61396b Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java 3 files changed, 9 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, but someone else must approve Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94b2aef851431fad201c77eec97a74a0fe61396b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: Disable provisioning when using remote DB
by iheim＠redhat.com 30 Jan '14

30 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: Disable provisioning when using remote DB ...................................................................... packaging: Disable provisioning when using remote DB When engine-setup generates an answer-file and the user asks to use a remote DB, the setup should disable provisioning in the answer file, so running setup again with the created answer-file, it won't ask the user database related questions. Change-Id: I0dace423dbdb24a23ab189b039e39f93b3be6853 Bug-Url: https://bugzilla.redhat.com/1059358 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0dace423dbdb24a23ab189b039e39f93b3be6853 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: Remove extra quote from remote DB creation instru...
by iheim＠redhat.com 30 Jan '14

30 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: Remove extra quote from remote DB creation instructions ...................................................................... packaging: Remove extra quote from remote DB creation instructions When using a remote DB, engine-setup prompts the user the right way to create a DB. In those instructions, the username was surrounded by quotes, which is unneeded. Change-Id: If34b74c1c84168f018c6a748eb1519d73af8ac26 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1059357 (cherry picked from commit 221d24a711186c565e3d83b0d472b62b64282f6c) --- M packaging/setup/plugins/ovirt-engine-setup/db/connection.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ofer Schreiber: Verified -- To view, visit http://gerrit.ovirt.org/23869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If34b74c1c84168f018c6a748eb1519d73af8ac26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: engine-setup should allow the minumum shmmax
by iheim＠redhat.com 30 Jan '14

30 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: engine-setup should allow the minumum shmmax ...................................................................... packaging: engine-setup should allow the minumum shmmax engine-setup should allow the minimun shmmax defined. Change-Id: I2fc14ddd29c0aca7f3f5712ac176b50d55785b2a Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1059355 (cherry picked from commit 0a88c4b88d5f3edbd707b0252ec13e30217c9938) --- M packaging/setup/plugins/ovirt-engine-setup/system/sysctl.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ofer Schreiber: Verified -- To view, visit http://gerrit.ovirt.org/23868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fc14ddd29c0aca7f3f5712ac176b50d55785b2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: allign user instruction for database creation wit...
by iheim＠redhat.com 30 Jan '14

30 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: allign user instruction for database creation with dwh ...................................................................... packaging: allign user instruction for database creation with dwh Allign the database creation instrutions to the setup user with dwh-setup. replaced "create user..." with "create role...". Change-Id: I98e0687ae9581c2378ca255f047597eb6b1d910b Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1059357 (cherry picked from commit c0f6e1a23a2f2f68136e5c501b4ec7ff08ebce3a) --- M packaging/setup/plugins/ovirt-engine-setup/db/connection.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ofer Schreiber: Verified -- To view, visit http://gerrit.ovirt.org/23867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98e0687ae9581c2378ca255f047597eb6b1d910b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: verify sysctl.shmmax after modification
by iheim＠redhat.com 30 Jan '14

30 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: verify sysctl.shmmax after modification ...................................................................... packaging: verify sysctl.shmmax after modification In non-developer mode, ovirt-engine-setup tries to modify sysctl.shmmax. This patch verifies that the above modification went correctly, and that the current sysctl.shmmax is above what we need. Change-Id: If2e1eafad9dacfa4d784526cdd0118c45cc47ccb Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1059355 (cherry picked from commit 809d795e53e5e1974e6f001b8ae18d5a72246fbb) --- M packaging/setup/plugins/ovirt-engine-setup/system/sysctl.py 1 file changed, 42 insertions(+), 23 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2e1eafad9dacfa4d784526cdd0118c45cc47ccb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: move branding.jar to javalib
by sbonazzo＠redhat.com 30 Jan '14

30 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: move branding.jar to javalib ...................................................................... packaging: spec: move branding.jar to javalib this will enable reuse by other packages, branding especially. Change-Id: Ie44e9483eb39d4c0fa9a398adbb050bc33ddeee4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie44e9483eb39d4c0fa9a398adbb050bc33ddeee4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0