Change in ovirt-engine[ovirt-engine-3.4]: 5. core: Supporting custom message to appear in case of expi...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: 5. core: Supporting custom message to appear in case of expired password
......................................................................
5. core: Supporting custom message to appear in case of expired password
The bug description stays that in case of failed login,
the user may get a URL to change the passord, or a custom message.
In order to support that, the following changes were introduced:
a. manage-domains code -changePasswordUrl was changed to -changePasswordMsg.
b. The input is done in interactive mode.
c. The read value is encoded (as may contain characters like space, : and ,)
d. The manage-domains script was changed accordingly
e. The vdc_options relevant entry was changed (so was the ConfigValues relevant enum literal).
f. ProsivinalAuthenticationResult reads the entry from the configuration and decodes it.
g. A proper VDC BLL message is used depending on whether the content is URL or not (a new
VdcBllMessage was introduced).
Bug-Url: https://bugzilla.redhat.com/1053601
Change-Id: I9f656f38f7f48e169ed01ad084d7f424e5c749f3
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalAuthenticationResult.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M packaging/bin/engine-manage-domains.sh
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
9 files changed, 92 insertions(+), 55 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f656f38f7f48e169ed01ad084d7f424e5c749f3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: 4. webadmin: Changing LoginPopup to present clickable passwo...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: 4. webadmin: Changing LoginPopup to present clickable password URL change
......................................................................
4. webadmin: Changing LoginPopup to present clickable password URL change
Bug-Url: https://bugzilla.redhat.com/1053601
Change-Id: I502cfcad23c3500f1e87e3f45657cf61e9c36d69
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java
4 files changed, 28 insertions(+), 8 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I502cfcad23c3500f1e87e3f45657cf61e9c36d69
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: 3. webadmin: Added appropriate AppErrors message for change ...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: 3. webadmin: Added appropriate AppErrors message for change password URL
......................................................................
3. webadmin: Added appropriate AppErrors message for change password URL
This patch addds appropriate app errors
Bug-Url: https://bugzilla.redhat.com/1053601
Change-Id: Ic843923f3c97f69b6faa82d85ff776e97282db34
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic843923f3c97f69b6faa82d85ff776e97282db34
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: 2. core: Adding support for returning password URL change to...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: 2. core: Adding support for returning password URL change to client
......................................................................
2. core: Adding support for returning password URL change to client
This patch performs the following:
1. Change to AuthenticationResult - no need to hold the detailedInfo object.
classes can extend AuthenticationResult and hold information in fields if neede
2. Handling fetching the password change URL and attaching it to the canDoAction
messages in case the password has expired.
Bug-Url: https://bugzilla.redhat.com/1053601
Change-Id: I0825b1624696e687d76b867f4844f7016819cf2c
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/internal/InternalAuthenticator.java
M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/nop/NopAuthenticationResult.java
M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/nop/NopAuthenticator.java
M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/result/BooleanAuthenticationResult.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalAuthenticationResult.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalAuthenticator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
10 files changed, 73 insertions(+), 47 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0825b1624696e687d76b867f4844f7016819cf2c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: 1. core, tools: Supporting change password Url presentation
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: 1. core, tools: Supporting change password Url presentation
......................................................................
1. core, tools: Supporting change password Url presentation
This patch adds the ability for the administrator to configure for each
authentication domain a url which will be shown on login attempts
failing due to password expiration.
This allows providing the users with a link to a web page allowing to
change their expired password.
In order to set these URLs, a new optional parameter was introduced to
manage-domains, named changePasswordUrl.
Bug-Url: https://bugzilla.redhat.com/1053601
Change-Id: I8eb0f858e26bdefffe526623d025fac47791711e
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
M packaging/bin/engine-manage-domains.sh
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
5 files changed, 84 insertions(+), 17 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8eb0f858e26bdefffe526623d025fac47791711e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: utils: pki resources: return engine alias based on ConfigValues
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: pki resources: return engine alias based on ConfigValues
......................................................................
utils: pki resources: return engine alias based on ConfigValues
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=961677
Change-Id: Ie87ece2025245c9afdb6fbe084c04f4bfac468b9
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie87ece2025245c9afdb6fbe084c04f4bfac468b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: doc: Update README.developer regarding GWT debug
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: doc: Update README.developer regarding GWT debug
......................................................................
doc: Update README.developer regarding GWT debug
http://wiki.ovirt.org/OVirt_Engine_Development_Environment
updated to reflect changes in README.developer as well.
Change-Id: I5d8df4ea6fb8cc029d61d49fb4237ab6844d23a2
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M README.developer
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit http://gerrit.ovirt.org/23024
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d8df4ea6fb8cc029d61d49fb4237ab6844d23a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: Adding SP to update management network name
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: Adding SP to update management network name
......................................................................
Adding SP to update management network name
Adding a new SP RenameManagementNetwork(v_name varchar(50) that updates
the management network name in both vdc_options & network tables.
Change-Id: I29b73e8fa1986610c931abdd2fea5b3536a3037d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1059430
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/network_sp.sql
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29b73e8fa1986610c931abdd2fea5b3536a3037d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: wait more for engine to start
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: wait more for engine to start
......................................................................
packaging: setup: wait more for engine to start
It seems that 1 minute is not enough for having the engine
running when started by ovirt-live iso.
Extended wait up to 3 minutes.
Change-Id: Ie4efd52dd482802f6fbe1b8de72b435babc0f435
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit c57f76d1918fdcc37389cc5d7d260962c1f4fa58)
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4efd52dd482802f6fbe1b8de72b435babc0f435
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: remove system localstate
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: remove system localstate
......................................................................
packaging: setup: remove system localstate
these issues are per 3.2 issues, will not exist post 3.3.
should have been in legacy.
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1059480
Change-Id: Ie998aa70853464d60e4f0573e5fe1cd437d9d948
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
M packaging/setup/ovirt_engine_setup/config.py.in
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/__init__.py
D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/localstate.py
5 files changed, 0 insertions(+), 98 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie998aa70853464d60e4f0573e5fe1cd437d9d948
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months