January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-backup: align db creation instructions wit...
by sbonazzo＠redhat.com 30 Jan '14

30 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: align db creation instructions with dwh ...................................................................... packaging: engine-backup: align db creation instructions with dwh Replace 'create user' with 'create role'. Also add a missing quote. Change-Id: Id11a2746ced31a2731a8f8d76a29b3ea4b6a5478 Bug-Url: https://bugzilla.redhat.com/1040572 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id11a2746ced31a2731a8f8d76a29b3ea4b6a5478 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: sos: engine: don't collect db passwords
by sbonazzo＠redhat.com 30 Jan '14

30 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: engine: don't collect db passwords ...................................................................... sos: engine: don't collect db passwords obfuscate sensitive keys in collected configs. avoid to collect legacy empty files. Change-Id: I169d47db602584093210bc4795ff64abc22824fc Bug-Url: https://bugzilla.redhat.com/1035826 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/config.py.in.in M src/sos/plugins/engine.py 3 files changed, 72 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I169d47db602584093210bc4795ff64abc22824fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: reset mouse cursor for resizable dialog
by derez＠redhat.com 30 Jan '14

30 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: reset mouse cursor for resizable dialog ...................................................................... webadmin: reset mouse cursor for resizable dialog Mouse-cursor stuck on resize-image after closing a dialog while re-sizing it. The fix ensures that when closing the dialog the cursor resets back to default. Change-Id: Ib7f8168690eabf7a3c29e412978122e4e90fc6fe Bug-Url: https://bugzilla.redhat.com/894076 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/ResizableDialogBox.java 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/22956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7f8168690eabf7a3c29e412978122e4e90fc6fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: avoid null cluster on VmModel update vscsi
by derez＠redhat.com 30 Jan '14

30 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: avoid null cluster on VmModel update vscsi ...................................................................... webadmin: avoid null cluster on VmModel update vscsi Avoid null cluster on VmModelBehaviorBase -> updateVirtioScsiEnabled. Change-Id: Ie002f8d84b7e6449b179703dd471f674ca0e3f05 Related-To-Bug-Url: https://bugzilla.redhat.com/1038613 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/23910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie002f8d84b7e6449b179703dd471f674ca0e3f05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: AddRemoveRowWidget to only add ghost entry if no i...
by lvernia＠redhat.com 30 Jan '14

30 Jan '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: AddRemoveRowWidget to only add ghost entry if no items ...................................................................... webadmin: AddRemoveRowWidget to only add ghost entry if no items If there are items in the passed collection, then there's no need to add a ghost entry by default, but only have a plus button next to the last entry. Change-Id: I120e9183d739213b3a26227cc8c3b738ee3b54dc Bug-Url: https://bugzilla.redhat.com/1020861 Bug-Url: https://bugzilla.redhat.com/1058205 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java 2 files changed, 25 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I120e9183d739213b3a26227cc8c3b738ee3b54dc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: doc: Update README with new build instructions
by alitke＠redhat.com 30 Jan '14

30 Jan '14

Adam Litke has submitted this change and it was merged. Change subject: doc: Update README with new build instructions ...................................................................... doc: Update README with new build instructions Change-Id: If81fd28cfe62fc1f59129b009d2d687625e102b6 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/23870 Reviewed-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Reviewed-by: Kiril Nesenko <knesenko(a)redhat.com> --- M README 1 file changed, 18 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Adam Litke: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If81fd28cfe62fc1f59129b009d2d687625e102b6 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-cli[refs/meta/config]: Maintainer need to push annotated tags.
by dcaroest＠redhat.com 30 Jan '14

30 Jan '14

David Caro has submitted this change and it was merged. Change subject: Maintainer need to push annotated tags. ...................................................................... Maintainer need to push annotated tags. --- M project.config 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c4c2a4a389f693f7277968c2b9e5d152935bb6a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: refs/meta/config Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.4]: cli: Prepare for next release
by juan.hernandez＠redhat.com 30 Jan '14

30 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Prepare for next release ...................................................................... cli: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: I6cab0cbe7c94f71c02e382609bfb76243e2e8dd5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cab0cbe7c94f71c02e382609bfb76243e2e8dd5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.4]: cli: Release 3.4.0.3
by juan.hernandez＠redhat.com 30 Jan '14

30 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Release 3.4.0.3 ...................................................................... cli: Release 3.4.0.3 Change-Id: I18982af9013e2b3264ac9c1614c4c6cf2f5b71b7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 9 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18982af9013e2b3264ac9c1614c4c6cf2f5b71b7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: Fixing broken VMs search
by emesika＠redhat.com 30 Jan '14

30 Jan '14

Eli Mesika has submitted this change and it was merged. Change subject: Fixing broken VMs search ...................................................................... Fixing broken VMs search The work done to support the cloud init feature removed the vm_domain column however this column was not removed from the search. Therefore , searching on VMs tab with for example "VMs:vm1" throws the following exception Position: 208: org.springframework.jdbc.BadSqlGrammarException: StatementCallback; bad SQL grammar [SELECT * FROM (SELECT * FROM vms WHERE ( vm_guid IN (SELECT vms_with_tags.vm_guid FROM vms_with_tags WHERE ( vms_with_tags.vm_pool_name ILIKE '%vm1%' OR vms_with_tags.run_on_vds_name ILIKE '%vm1%' OR vms_with_tags.vm_domain ILIKE '%vm1%' OR vms_with_tags.tag_name ILIKE '%vm1%' OR vms_with_tags.guest_cur_user_name ILIKE '%vm1%' OR vms_with_tags.vm_name ILIKE '%vm1%' OR vms_with_tags.vm_description ILIKE '%vm1%' OR vms_with_tags.quota_name ILIKE '%vm1%' OR vms_with_tags.vm_host ILIKE '%vm1%' OR vms_with_tags.vm_ip ILIKE '%vm1%' OR vms_with_tags.storage_pool_name ILIKE '%vm1%' OR vms_with_tags.vds_group_name ILIKE '%vm1%' OR vms_with_tags.vm_comment ILIKE '%vm1%' ) )) ORDER BY vm_name ASC ) as T1 OFFSET (1 -1) LIMIT 100]; nested exception is org.postgresql.util.PSQLException: ERROR: column vms_with_tags.vm_domain does not exist This patch removes the vm_domain column from the search engine code as well. Change-Id: Id4085ca3cff220442a042e0038134c75d7860e61 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Shahar Havivi: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4085ca3cff220442a042e0038134c75d7860e61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0