October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core, engine: Fix balloon detection during VM import
by ofrenkel＠redhat.com 28 Oct '14

28 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core, engine: Fix balloon detection during VM import ...................................................................... core, engine: Fix balloon detection during VM import The canDoAction method of the ImportVmCommand was not properly checking for the presence of ballooning devices and always blocked the importing of ppc64 VMs. This patch fixes this issue. Change-Id: If660e368d7ec31ff1f8251d483971ffbf0bd858a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152560 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java 4 files changed, 42 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If660e368d7ec31ff1f8251d483971ffbf0bd858a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: force java-1.7 source and target
by sradco＠redhat.com 28 Oct '14

28 Oct '14

Shirly Radco has submitted this change and it was merged. Change subject: build: force java-1.7 source and target ...................................................................... build: force java-1.7 source and target soon java-8 will be used to build, we should force our preferences. Change-Id: Id5f3e70f51279102ae1b079fecd812b064ef54cb Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-dwh.spec.in M ovirt-engine-dwh/advancedPersistentLookupLib/build.xml M ovirt-engine-dwh/etltermination/build.xml M ovirt-engine-dwh/historyETL/build.xml M ovirt-engine-dwh/routines/build.xml 5 files changed, 14 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5f3e70f51279102ae1b079fecd812b064ef54cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: force java-1.7 source and target
by sradco＠redhat.com 28 Oct '14

28 Oct '14

Shirly Radco has submitted this change and it was merged. Change subject: build: force java-1.7 source and target ...................................................................... build: force java-1.7 source and target soon java-8 will be used to build, we should force our preferences. Change-Id: I01b96d1472a084afc66bc609f2fffd6b72a4c114 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-reports.spec.in M ovirt-engine-reports/ChartsCustomizers/build.xml M ovirt-engine-reports/CustomOvirtReportsQueryManipulator/build.xml M ovirt-engine-reports/EngineAuthentication/build.xml M ovirt-engine-reports/ReportsServlet/build.xml 5 files changed, 9 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01b96d1472a084afc66bc609f2fffd6b72a4c114 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: Load mod_proxy_ajp.so if not loaded
by sbonazzo＠redhat.com 28 Oct '14

28 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Load mod_proxy_ajp.so if not loaded ...................................................................... packaging: setup: Load mod_proxy_ajp.so if not loaded Change-Id: Id9e724e80b10a811c3f8f89c80a96ef3bb31ee89 Bug-Url: https://bugzilla.redhat.com/1152236 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/conf/ovirt-engine-proxy.conf.v2.in 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/34232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9e724e80b10a811c3f8f89c80a96ef3bb31ee89 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: fixing development environment
by tnisan＠redhat.com 28 Oct '14

28 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: fixing development environment ...................................................................... packaging: setup: fixing development environment Fixing imports and external tool usage for notroot developing environment. Change-Id: Ifa388eeec683ec2ec4f7e3b3949e296f2078180e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109326 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 4a1dbc0343b3d2501dce756df827b5083b78cae1) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/34441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa388eeec683ec2ec4f7e3b3949e296f2078180e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: fixing development environment on remote e...
by tnisan＠redhat.com 28 Oct '14

28 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: fixing development environment on remote engine ...................................................................... packaging: setup: fixing development environment on remote engine Fixing imports for notroot developing environment. Change-Id: I9b7e75dbf8ffe7a8c251232648685b0d6dbf592b Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit f49535ce74f84d65057e25cd6dd52015c1e78be6) --- M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/34442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b7e75dbf8ffe7a8c251232648685b0d6dbf592b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-reports[master]: build: force java-1.7 source and target
by sradco＠redhat.com 28 Oct '14

28 Oct '14

Shirly Radco has submitted this change and it was merged. Change subject: build: force java-1.7 source and target ...................................................................... build: force java-1.7 source and target soon java-8 will be used to build, we should force our preferences. Change-Id: I01b96d1472a084afc66bc609f2fffd6b72a4c114 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-reports.spec.in M ovirt-engine-reports/ChartsCustomizers/build.xml M ovirt-engine-reports/CustomOvirtReportsQueryManipulator/build.xml M ovirt-engine-reports/EngineAuthentication/build.xml M ovirt-engine-reports/ReportsServlet/build.xml 5 files changed, 9 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01b96d1472a084afc66bc609f2fffd6b72a4c114 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Fixing vdsm builds
by dcaroest＠redhat.com 28 Oct '14

28 Oct '14

David Caro has submitted this change and it was merged. Change subject: Fixing vdsm builds ...................................................................... Fixing vdsm builds There were two issues: * Gluster repos not being set on el6-ovirt3.5 * Avoiding runnin fc19 mock jobs on fc21 hosts (yum conflicts BZ:1156497) Change-Id: I782848a7d848cd3e74b7755c144a0170cf26efe6 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/yaml/jobs/vdsm/vdsm_create-rpms.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml 2 files changed, 25 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I782848a7d848cd3e74b7755c144a0170cf26efe6 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: build: force java-1.7 source and target
by sradco＠redhat.com 28 Oct '14

28 Oct '14

Shirly Radco has submitted this change and it was merged. Change subject: build: force java-1.7 source and target ...................................................................... build: force java-1.7 source and target soon java-8 will be used to build, we should force our preferences. Change-Id: Id5f3e70f51279102ae1b079fecd812b064ef54cb Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-dwh.spec.in M ovirt-engine-dwh/advancedPersistentLookupLib/build.xml M ovirt-engine-dwh/etltermination/build.xml M ovirt-engine-dwh/historyETL/build.xml M ovirt-engine-dwh/routines/build.xml 5 files changed, 14 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5f3e70f51279102ae1b079fecd812b064ef54cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix balloon while creating VMs from snapshots
by tjelinek＠redhat.com 28 Oct '14

28 Oct '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix balloon while creating VMs from snapshots ...................................................................... webadmin: Fix balloon while creating VMs from snapshots During the creation of VMs from snapshots, the memory ballooning device was always created even when the original VM had it disabled. This patch fixes this by passing to the AddVmFromSnapshot command the state of the ballooning device from the original VM. Change-Id: I263abb8f3b170e6668e2e93b79700848bf056b57 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152659 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Vitor de Lima: Verified Tomas Jelinek: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I263abb8f3b170e6668e2e93b79700848bf056b57 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0