October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: engine: VmPayload needs to inherit from VmDevice
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: VmPayload needs to inherit from VmDevice ...................................................................... engine: VmPayload needs to inherit from VmDevice It is represent a device and we need the Address and the Id for stable devices. Change-Id: Ieabf99eaaff0d6e68a0521af3df43a774ca31590 Bug-Url: https://bugzilla.redhat.com/1138314 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPayloadQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 13 files changed, 66 insertions(+), 46 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieabf99eaaff0d6e68a0521af3df43a774ca31590 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix NPE when VM does not exists on register
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix NPE when VM does not exists on register ...................................................................... core: Fix NPE when VM does not exists on register Adding a null check if the VM sent in the parameters exists or not, to prevent NPE. Change-Id: I4fb846cc16d1d208f0b96a127169f717a3fec89e Bug-Url: https://bugzilla.redhat.com/1148405 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fb846cc16d1d208f0b96a127169f717a3fec89e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.0]: core, engine: Avoid creating the CD device multiple times
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core, engine: Avoid creating the CD device multiple times ...................................................................... core, engine: Avoid creating the CD device multiple times When there are more than one device attached to the blank template, the AddVmCommand creates multiple CD devices which conflict with each other. This change fixes this issue, but still assumes that the blank template has at least one device attached to it. Change-Id: Iff3c5a34dd0fe6cfb6b4ab3bc77d34c4c0b57939 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075102 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149637 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff3c5a34dd0fe6cfb6b4ab3bc77d34c4c0b57939 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.0 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove printStackTrace from VmHandler
by amureini＠redhat.com 07 Oct '14

07 Oct '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove printStackTrace from VmHandler ...................................................................... core: Remove printStackTrace from VmHandler Removed a useless call to e.printStackTrace() and replaced it with a proper log.debug call. Change-Id: I7ec33e5c8cb319fed39d6934fae63b413d2b378a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ec33e5c8cb319fed39d6934fae63b413d2b378a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added Qos per profile when removing qos
by gchaplik＠redhat.com 07 Oct '14

07 Oct '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Added Qos per profile when removing qos ...................................................................... webadmin: Added Qos per profile when removing qos When removing multiple qos for datacenter which are connected to storage profiles a message appears which state which profiles are connected to those qos, but without stating which qos belong to each profile(This is a problem only when selecting multiple qos for removal). The following fix adds the associated qos to each profile name in the message. Change-Id: I474d38f934f8aaef482f06a81603bbd8566cb871 Bug-Url: https://bugzilla.redhat.com/1142854 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/RemoveQosModel.java 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified -- To view, visit http://gerrit.ovirt.org/33880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I474d38f934f8aaef482f06a81603bbd8566cb871 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix button availability for qos subtab
by gchaplik＠redhat.com 07 Oct '14

07 Oct '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fix button availability for qos subtab ...................................................................... webadmin: fix button availability for qos subtab Change-Id: Ia91804df19b82c579254b8e87e5894133e74e7a3 Bug-Url: https://bugzilla.redhat.com/1142815 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/DataCenterQosListModel.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified -- To view, visit http://gerrit.ovirt.org/33887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia91804df19b82c579254b8e87e5894133e74e7a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[refs/tags/ovirt-engine-3.5.0]: core: Add context when calling to activate Storage Domain
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add context when calling to activate Storage Domain ...................................................................... core: Add context when calling to activate Storage Domain Add context when calling to activate Storage Domain from Attach Storage Domain so the locks will be transferred to the internal command Change-Id: I38f8992a5336ac193a16dda08c5214c2315829a5 Bug-Url: https://bugzilla.redhat.com/1150075 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38f8992a5336ac193a16dda08c5214c2315829a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: refs/tags/ovirt-engine-3.5.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add context when calling to activate Storage Domain
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add context when calling to activate Storage Domain ...................................................................... core: Add context when calling to activate Storage Domain Add context when calling to activate Storage Domain from Attach Storage Domain so the locks will be transferred to the internal command Change-Id: I38f8992a5336ac193a16dda08c5214c2315829a5 Bug-Url: https://bugzilla.redhat.com/1150075 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38f8992a5336ac193a16dda08c5214c2315829a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Correct error message when trying to remove a VM from ...
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Correct error message when trying to remove a VM from pool ...................................................................... core: Correct error message when trying to remove a VM from pool Change-Id: I0fa5e1d5ed9e1448f8c3d711fea714dfeb44dda5 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1149458 --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa5e1d5ed9e1448f8c3d711fea714dfeb44dda5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Correct error message when trying to remove a VM from ...
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Correct error message when trying to remove a VM from pool ...................................................................... core: Correct error message when trying to remove a VM from pool Change-Id: I0fa5e1d5ed9e1448f8c3d711fea714dfeb44dda5 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1149458 --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified Amit Aviram: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa5e1d5ed9e1448f8c3d711fea714dfeb44dda5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0