October 2014 - Engine-commits - oVirt List Archives

Change in mom[master]: Fix a bug - collector mandatory fields were used instead of ...
by alitke＠redhat.com 08 Oct '14

08 Oct '14

Adam Litke has submitted this change and it was merged. Change subject: Fix a bug - collector mandatory fields were used instead of optional ...................................................................... Fix a bug - collector mandatory fields were used instead of optional Change-Id: I91efa2403341f65b4e843c276e52cc32c028b614 Signed-off-by: Martin Pavlasek <mpavlase(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/33321 Reviewed-by: Martin Sivák <msivak(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Monitor.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Martin Pavlásek: Verified -- To view, visit http://gerrit.ovirt.org/33321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91efa2403341f65b4e843c276e52cc32c028b614 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Pavlásek <mpavlase(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Pavlásek <mpavlase(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5.0]: build: post 3.5.0 build
by piotr.kliczewski＠gmail.com 08 Oct '14

08 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: build: post 3.5.0 build ...................................................................... build: post 3.5.0 build Change-Id: Ic4438129c72a7ce8c2dfadafa362d0b88cc33e4f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 50 files changed, 52 insertions(+), 52 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4438129c72a7ce8c2dfadafa362d0b88cc33e4f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix size update in pools of ppc64 VMs
by juan.hernandez＠redhat.com 08 Oct '14

08 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix size update in pools of ppc64 VMs ...................................................................... restapi: Fix size update in pools of ppc64 VMs The size of VM pools could not be increased in ppc64 due to a problem reading templates and inheriting properties from them. This patch fixes this issue by correctly reading the VM template used in the pool and using some of its properties as parameters. Change-Id: I2c4a2a510cc96f6081f72af56ad84d6d54707677 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148706 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Vitor de Lima: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c4a2a510cc96f6081f72af56ad84d6d54707677 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: Consolidate gwt.userAgent property
by vszocs＠redhat.com 08 Oct '14

08 Oct '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Consolidate gwt.userAgent property ...................................................................... webadmin,userportal: Consolidate gwt.userAgent property 1, gwt.userAgent default value is now Firefox (only) 2, all-user-agents Maven profile can now be used to build oVirt GWT UI for all supported browsers (no need to enumerate all browsers anymore) 3, Opera excluded from all-user-agents profile 4, in Makefile, DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS now defaults to empty value - gwt.userAgent will fall back to Firefox (only) 5, in Makefile, BUILD_ALL_USER_AGENTS option can now be used to trigger all-user-agents Maven profile Example 1: build for Firefox (only) $ make clean install-dev PREFIX=$HOME/ovirt-engine Example 2: build for Firefox and Chrome $ make clean install-dev PREFIX=$HOME/ovirt-engine \ DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=gecko1_8,safari" Example 3: build for all supported browsers $ make clean install-dev PREFIX=$HOME/ovirt-engine \ BUILD_ALL_USER_AGENTS=1 6, updated ovirt-engine.spec.in by adding variable ovirt_build_all_user_agents which defaults to 1 7, updated README.developer Note that DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS takes precedence over BUILD_ALL_USER_AGENTS - in example below, oVirt GWT UI will be built for Firefox and Chrome: $ make clean install-dev PREFIX=$HOME/ovirt-engine \ DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=gecko1_8,safari" \ BUILD_ALL_USER_AGENTS=1 Change-Id: I19f5009bb9a73bc554d7ffbd39075130c615c34f Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M Makefile M README.developer M frontend/webadmin/modules/pom.xml M ovirt-engine.spec.in 4 files changed, 39 insertions(+), 16 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19f5009bb9a73bc554d7ffbd39075130c615c34f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: register RemoveSnapshotCommandCallback only for a runn...
by tnisan＠redhat.com 08 Oct '14

08 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: register RemoveSnapshotCommandCallback only for a running VM ...................................................................... core: register RemoveSnapshotCommandCallback only for a running VM RemoveSnapshotCommand - registering RemoveSnapshotCommandCallback for a non running VM is redundant and lead to an exception as described in the bug. Hence, adding the callback only for a running VM. Change-Id: I1f2440a6860dbdd5ece5c3979c710e90ccaa3929 Bug-Url: https://bugzilla.redhat.com/1148710 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java 3 files changed, 18 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f2440a6860dbdd5ece5c3979c710e90ccaa3929 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove old allocation checks from code
by amureini＠redhat.com 08 Oct '14

08 Oct '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove old allocation checks from code ...................................................................... core: Remove old allocation checks from code Old Storage allocation verifications are no longer used in the code, and therefor removed from tests and StorageDoaminValidator. Change-Id: Ib3a30522af4d3657362ee55b2c116e096a248f45 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 2 files changed, 0 insertions(+), 51 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/33801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3a30522af4d3657362ee55b2c116e096a248f45 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RunVmValidator storage allocation
by amureini＠redhat.com 08 Oct '14

08 Oct '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: RunVmValidator storage allocation ...................................................................... core: RunVmValidator storage allocation This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch did this for RunVmValidator. In doing so, space allocation validation for stateless VM became redundant and was therefore removed. Change-Id: Ib3f7c7f31d738f84d356d4e89b05a21d4ca7a118 Bug-Url: https://bugzilla.redhat.com/1149809 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 3 files changed, 19 insertions(+), 54 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3f7c7f31d738f84d356d4e89b05a21d4ca7a118 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: register RemoveSnapshotCommandCallback only for a runn...
by derez＠redhat.com 08 Oct '14

08 Oct '14

Daniel Erez has submitted this change and it was merged. Change subject: core: register RemoveSnapshotCommandCallback only for a running VM ...................................................................... core: register RemoveSnapshotCommandCallback only for a running VM RemoveSnapshotCommand - registering RemoveSnapshotCommandCallback for a non running VM is redundant and lead to an exception as described in the bug. Hence, adding the callback only for a running VM. Change-Id: I1f2440a6860dbdd5ece5c3979c710e90ccaa3929 Bug-Url: https://bugzilla.redhat.com/1148710 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java 3 files changed, 18 insertions(+), 3 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f2440a6860dbdd5ece5c3979c710e90ccaa3929 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: refactor CollectVdsNetworkDataVDSCommand
by masayag＠redhat.com 07 Oct '14

07 Oct '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: refactor CollectVdsNetworkDataVDSCommand ...................................................................... engine: refactor CollectVdsNetworkDataVDSCommand Refactor CollectVdsNetworkDataVDSCommand: extract the network topology persistence logic into its own class with non-static methods. Change-Id: I798abe6597c06df873ac94f61981ff1dccc07bc8 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersister.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 4 files changed, 341 insertions(+), 291 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I798abe6597c06df873ac94f61981ff1dccc07bc8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: cannot set payload and cloud-init on same devices.
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: cannot set payload and cloud-init on same devices. ...................................................................... engine: cannot set payload and cloud-init on same devices. On initial run we automatic set cloud-init/sysprep as cdrom/floppy device - this cause conflict when using the same media. Change-Id: Ic5b701f058a2d87b2836d337f822d2f012d10bbe Bug-Url: https://bugzilla.redhat.com/1138314 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 110 insertions(+), 41 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5b701f058a2d87b2836d337f822d2f012d10bbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0