October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core, engine: Avoid creating the CD device multiple times
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core, engine: Avoid creating the CD device multiple times ...................................................................... core, engine: Avoid creating the CD device multiple times When there are more than one device attached to the blank template, the AddVmCommand creates multiple CD devices which conflict with each other. This change fixes this issue, but still assumes that the blank template has at least one device attached to it. Change-Id: Iff3c5a34dd0fe6cfb6b4ab3bc77d34c4c0b57939 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149637 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075102 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff3c5a34dd0fe6cfb6b4ab3bc77d34c4c0b57939 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Remove unneccessary queries from Cluster Dialog show
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove unneccessary queries from Cluster Dialog show ...................................................................... webadmin: Remove unneccessary queries from Cluster Dialog show When the cluster dialog box is opened, it queries the list of Vds and Vms. However, this info is already found in the UI, added in a previous patch http://gerrit.ovirt.org/#/c/26980/ This patch removes the unneeded DB calls Change-Id: I619bb4971e87e7521653469b7c4a9208ca893d0e Bug-Url: https://bugzilla.redhat.com/1139688 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java 1 file changed, 10 insertions(+), 33 deletions(-) Approvals: Liran Zelkha: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I619bb4971e87e7521653469b7c4a9208ca893d0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: retry fencing operation in case of failure
by tnisan＠redhat.com 07 Oct '14

07 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: retry fencing operation in case of failure ...................................................................... core: retry fencing operation in case of failure retry fencing operation in case of a temporary failure Up to now, if 'unknown' was returned while waiting for a certain status ('on' / 'off') , the while loop was exited with a proper message, breaking the reboot sequence. It seems that there are some cases in which a fencing operation may fail temporarily and succeeded after a while. This patch retries to get to the desired status 3 times before giving up with the configured delay between each status check. Change-Id: Iab5dadd5cb07f2c61dfdf6d75e9fccca790ba483 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1140098 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab5dadd5cb07f2c61dfdf6d75e9fccca790ba483 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add context when calling to activate Storage Domain
by mlipchuk＠redhat.com 07 Oct '14

07 Oct '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add context when calling to activate Storage Domain ...................................................................... core: Add context when calling to activate Storage Domain Add context when calling to activate Storage Domain from Attach Storage Domain so the locks will be transferred to the internal command Change-Id: I38f8992a5336ac193a16dda08c5214c2315829a5 Bug-Url: https://bugzilla.redhat.com/1150075 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38f8992a5336ac193a16dda08c5214c2315829a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix NPE when VM does not exists on register
by mlipchuk＠redhat.com 07 Oct '14

07 Oct '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix NPE when VM does not exists on register ...................................................................... core: Fix NPE when VM does not exists on register Adding a null check if the VM sent in the parameters exists or not, to prevent NPE. Change-Id: I4fb846cc16d1d208f0b96a127169f717a3fec89e Bug-Url: https://bugzilla.redhat.com/1148405 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fb846cc16d1d208f0b96a127169f717a3fec89e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Formatting getExclusiveLocks at ImportVmCommand
by mlipchuk＠redhat.com 07 Oct '14

07 Oct '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Formatting getExclusiveLocks at ImportVmCommand ...................................................................... core: Formatting getExclusiveLocks at ImportVmCommand Formatting getExclusiveLocks at ImportVmCommand Change-Id: If0c2797b3e843015fb5eae6829a098fd203652ce Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0c2797b3e843015fb5eae6829a098fd203652ce Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: cannot set payload and cloud-init on same devices.
by shavivi＠redhat.com 07 Oct '14

07 Oct '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: cannot set payload and cloud-init on same devices. ...................................................................... engine: cannot set payload and cloud-init on same devices. On initial run we automatic set cloud-init/sysprep as cdrom/floppy device - this cause conflict when using the same media. Change-Id: Ic5b701f058a2d87b2836d337f822d2f012d10bbe Bug-Url: https://bugzilla.redhat.com/1138314 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 110 insertions(+), 43 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5b701f058a2d87b2836d337f822d2f012d10bbe Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: VmPayload needs to inherit from VmDevice
by shavivi＠redhat.com 07 Oct '14

07 Oct '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: VmPayload needs to inherit from VmDevice ...................................................................... engine: VmPayload needs to inherit from VmDevice It is represent a device and we need the Address and the Id for stable devices. Change-Id: Ieabf99eaaff0d6e68a0521af3df43a774ca31590 Bug-Url: https://bugzilla.redhat.com/1138314 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPayloadQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 13 files changed, 67 insertions(+), 46 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieabf99eaaff0d6e68a0521af3df43a774ca31590 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: fail the build if osinfo-defaults.properties fail...
by sbonazzo＠redhat.com 07 Oct '14

07 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: fail the build if osinfo-defaults.properties fails to parse ...................................................................... packaging: fail the build if osinfo-defaults.properties fails to parse check the properties file we ship with the exact code that checks it at runtime when the engine loads. this test is hooked into the packaging process and must fail it. Bug-Url: https://bugzilla.redhat.com/1056965 Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M Makefile A build/validations/pom.xml A build/validations/src/test/java/org/ovirt/engine/build/validations/OsinfoValidationsTest.java 3 files changed, 49 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: localize quota strings
by gchaplik＠redhat.com 07 Oct '14

07 Oct '14

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: localize quota strings ...................................................................... userportal: localize quota strings 'unlimited' and 'exceeded' strings are hardcoded. Change-Id: I33f3b3967b7d2db58998428755390714f49ad4a6 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/33814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33f3b3967b7d2db58998428755390714f49ad4a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0