November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: ui: fixing display of host fqdn in addHost form
by oourfali＠redhat.com 23 Nov '14

23 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: fixing display of host fqdn in addHost form ...................................................................... ui: fixing display of host fqdn in addHost form In this patch we create the initial vds name record with the hostgroup domain url. Hostname should be field automatically based on the picked hostgroup and the name. When user change the name field the hostname should be updated accordingly. Change-Id: I74e17d69423e1c02028f596ecafb13a21ab3e3ca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165668 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 4 files changed, 78 insertions(+), 21 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74e17d69423e1c02028f596ecafb13a21ab3e3ca Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Not possible to edit an instance type
by ofrenkel＠redhat.com 23 Nov '14

23 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Not possible to edit an instance type ...................................................................... core: Not possible to edit an instance type A regression introduced in 176bafa8f9ecdc7bf4f06cb0bebd7c2044de2832 The mOldTemplate has to be loaded also when the cluster is null (the case of instance type). Change-Id: I3229350827f2d4dc90ba815007d7cbf1e73b74bc Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3229350827f2d4dc90ba815007d7cbf1e73b74bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: refresh button wrapping
by tnisan＠redhat.com 23 Nov '14

23 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: refresh button wrapping ...................................................................... webadmin: refresh button wrapping - Fixed refresh button wrapping when there is not enough room to fit all the buttons. Change-Id: I1fc13aea7950ab3f4965131dcc2b32e4ea837192 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163929 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fc13aea7950ab3f4965131dcc2b32e4ea837192 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Multi view table columns inconsistent
by tnisan＠redhat.com 23 Nov '14

23 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: Multi view table columns inconsistent ...................................................................... userportal,webadmin: Multi view table columns inconsistent - since a463914769e87b5fb55999bcd25d56167b8e3d16 columns available in all view would not get removed and would always end up at the front of the grid even if other columns that can disappear were in front of them. This patch fixes that problem. Change-Id: I143894af611f8364da943433e81378690adcb0e8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157215 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java 1 file changed, 21 insertions(+), 37 deletions(-) Approvals: Alexander Wels: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I143894af611f8364da943433e81378690adcb0e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Add discovered IP address to provision call
by oourfali＠redhat.com 23 Nov '14

23 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: Add discovered IP address to provision call ...................................................................... Add discovered IP address to provision call In later patch we add to the vds address field the fqdn of the discovered host before the host is provisioned. in the provision call foreman needs the original discovered IP address. Therefore this patch saves the ip and pass it when the provision call is done. Change-Id: I915ed42da851a60a6480f68735b005ab4c3f4a4b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165668 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/HostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVdsActionParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 5 files changed, 14 insertions(+), 6 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I915ed42da851a60a6480f68735b005ab4c3f4a4b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Simplify report redirect
by awels＠redhat.com 21 Nov '14

21 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Simplify report redirect ...................................................................... webadmin: Simplify report redirect - Reports had several redirect servlet instances, one for each type of interaction with the reporting server. The difference was parameters defined in the configuration. This patch passes the parameters to the UI using the host page instead of new servlets in web.xml. - Added parsing method to HtmlParameters to preserve parameters on the url. - Fixed SSO issue where if a user was already logged in it would provide the wrong SSO token and report integration would fail. Change-Id: Ic4718bf7f734ea72d2494fc463a87cb7675df0c4 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/FrontendUrlUtils.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/HtmlParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportsUrls.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java 12 files changed, 130 insertions(+), 30 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4718bf7f734ea72d2494fc463a87cb7675df0c4 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: spec: enable vdsm-reg to autostart
by dougsland＠redhat.com 21 Nov '14

21 Nov '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: enable vdsm-reg to autostart ...................................................................... spec: enable vdsm-reg to autostart This patch enables vdsm-reg to autostart for systemd schema or sysv. Change-Id: I5aad8014ad37838ceb1ab467380fbe9ffc62ae0b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152916 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aad8014ad37838ceb1ab467380fbe9ffc62ae0b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: spec: enable vdsm-reg to autostart
by dougsland＠redhat.com 21 Nov '14

21 Nov '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: enable vdsm-reg to autostart ...................................................................... spec: enable vdsm-reg to autostart This patch enables vdsm-reg to autostart for systemd schema or sysv. Change-Id: I5aad8014ad37838ceb1ab467380fbe9ffc62ae0b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152916 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aad8014ad37838ceb1ab467380fbe9ffc62ae0b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Improve the way we declare and use (optional) collector fields
by alitke＠redhat.com 21 Nov '14

21 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: Improve the way we declare and use (optional) collector fields ...................................................................... Improve the way we declare and use (optional) collector fields Entity and Monitor objects were updated to work with optional fields better. Both were also updated to throw an error when an access to non-declared field is attempted. It is now also possible to specify default value for field in Entity.Stat to make the optional fields more usable in the policy. Guest Memory collector field declaration was changed to explicitly state the collected fields. This should reduce the confusion in what fields are supposed to be collected in libvirt vs. in vdsm environment. It is my opinion that the field declaration is part of the collector's metadata and should be explicitly specified rather than inferred. New Guest Memory collector (GuestMemoryOptional) that treats all fields as optional is added as an example. It also helps when a policy should support more than ballooning and is supposed to work (with ballooning ignored) even when no guest agent is available and internal memory stats are missing. This should keep us compatible with vdsm who has GuestMemory in mom.conf and give us the option to use the new collector with updated ballooning policy in the future vdsm releases. Change-Id: I631056568b5a69e18f6ed02730c41ab59f460aad Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/34528 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Collectors/GuestMemory.py A mom/Collectors/GuestMemoryOptional.py M mom/Collectors/Makefile.am M mom/Entity.py M mom/Monitor.py 5 files changed, 46 insertions(+), 9 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/34528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I631056568b5a69e18f6ed02730c41ab59f460aad Gerrit-PatchSet: 10 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: copy instance type fields to the VM
by juan.hernandez＠redhat.com 21 Nov '14

21 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: copy instance type fields to the VM ...................................................................... restapi: copy instance type fields to the VM As a sonsequence of the https://bugzilla.redhat.com/1149663 the instance type fields are not copyed to the VM on server anymore and the frontends (WA/UP/REST) need to take care of it. More specifically it works like this: If only the instance type is selected, it has to copy it's properties to the newly created VM (on VM level this can be overridden) If both the template and the instance type is selected, the instance type overrides the template. When copying the parameters from instance type to the VM, only the ones which are supported on the target cluster/OS are taken into account. Change-Id: Id8ff7a39fe74c73d8984fb34169b69649dab7c15 Bug-Url: https://bugzilla.redhat.com/1149663 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 207 insertions(+), 121 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8ff7a39fe74c73d8984fb34169b69649dab7c15 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0