Change in ovirt-engine[master]: engine: Enable Long xmlrpc support for new VM and disk hotplug
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: Enable Long xmlrpc support for new VM and disk hotplug
......................................................................
engine: Enable Long xmlrpc support for new VM and disk hotplug
This is needed for the two commands to support Long based
values in the ioTune QoS policy parameters.
Change-Id: I82673b6dec7ba320c56a1cf6e0cd3f1dde86fd22
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145621
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Sivák: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82673b6dec7ba320c56a1cf6e0cd3f1dde86fd22
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: webadmin: refactoring in SplitTable
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: refactoring in SplitTable
......................................................................
webadmin: refactoring in SplitTable
Replace terms which indicate directions and locations with other terms
that indicate actions and types of entities, so they will be suitable
for vertical split table as well:
top -> excluded
bottom -> included
down -> include
up -> exclude
Change-Id: Id6f0452019798e284693df96fc731d5836fbe2dd
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SplitTable.java
2 files changed, 68 insertions(+), 68 deletions(-)
Approvals:
Lior Vernia: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/35210
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6f0452019798e284693df96fc731d5836fbe2dd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: webadmin: introduce abstract split table
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: introduce abstract split table
......................................................................
webadmin: introduce abstract split table
Add SplitTable class which holds the logic and view that are relevant
for both horizontal and vertical split tables.
HorizontalSplitTable class now extends SplitTable and holds the data
which is relevant only for horizontal split tables.
Change-Id: Id7016991693956369df6ced8322dc0836e9437e4
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SplitTable.java
2 files changed, 202 insertions(+), 167 deletions(-)
Approvals:
Lior Vernia: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/35209
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7016991693956369df6ced8322dc0836e9437e4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: Remove suffix from mgmt address taken from the ComputerResou...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: Remove suffix from mgmt address taken from the ComputerResource conf
......................................................................
Remove suffix from mgmt address taken from the ComputerResource conf
This parameter is used by ovirt-node and should include only fqdn or ip4
addr with port number or without. For example 10.35.1.85:8080
Change-Id: I5a40ca0b4870d1955b01d18c88df467b8da35fc4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167189
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Bronhaim: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35383
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a40ca0b4870d1955b01d18c88df467b8da35fc4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-hosted-engine-setup[master]: packaging: setup: Allow destroying VM when aborting
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Allow destroying VM when aborting
......................................................................
packaging: setup: Allow destroying VM when aborting
Change-Id: I93734152b10f410c81d700a36b96ff1f984692f0
Bug-Url: https://bugzilla.redhat.com/1106556
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/engine/health.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
2 files changed, 19 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/35449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93734152b10f410c81d700a36b96ff1f984692f0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: core: Allow automation of first interactions
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: core: Allow automation of first interactions
......................................................................
core: Allow automation of first interactions
Move questions to stage setup, add to answer file.
Change-Id: Iffb05e4a520aa8f8f8a2d7f36e60aee556360302
Bug-Url: https://bugzilla.redhat.com/1101285
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit a294fdfc7a410aadb6fd1c72594989e2f3ef1a26)
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/core/misc.py
M src/plugins/ovirt-hosted-engine-setup/core/shell.py
3 files changed, 38 insertions(+), 11 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/35443
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffb05e4a520aa8f8f8a2d7f36e60aee556360302
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: core: Add Video managed device for VM's/Template's OVF.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add Video managed device for VM's/Template's OVF.
......................................................................
core: Add Video managed device for VM's/Template's OVF.
The number of monitors data in the Template should be part of the OVF
data.
so the information will still be availale after the attach of
a Storage Domain with import of existing entities.
This information consists in the video device of the entity, therefore
the fix adds video devices while building the OVF data, same as being
done in the export VM/Template process.
Change-Id: I5583edadd75bce7dfb3f5ba04cfcbe38f1dc7091
Bug-Url: https://bugzilla.redhat.com/1136902
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/34734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5583edadd75bce7dfb3f5ba04cfcbe38f1dc7091
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: Use debug on register operation.
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Use debug on register operation.
......................................................................
core: Use debug on register operation.
When register a disk with snapshot,
there is no reason to log an error but instead only use a debug level log.
Change-Id: If302d623ab13217776e0cb6ec49dda9cc59b7b39
Bug-Url: https://bugzilla.redhat.com/1136808
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/35446
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If302d623ab13217776e0cb6ec49dda9cc59b7b39
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: engine: Improve reporting when scheduling fails on network
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: Improve reporting when scheduling fails on network
......................................................................
engine: Improve reporting when scheduling fails on network
This fixes and improves the way we construct canDoAction messages
in the NetworkPolicyUnit.
Change-Id: Ic60daf20842ba69457b293f451060e21381faf80
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132951
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114987
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 42 insertions(+), 43 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29790
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic60daf20842ba69457b293f451060e21381faf80
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: core: Use debug on register operation.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use debug on register operation.
......................................................................
core: Use debug on register operation.
When register a disk with snapshot,
there is no reason to log an error but instead only use a debug level log.
Change-Id: If302d623ab13217776e0cb6ec49dda9cc59b7b39
Bug-Url: https://bugzilla.redhat.com/1136808
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/33154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If302d623ab13217776e0cb6ec49dda9cc59b7b39
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month