Change in ovirt-engine[ovirt-engine-3.5]: core: minor refactor for custom props validation
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: minor refactor for custom props validation
......................................................................
core: minor refactor for custom props validation
instead of calling one method to check the properties and then another
to check the result, now calling one method to do both.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1166632
Change-Id: I444f374d0c1bb4c495b3c2b1c26c92bc466e19c9
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/VmPropertiesUtils.java
7 files changed, 21 insertions(+), 28 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I444f374d0c1bb4c495b3c2b1c26c92bc466e19c9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: aaa: Retrive values from domain using case insensitve name o...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: Retrive values from domain using case insensitve name of the domain
......................................................................
aaa: Retrive values from domain using case insensitve name of the domain
This patch is aimed to solve case sensitivy issues for FreeIPA when
upgrading from 3.4 to 3.5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167211
Change-Id: Ieeaf9c922d6d3f0b9bd2a4480859c4ce483454f9
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35465
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeaf9c922d6d3f0b9bd2a4480859c4ce483454f9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: restapi: NUMA pinning doesn't work
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: NUMA pinning doesn't work
......................................................................
restapi: NUMA pinning doesn't work
Fixing constant mapping to false in NumaMapper.
Change-Id: I281ba2eb0b08b3015ae8c6de758b540eb5d717e8
Bug-Url: https://bugzilla.redhat.com/1148027
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NumaMapper.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/35283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I281ba2eb0b08b3015ae8c6de758b540eb5d717e8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: frontend: Correct change prohibition message in VM virtio-rng
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Correct change prohibition message in VM virtio-rng
......................................................................
frontend: Correct change prohibition message in VM virtio-rng
Change-Id: I4ba8fff33b2da306864a78ac4008895e3e178458
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1166050
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Verified
--
To view, visit http://gerrit.ovirt.org/35432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ba8fff33b2da306864a78ac4008895e3e178458
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: aaa: Retrive values from domain using case insensitve name o...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: Retrive values from domain using case insensitve name of the domain
......................................................................
aaa: Retrive values from domain using case insensitve name of the domain
This patch is aimed to solve case sensitivy issues for FreeIPA when
upgrading from 3.4 to 3.5
Change-Id: Ieeaf9c922d6d3f0b9bd2a4480859c4ce483454f9
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeaf9c922d6d3f0b9bd2a4480859c4ce483454f9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-host-deploy[ovirt-host-deploy-1.2]: packaging: post ovirt-host-deploy-1.2.5
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post ovirt-host-deploy-1.2.5
......................................................................
packaging: post ovirt-host-deploy-1.2.5
Change-Id: Icc71c8f034b40b25a02c21dad38c4a53169168b0
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M configure.ac
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35464
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc71c8f034b40b25a02c21dad38c4a53169168b0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.2
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-host-deploy[ovirt-host-deploy-1.2]: packaging: ovirt-host-deploy-1.2.5
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: ovirt-host-deploy-1.2.5
......................................................................
packaging: ovirt-host-deploy-1.2.5
Change-Id: I2455e75364334570bedfea301017443fdab1bb91
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M configure.ac
M ovirt-host-deploy-offline.spec.in
M ovirt-host-deploy.spec.in
4 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35463
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2455e75364334570bedfea301017443fdab1bb91
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.2
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-engine[master]: core: Fix phrasing in MaxHostNetworkQosShares description
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: Fix phrasing in MaxHostNetworkQosShares description
......................................................................
core: Fix phrasing in MaxHostNetworkQosShares description
The maximum number of course doesn't have to be in the range 1-100.
Change-Id: I9ef9c273dad0faa1a2e89efeccb9069c73c848c5
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M packaging/etc/engine-config/engine-config.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/35336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ef9c273dad0faa1a2e89efeccb9069c73c848c5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-host-deploy[ovirt-host-deploy-1.2]: gluster: start glusterpmd service after reboot.
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: gluster: start glusterpmd service after reboot.
......................................................................
gluster: start glusterpmd service after reboot.
Added start of glusterpmd service after reboot.
Change-Id: I6b4d631b23250b513b42ff0509e8d230b1cb3d9b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138108
Signed-off-by: ndarshan <dnarayan(a)redhat.com>
---
M ChangeLog
M src/plugins/ovirt-host-deploy/gluster/glusterpmd.py
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b4d631b23250b513b42ff0509e8d230b1cb3d9b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.2
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: Allow destroying VM when aborting
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Allow destroying VM when aborting
......................................................................
packaging: setup: Allow destroying VM when aborting
Change-Id: I93734152b10f410c81d700a36b96ff1f984692f0
Bug-Url: https://bugzilla.redhat.com/1106556
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 1a6922c5ec1c134be123d91394833a1ce1dde7c7)
---
M src/plugins/ovirt-hosted-engine-setup/engine/health.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
2 files changed, 19 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/35460
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93734152b10f410c81d700a36b96ff1f984692f0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month