Change in ovirt-engine[ovirt-engine-3.5]: aaa: filters: add Prefer new-auth option
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: filters: add Prefer new-auth option
......................................................................
aaa: filters: add Prefer new-auth option
this enforces opening a new http session, this is useful when remote
wants to enforce new session and authorization in persist mode.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161734
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161730
Change-Id: I78e91d9c1994203bd4b278d878b26c843eaad3cf
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionValidationFilter.java
M backend/manager/modules/aaa/src/test/java/org/ovirt/engine/core/aaa/filters/FiltersHelperTest.java
4 files changed, 41 insertions(+), 29 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Alexander Wels: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78e91d9c1994203bd4b278d878b26c843eaad3cf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: aaa: filters: enable accept engine session using header
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: filters: enable accept engine session using header
......................................................................
aaa: filters: enable accept engine session using header
new header OVIRT-INTERNAL-ENGINE-AUTH-TOKEN accepts token that contains
engine session id.
a new query GetEngineSessionIdToken returns this token.
ui should use the new query and apply the header to avoid double login.
this may be temporary solution for 3.5 life cycle, as such applied only
for restapi.
when engine session is invalidated, all instances that used it are also
invalidated.
Change-Id: I028082cced7043b5af0b9fa7b0548ba888996e9d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161734
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161730
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EngineSessionTokenAuthenticationFilter.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetEngineSessionIdTokenQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
6 files changed, 106 insertions(+), 14 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Alexander Wels: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I028082cced7043b5af0b9fa7b0548ba888996e9d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: aaa: bll: generate engine session as plain random string
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: bll: generate engine session as plain random string
......................................................................
aaa: bll: generate engine session as plain random string
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161734
Change-Id: I3f7e18e782c42990a19033c190b448f223b57634
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
1 file changed, 11 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Alexander Wels: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f7e18e782c42990a19033c190b448f223b57634
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-guest-agent[ovirt-3.5]: win32: Set registry value with SetValueEx not SetValue
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Set registry value with SetValueEx not SetValue
......................................................................
win32: Set registry value with SetValueEx not SetValue
_winreg.SetValue only allows to set the default value on a subkey
SetValueEx lets one specify the value name and the value itself.
Additionally as a security measure we're now encapsulating all
exceptions coming from SAS handling to still at least attempt the
login, even if the SAS portion may fail.
This is just a precaution to prevent SSO from breaking due to some
unforeseen bug.
Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54
Bug-Url: https://bugzilla.redhat.com/1158470
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-guest-agent[ovirt-3.5]: win32: Read serial info directly when not available through WMI
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Read serial info directly when not available through WMI
......................................................................
win32: Read serial info directly when not available through WMI
The SerialNumber field in the WMI table 'Win32_DiskDrive' is only
available from Windows Vista and Windows 2008 Server.
This patch works around this issue by querying the device directly,
but only if the SerialNumber field is not available.
Change-Id: Id39914464377c388b8ef3e2551a47a295de4a750
Bug-Url: https://bugzilla.redhat.com/1158907
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 64 insertions(+), 2 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id39914464377c388b8ef3e2551a47a295de4a750
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-guest-agent[ovirt-3.5]: win32: OpenKey third parameter must always be 0
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: OpenKey third parameter must always be 0
......................................................................
win32: OpenKey third parameter must always be 0
The third parameter is a reserved parameter, where the fourth is
the parameter for the requested access rights. Previously the requested
access was passed as the reserved parameter which is wrong, however it
did not fail any testing.
This patch corrects the misusage.
Change-Id: I9fb3747edec2a7ea7270522ac7104748f7021870
Bug-Url: https://bugzilla.redhat.com/1158470
Bug-Url: https://bugzilla.redhat.com/1105056
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
(cherry picked from commit 93aa6178f79189b41c28312e9c839e8d8045e52f)
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fb3747edec2a7ea7270522ac7104748f7021870
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-guest-agent[master]: win32: Set registry value with SetValueEx not SetValue
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Set registry value with SetValueEx not SetValue
......................................................................
win32: Set registry value with SetValueEx not SetValue
_winreg.SetValue only allows to set the default value on a subkey
SetValueEx lets one specify the value name and the value itself.
Additionally as a security measure we're now encapsulating all
exceptions coming from SAS handling to still at least attempt the
login, even if the SAS portion may fail.
This is just a precaution to prevent SSO from breaking due to some
unforeseen bug.
Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54
Bug-Url: https://bugzilla.redhat.com/1158470
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-guest-agent[master]: win32: Read serial info directly when not available through WMI
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Read serial info directly when not available through WMI
......................................................................
win32: Read serial info directly when not available through WMI
The SerialNumber field in the WMI table 'Win32_DiskDrive' is only
available from Windows Vista and Windows 2008 Server.
This patch works around this issue by querying the device directly,
but only if the SerialNumber field is not available.
Change-Id: Id39914464377c388b8ef3e2551a47a295de4a750
Bug-Url: https://bugzilla.redhat.com/1158907
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 64 insertions(+), 2 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35035
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id39914464377c388b8ef3e2551a47a295de4a750
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-guest-agent[master]: win32: Also the listener thread needs to call CoInitialize
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Also the listener thread needs to call CoInitialize
......................................................................
win32: Also the listener thread needs to call CoInitialize
Change-Id: If31c9703d177930922769b98187fae67a28efd4f
Bug-Url: https://bugzilla.redhat.com/1158855
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If31c9703d177930922769b98187fae67a28efd4f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-guest-agent[master]: win32: OpenKey third parameter must always be 0
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: OpenKey third parameter must always be 0
......................................................................
win32: OpenKey third parameter must always be 0
The third parameter is a reserved parameter, where the fourth is
the parameter for the requested access rights. Previously the requested
access was passed as the reserved parameter which is wrong, however it
did not fail any testing.
This patch corrects the misusage.
Change-Id: I9fb3747edec2a7ea7270522ac7104748f7021870
Bug-Url: https://bugzilla.redhat.com/1158470
Bug-Url: https://bugzilla.redhat.com/1105056
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Vinzenz Feenstra: Verified; Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34635
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fb3747edec2a7ea7270522ac7104748f7021870
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month