November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: Pass password across filters so it will be known during...
by oourfali＠redhat.com 05 Nov '14

05 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Pass password across filters so it will be known during LoginUserCommand ...................................................................... aaa: Pass password across filters so it will be known during LoginUserCommand As basic authentication passed auth record to Login filter, the passsword used for authentication was not passed, hence was not set in the session data container. Change-Id: Ie48f8f1408b17882337f4fd0a8c38f7829472cf2 Bug-Url: https://bugzilla.redhat.com/1141541 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/LoginFilter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LoginUserParameters.java 4 files changed, 7 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/34818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie48f8f1408b17882337f4fd0a8c38f7829472cf2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: Clear Inactive ISO Domain Images List
by tnisan＠redhat.com 05 Nov '14

05 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Clear Inactive ISO Domain Images List ...................................................................... frontend: Clear Inactive ISO Domain Images List When an ISO domain is not active, navigating to its images subtab should not query for the images, but show an empty list. Change-Id: Idb29eb14a07a8084b62bda5ac41769ce964bac16 Bug-Url: https://bugzilla.redhat.com/1155191 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/34790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb29eb14a07a8084b62bda5ac41769ce964bac16 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: skip failing proxy when waiting for status
by tnisan＠redhat.com 05 Nov '14

05 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: skip failing proxy when waiting for status ...................................................................... core: skip failing proxy when waiting for status This patch fix a bug when we have a preferred proxy (in 6the same cluster as the fenced host) that failed to perform the desired operation. In this case, we should remember the failed proxy inside the "get status" loop and use the one that had succeeded (if exists) Change-Id: I2b846444ff795e7099b61f6d0be8909402b7bfa1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141514 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 17 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b846444ff795e7099b61f6d0be8909402b7bfa1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Main tab presenter loading
by tnisan＠redhat.com 05 Nov '14

05 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Main tab presenter loading ...................................................................... webadmin: Main tab presenter loading - When clicking a main tab right after login the application would load the code fragments for all main tabs instead of just the one you clicked on. This patch fixes that issue and only the tab you selected is loaded. Change-Id: I63695ad15cbd5633bb081f2f031fb31743886c14 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1155992 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabPresenter.java 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63695ad15cbd5633bb081f2f031fb31743886c14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Make AuditLog more Java coding conventions friendly
by oourfali＠redhat.com 05 Nov '14

05 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Make AuditLog more Java coding conventions friendly ...................................................................... core: Make AuditLog more Java coding conventions friendly 1. Refactor constructors to make proper constructor chaining 2. Rename getter/setter acording to Java coding conventions 3. Code cleanup (remove unnecessary brackets, simplify, ...) Change-Id: Idbc05cd0006737d8ff0c923ab2b6aae18389de90 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMTemplateIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEventsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AuditLogSeverityColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/events/EventListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/event/EventPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java 24 files changed, 339 insertions(+), 335 deletions(-) Approvals: Martin Peřina: Verified Juan Hernandez: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc05cd0006737d8ff0c923ab2b6aae18389de90 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix not to revert patch for BZ 1123780
by oourfali＠redhat.com 05 Nov '14

05 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix not to revert patch for BZ 1123780 ...................................................................... webadmin: Fix not to revert patch for BZ 1123780 Fix regress cause by patch 27bc7af603b0a0 which over wrote changes made by patch Id4b46a36bd676 for BZ 1123780. Change-Id: If2353b4123851b807e38450991958d28aa4ad751 Bug-Url: https://bugzilla.redhat.com/1123780 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved mooli tayer: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2353b4123851b807e38450991958d28aa4ad751 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Missing Guid ctor for CreateSnapshotFromTemplate
by oourfali＠redhat.com 05 Nov '14

05 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Missing Guid ctor for CreateSnapshotFromTemplate ...................................................................... core: Missing Guid ctor for CreateSnapshotFromTemplate Change-Id: I0c43ab5f83db55587894f32116ab229fd28cff36 Bug-Url: https://bugzilla.redhat.com/1160537 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotFromTemplateCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/34809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c43ab5f83db55587894f32116ab229fd28cff36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Missing Guid ctor for CreateSnapshotFromTemplate
by yzaslavs＠redhat.com 05 Nov '14

05 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Missing Guid ctor for CreateSnapshotFromTemplate ...................................................................... core: Missing Guid ctor for CreateSnapshotFromTemplate Change-Id: I0c43ab5f83db55587894f32116ab229fd28cff36 Bug-Url: https://bugzilla.redhat.com/1160537 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotFromTemplateCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/34808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c43ab5f83db55587894f32116ab229fd28cff36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Revert "restapi: Fix NPE in request for CDROMs of wrong VM"
by tnisan＠redhat.com 04 Nov '14

04 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: Revert "restapi: Fix NPE in request for CDROMs of wrong VM" ...................................................................... Revert "restapi: Fix NPE in request for CDROMs of wrong VM" This reverts part of commit 8d5aa3646e2402a48f88a0532a70d9bb50347e57, as it breaks listing of empty collections of VM devices. Change-Id: I14333ee4b8f43da4da287a70304107b225990c44 Bug-Url: https://bugzilla.redhat.com/1159642 Related-To: https://bugzilla.redhat.com/1150953 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 25215cefbd56b4d9b03d9622f886f762d2570fae) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14333ee4b8f43da4da287a70304107b225990c44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, engine, webadmin: Consider only online logical CPUs
by tnisan＠redhat.com 04 Nov '14

04 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core, engine, webadmin: Consider only online logical CPUs ...................................................................... core, engine, webadmin: Consider only online logical CPUs This patch reports the ids of the logical CPUs which are online in the Hosts tab of the webadmin interface, and uses this information to validate the CPU pinning during the VM creation. A new column in the vds_dynamic table was added to store this list. Change-Id: Ib20f20d6003502fe2f2864abb5ad8f4f5a19ecdc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148092 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_1140_add_online_cpu_list.sql M packaging/dbscripts/vds_sp.sql 15 files changed, 112 insertions(+), 17 deletions(-) Approvals: Vitor de Lima: Verified Eli Mesika: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib20f20d6003502fe2f2864abb5ad8f4f5a19ecdc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0