November 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: agent: handle malformed metadata better

by msivak＠redhat.com

Martin Sivák has submitted this change and it was merged. Change subject: agent: handle malformed metadata better ...................................................................... agent: handle malformed metadata better Change-Id: Ie5d2ad055cbea13490d04ec3589c32a3c08a5119 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1158925 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> (cherry picked from commit cc5a96957fdc0b5c6ab59ceb26a9c5aa50614312) --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified Doron Fediuck: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d2ad055cbea13490d04ec3589c32a3c08a5119 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Coverity CID 1201953 (FB.SIC_INNER_SHOULD_BE_STATIC)

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Coverity CID 1201953 (FB.SIC_INNER_SHOULD_BE_STATIC) ...................................................................... webadmin: Coverity CID 1201953 (FB.SIC_INNER_SHOULD_BE_STATIC) Changed EmptyColumn to a static inner class, as Coverity advised. Change-Id: I46528182dc5a526367086af250611a6f3ae530e5 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/35381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46528182dc5a526367086af250611a6f3ae530e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Push ioTune QoS info when hotplugging disk

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Push ioTune QoS info when hotplugging disk ...................................................................... core: Push ioTune QoS info when hotplugging disk This adds the support for disk QoS for disks that are hotplugged while the VM is already running. Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145665 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 33 insertions(+), 12 deletions(-) Approvals: Martin Sivák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Adding an existing block Storage Domain should be blocked

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Adding an existing block Storage Domain should be blocked ...................................................................... core: Adding an existing block Storage Domain should be blocked Adding an existing Storage Domain should be blocked by a CDA message Change-Id: Iba5194e4c87ba96a7482fa52b18a2e9812663c7e Bug-Url: https://bugzilla.redhat.com/1148803 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba5194e4c87ba96a7482fa52b18a2e9812663c7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add lock when importing an exsiting block Storage Domain

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Add lock when importing an exsiting block Storage Domain ...................................................................... core: Add lock when importing an exsiting block Storage Domain Add memory lock while importing an existing block Storage Domain. Change-Id: I43dfed013fcbf9965466a00e01b5c81cc6dc9174 Bug-Url: https://bugzilla.redhat.com/1148803 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43dfed013fcbf9965466a00e01b5c81cc6dc9174 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Push ioTune QoS info when hotplugging disk

by dfediuck＠redhat.com

Doron Fediuck has submitted this change and it was merged. Change subject: core: Push ioTune QoS info when hotplugging disk ...................................................................... core: Push ioTune QoS info when hotplugging disk This adds the support for disk QoS for disks that are hotplugged while the VM is already running. Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145665 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 33 insertions(+), 12 deletions(-) Approvals: Martin Sivák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Adding an existing block Storage Domain should be blocked

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding an existing block Storage Domain should be blocked ...................................................................... core: Adding an existing block Storage Domain should be blocked Adding an existing Storage Domain should be blocked by a CDA message Change-Id: Iba5194e4c87ba96a7482fa52b18a2e9812663c7e Bug-Url: https://bugzilla.redhat.com/1148803 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java 2 files changed, 33 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba5194e4c87ba96a7482fa52b18a2e9812663c7e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Add lock when importing an exsiting block Storage Domain

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add lock when importing an exsiting block Storage Domain ...................................................................... core: Add lock when importing an exsiting block Storage Domain Add memory lock while importing an existing block Storage Domain. Change-Id: I43dfed013fcbf9965466a00e01b5c81cc6dc9174 Bug-Url: https://bugzilla.redhat.com/1148803 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43dfed013fcbf9965466a00e01b5c81cc6dc9174 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: change import vm to be VmCommand - part 2

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: change import vm to be VmCommand - part 2 ...................................................................... core: change import vm to be VmCommand - part 2 Inline checkStoragePool method call and moved fillMacAddress method, to reduce the coupling between ImportVmCommand and MoveOrCopyTemplateCommand. Change-Id: Ie7063d22fbe4bd81de24f050660e35b3ea7b96cd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7063d22fbe4bd81de24f050660e35b3ea7b96cd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 5 months

1
0
0 / 0

Change in mom[master]: CpuTune - use previous value if quota or period is None

by alitke＠redhat.com

Adam Litke has submitted this change and it was merged. Change subject: CpuTune - use previous value if quota or period is None ...................................................................... CpuTune - use previous value if quota or period is None The policy may not set the value of quota or period if it detected no change. the controller than isn't performing the call to setVmCpuTune. The fix will make sure to call setVmCpuTune whenever one of the params changed and it isn't null. Bug-Url: https://bugzilla.redhat.com/1143992 Change-Id: I6ee063062b3596dde0e16d78900688d5dfb059bd Signed-off-by: Roy Golan <rgolan(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/35329 Reviewed-by: Martin Sivák <msivak(a)redhat.com> Reviewed-by: Doron Fediuck <dfediuck(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Controllers/CpuTune.py 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, but someone else must approve Roy Golan: Verified -- To view, visit http://gerrit.ovirt.org/35329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ee063062b3596dde0e16d78900688d5dfb059bd Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2014