Change in ovirt-engine[master]: webadmin: detach handlers on hide
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: detach handlers on hide
......................................................................
webadmin: detach handlers on hide
- Before this patch the change event handlers were detached
when the object containing them would be detached from the
DOM, this could happen many times and it would cause the
handlers to be detached before we wanted them to. This patch
detaches the handlers when the popup is hidden instead of
detached from the DOM.
Change-Id: I56de07f80cbb21fe6362d6df488defe7422cebfb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1164744
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractModelBoundTreePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AssignTagsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/editor/EntityModelCellTree.java
5 files changed, 45 insertions(+), 15 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56de07f80cbb21fe6362d6df488defe7422cebfb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[master]: userportal: VM endless loading
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal: VM endless loading
......................................................................
userportal: VM endless loading
- Fixed issue where if there were no VMs available and you went to
another tab and then back to the VMs the loading would never end.
- Fixed equals to properly take console user into account instead of
always returning false even if both VMs had null console users.
- Fixed 'old' grid content from flashing when switching between tabs.
Change-Id: Iae7bc8fcf9b4d875e99f7b4a6264a54ceed9fb7e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1156103
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AbstractSideTabWithDetailsPresenter.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/extended/SideTabExtendedVirtualMachinePresenter.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/AbstractUserPortalListProvider.java
A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/UserPortalSearchableTableModelProvider.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/template/UserPortalTemplateListProvider.java
6 files changed, 53 insertions(+), 13 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35251
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae7bc8fcf9b4d875e99f7b4a6264a54ceed9fb7e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[master]: core: Added DAO for HostNetworkQos entities
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: Added DAO for HostNetworkQos entities
......................................................................
core: Added DAO for HostNetworkQos entities
Added DAO for these new entities, and a corresponding test class.
Placement of the "network" and "qos" tables in fixtures.xml had to be
swapped, as network entries might depend on the existence of of qos
entries.
Change-Id: I90535167d324c80aa9de7a735a010818ab45e428
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QosQueryBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/HostNetworkQosDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/HostNetworkQosDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/AllQosBaseDaoFacadeImpl.java
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/HostNetworkQosDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
12 files changed, 478 insertions(+), 123 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90535167d324c80aa9de7a735a010818ab45e428
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[master]: core: change import vm to be VmCommand - part 1
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: change import vm to be VmCommand - part 1
......................................................................
core: change import vm to be VmCommand - part 1
This patch reduces the coupling between ImportVmCommand and
MoveOrCopyTemplateCommand command by replacing calls to methods
that always return the same constants with the constant values.
Change-Id: I77c044c25246ebd2fb6e5b9999bfbe2267ab3cbe
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
Vered Volansky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77c044c25246ebd2fb6e5b9999bfbe2267ab3cbe
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in otopi[master]: plugins: fix pep8 issues
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: plugins: fix pep8 issues
......................................................................
plugins: fix pep8 issues
Change-Id: Ie344e77e686fd9b6f411f096b7bf1dc304980e88
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/plugin.py
M src/plugins/otopi/system/command.py
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35489
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie344e77e686fd9b6f411f096b7bf1dc304980e88
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: Add HostNetworkQos widget
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Add HostNetworkQos widget
......................................................................
webadmin: Add HostNetworkQos widget
Added model and view for a reusable host network QoS widget, to be
used when overriding QoS configuration on a specific host interface
and in a dialog of its own (same as other QoS entities).
Change-Id: I6a97c260ba18d21d911a0338149fefc2c6222c52
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/HostNetworkQosParametersModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.ui.xml
5 files changed, 193 insertions(+), 0 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34127
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a97c260ba18d21d911a0338149fefc2c6222c52
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in ovirt-engine[master]: engine: Implement HostNetworkQos [de]serialization
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Implement HostNetworkQos [de]serialization
......................................................................
engine: Implement HostNetworkQos [de]serialization
Implemented HostNetworkQosMapper, which serializes and deserializes
HostNetworkQos entities according to the vdsm contract.
Change-Id: I8fab9e53938823463ff01af0a153390804f276c3
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkQosMapper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
2 files changed, 89 insertions(+), 2 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fab9e53938823463ff01af0a153390804f276c3
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in jenkins[master]: Added workspace cleanup job
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added workspace cleanup job
......................................................................
Added workspace cleanup job
Removes all the workspaces from all the slaves (even offline ones) that are not
currently used by any job.
It also cheks that there are no stalled mounts on the workspace and tries to
umount before deleting.
Added also a nice summary in case some of them failed to cleanup.
Change-Id: I97ad249a432129ca0f8b176d9fa8dbe6b1bfb5b5
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
A jobs/confs/groovy-scripts/cleanup_workspaces.groovy
A jobs/confs/groovy-scripts/cleanup_workspaces.postbuild.groovy
A jobs/confs/yaml/jobs/system/system_cleanup-workspaces.yaml
3 files changed, 202 insertions(+), 0 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34686
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97ad249a432129ca0f8b176d9fa8dbe6b1bfb5b5
Gerrit-PatchSet: 6
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
Change in jenkins[master]: Added possible json option value encoding
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added possible json option value encoding
......................................................................
Added possible json option value encoding
Sometimes mock has options that are python arrays, or dicts, before all the
options were used just as strings, now if possible, it will try to decode an
object using json parser.
Change-Id: I66feb645fab0308b7fea9e759cdb5d88b2278a41
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M mock_configs/mock_genconfig
1 file changed, 11 insertions(+), 5 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved
Objections:
Ewoud Kohl van Wijngaarden: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/35238
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66feb645fab0308b7fea9e759cdb5d88b2278a41
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
9 years, 5 months
Change in ovirt-engine[master]: core: prevent persistence of runtime NUMA info
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: prevent persistence of runtime NUMA info
......................................................................
core: prevent persistence of runtime NUMA info
NUMA runtime info is shown wrongfully (bug 1100202),
also causes double pinning on the same node (bug fix).
This patch removes the persistence of NUMA runtime info, till
it gets resolved.
Change-Id: Ic87e09d1afae2e577f5a03ebaccc12a32ccf7681
Bug-Url: https://bugzilla.redhat.com/1147880
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic87e09d1afae2e577f5a03ebaccc12a32ccf7681
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 5 months
