Change in ovirt-hosted-engine-ha[master]: Base the log rotation on time instead of the log file size
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Base the log rotation on time instead of the log file size
......................................................................
Base the log rotation on time instead of the log file size
Change-Id: I22f227fd402071a696fd6dccd688e87d733634eb
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/agent-log.conf.in
M ovirt_hosted_engine_ha/broker/broker-log.conf.in
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Greg Padgett: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24792
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22f227fd402071a696fd6dccd688e87d733634eb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: search paging on event log does not use paging cor...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: search paging on event log does not use paging correctly
......................................................................
webadmin: search paging on event log does not use paging correctly
search paging on event log does not use paging
correctly If we browse to 2nd page from UI Events
TAB by pressing the '>' button and then put
"Vms: page 1" as the search text , we an error
on server side
Change-Id: I86787302601365e07f9d923f26d483c7bceb30ef
Bug-Url: https://bugzilla.redhat.com/1064395
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Ravi Nori: Verified
--
To view, visit http://gerrit.ovirt.org/24795
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86787302601365e07f9d923f26d483c7bceb30ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: core: update LUN device size using getVmStats
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: update LUN device size using getVmStats
......................................................................
core: update LUN device size using getVmStats
* Handling DirecLUN disks manual resize (user invoked)
by synchronizing LUNs device sizes upon powering up a VM.
* Similar to disk images, utilized VdsUpdateRunTimeInfo
in order to retrieve updated information from getVmStats.
* Added buildVmLunDisksData method to VdsBrokerObjectsBuilder
for de-serializing relevant LUNs data from getVmStats.
* For using batch update, LunDAODbFacadeImpl now extends
MassOperationsGenericDaoDbFacade.
Note: the functionality is depended on VDSM patch -
http://gerrit.ovirt.org/24235
Change-Id: Ie0d4d805ca333990ea1f612eb03a87f4a505f4a8
Bug-Url: https://bugzilla.redhat.com/1026868
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAODbFacadeImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java
10 files changed, 249 insertions(+), 32 deletions(-)
Approvals:
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0d4d805ca333990ea1f612eb03a87f4a505f4a8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: core: introduce update method to LunDAO
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: introduce update method to LunDAO
......................................................................
core: introduce update method to LunDAO
* Added update method to LunDAO and LunDaoDbFacadeImpl.
* Added stored procedure to storages_san_sp.sql.
* Replaced current usages of updateLUNsDeviceSize and
updateLUNsVolumeGroupId with update.
* Modified tests accordingly.
Change-Id: Ie0391443313a6ff065f08e0204f95b4980c01e02
Related-To-Bug-Url: https://bugzilla.redhat.com/1026868
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/LunDAOTest.java
M packaging/dbscripts/storages_san_sp.sql
7 files changed, 55 insertions(+), 68 deletions(-)
Approvals:
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0391443313a6ff065f08e0204f95b4980c01e02
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: notifier: Support snmp trap as a notification method.
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: notifier: Support snmp trap as a notification method.
......................................................................
tools: notifier: Support snmp trap as a notification method.
See feature pages[1]
[1] http://www.ovirt.org/Features/engine-snmp
Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1032661
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/dependencies/pom.xml
A backend/manager/dependencies/src/main/modules/org/snmp4j/main/module.xml
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethod.java
M backend/manager/tools/pom.xml
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
M backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml
M ovirt-engine.spec.in
M packaging/dbscripts/upgrade/03_04_0600_event_notification_methods.sql
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
M pom.xml
11 files changed, 266 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/24707
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: notifier: implement and use transport.idle().
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: notifier: implement and use transport.idle().
......................................................................
tools: notifier: implement and use transport.idle().
As part of transitioning to more then one Transport,
It is no longer possible to let a transport sleep
and retry for as long as it wants. that might
starve other transports especially in a short
notification interval.
Retrying transports (those that can detect sending failures)
Should implement a queue and attempt to send it on idle.
This patch also fixes a bug where smtp loging is done
only before the first send attempt.
Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1051492
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/Transport.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/ShutdownHook.java
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
8 files changed, 209 insertions(+), 110 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/24706
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: notifier: simple first match include/exclude.
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: notifier: simple first match include/exclude.
......................................................................
tools: notifier: simple first match include/exclude.
See feature page[1]
[1] http://www.ovirt.org/Features/configuration-event-subscribers
Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLogEventSubscriber.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventFilter.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UpDownEventFilter.java
D backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationMethodsMapper.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/DispatchResult.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/EventsManager.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/AuditLogEvent.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/AuditLogEventType.java
A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java
D backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/EventSenderResult.java
A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/Observable.java
A backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/Observer.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/Transport.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/EventMessageContent.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/MessageHelper.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java
A backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java
M backend/manager/tools/src/test/resources/conf/notifier-prop-test.conf
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
21 files changed, 988 insertions(+), 472 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/24705
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: notifier: extract MAIL_RETRIES to configuration
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: notifier: extract MAIL_RETRIES to configuration
......................................................................
tools: notifier: extract MAIL_RETRIES to configuration
Change-Id: I72d4f48c44d0dff70963394b2657a833449812bb
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
2 files changed, 9 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/24704
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72d4f48c44d0dff70963394b2657a833449812bb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: notifier: remove sql link between notification_subscr...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: notifier: remove sql link between notification_subscribers and users.
......................................................................
tools: notifier: remove sql link between notification_subscribers and users.
This is done in preperation to snmp notifications which have no
connections to engine users. This includes removing subscriber_id
from event_notification_hist and not using a users email instead of
a notification_subscriber email.
Change-Id: Ibb91d064c5ecec5b335c32636ac432299c5f96f6
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/EventsManager.java
M packaging/dbscripts/event_sp.sql
M packaging/dbscripts/upgrade/03_04_0600_event_notification_methods.sql
4 files changed, 18 insertions(+), 9 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/24703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb91d064c5ecec5b335c32636ac432299c5f96f6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.4]: tools: notifier: reorder ovirt-engine-notifirt.conf.in accor...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: tools: notifier: reorder ovirt-engine-notifirt.conf.in according to sections.
......................................................................
tools: notifier: reorder ovirt-engine-notifirt.conf.in according to sections.
Change-Id: Iff27e5db7e5f5dc5febaf732c71c441c7b122e26
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
1 file changed, 24 insertions(+), 19 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/24702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff27e5db7e5f5dc5febaf732c71c441c7b122e26
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months