February 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: clone vm from snapshot - validate disk sd
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: clone vm from snapshot - validate disk sd ...................................................................... webadmin: clone vm from snapshot - validate disk sd Clone VM from Snapshot: verify that a target storage domain is selected for each disk. Change-Id: I1f5148295b46ce4394c407881217d34d3f7443a8 Related-To-Bug-Url: https://bugzilla.redhat.com/975114 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/24230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f5148295b46ce4394c407881217d34d3f7443a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: storage active validation on AddVmFromSnapshot
by iheim＠redhat.com 11 Feb '14

11 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: storage active validation on AddVmFromSnapshot ...................................................................... core: storage active validation on AddVmFromSnapshot Added validation for source storage domains on AddVmFromSnapshotCommand (i.e. source storage domains should be active). Change-Id: I44ab14a527d2af7dce1b11b8d96f7e384c7b2027 Bug-Url: https://bugzilla.redhat.com/975114 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44ab14a527d2af7dce1b11b8d96f7e384c7b2027 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Change backward compatibility logic for add/update vnic
by masayag＠redhat.com 11 Feb '14

11 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Change backward compatibility logic for add/update vnic ...................................................................... engine: Change backward compatibility logic for add/update vnic The current backward compatibility logic designed for resolving a vnic profile id for a given network should be modified, since REST clients which provides both network name and vnic profile id might face issues, such ignoring the vnic profile id. For that purpose the engine will attempt to find a change in the network name provided by the user to what is already configured on the vnic: 1. If network name is provided, and unchanged - the vnic profile id from the parameters is used. 2. If the network name is provided and changed, use it instead of the vnic profile id. Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75 Bug-Url: https://bugzilla.redhat.com/1047887 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java 5 files changed, 55 insertions(+), 11 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: When ActivateVDS fails, move VDS out of Unassigned status
by emesika＠redhat.com 11 Feb '14

11 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: core: When ActivateVDS fails, move VDS out of Unassigned status ...................................................................... core: When ActivateVDS fails, move VDS out of Unassigned status If ActivateVDS command fails, in some rare scenarios the VDS will be stuck on Unassigned status, locking any ability to remove/activate the VDS. This patch will move failed VDS to Error status. Change-Id: I776fb9fd0fe3292ad257c7bcfaf4ac8c89536869 Bug-Url: https://bugzilla.redhat.com/962180 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/24045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I776fb9fd0fe3292ad257c7bcfaf4ac8c89536869 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: SearchQuery generates slow query on vds_with_tags an...
by emesika＠redhat.com 11 Feb '14

11 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: engine: SearchQuery generates slow query on vds_with_tags and storage_domains ...................................................................... engine: SearchQuery generates slow query on vds_with_tags and storage_domains Fix SearchQuery so that queries without tags are run against the base table, saving an uneeded (and costly) inner query. VDS query decreased by almost 80% (from 100ms to 15ms). Change-Id: Ia0b7a4912d031c4cdafd636126730ea81d8d2bdd Bug-Url: https://bugzilla.redhat.com/984973 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 3 files changed, 93 insertions(+), 29 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0b7a4912d031c4cdafd636126730ea81d8d2bdd Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[sdk_3.4]: codegen: Use SDK specific JAXB bindings
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Use SDK specific JAXB bindings ...................................................................... codegen: Use SDK specific JAXB bindings Currently the SDK uses the same JAXB global bindings used by the engine, because used to be identical. But recently (in commit a57a6a) the engine started to use global bindings tha aren't suitable for the SDK. These bindings used by tne engine already been moved to a separate file in commit 8acd13. This means that they won't be present in the XML schema generated by the engine. But some of these global bindings are needed by the SDK as well, in particular the setting that enables generation of "isSet" methods. This patch adds a bindings file specific to the SDK, that contains only the global bindings needed by the SDK. Change-Id: I946db48bee9d5b9fc6d33ade2fa26b0891f99aaa Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 5218df693721e56916fca6deb6ae77900eb0bf2d) --- M ovirt-engine-sdk-java-codegen/pom.xml M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/xsd/XsdCodegen.java A ovirt-engine-sdk-java-codegen/src/main/resources/api.xjb M ovirt-engine-sdk-java-codegen/src/main/resources/api.xsd 5 files changed, 39 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946db48bee9d5b9fc6d33ade2fa26b0891f99aaa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Use SDK specific JAXB bindings
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Use SDK specific JAXB bindings ...................................................................... codegen: Use SDK specific JAXB bindings Currently the SDK uses the same JAXB global bindings used by the engine, because used to be identical. But recently (in commit a57a6a) the engine started to use global bindings tha aren't suitable for the SDK. These bindings used by tne engine already been moved to a separate file in commit 8acd13. This means that they won't be present in the XML schema generated by the engine. But some of these global bindings are needed by the SDK as well, in particular the setting that enables generation of "isSet" methods. This patch adds a bindings file specific to the SDK, that contains only the global bindings needed by the SDK. Change-Id: I946db48bee9d5b9fc6d33ade2fa26b0891f99aaa Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/pom.xml M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/xsd/XsdCodegen.java A ovirt-engine-sdk-java-codegen/src/main/resources/api.xjb M ovirt-engine-sdk-java-codegen/src/main/resources/api.xsd 5 files changed, 39 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946db48bee9d5b9fc6d33ade2fa26b0891f99aaa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.3]: sdk: Remove trailing slashes from URL prefix
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Remove trailing slashes from URL prefix ...................................................................... sdk: Remove trailing slashes from URL prefix Currently we get the URL prefix of the RESTAPI from the URL provided by the user, without modification. If this prefix contains trailing slashes we end up building complete URLs that contain two slashes. For example, if the user writes this code: api = ovirtsdk.api.API(url='https://whatever/api/', ...) api.clusters.list() We send the following request to the server: GET /api//clusters HTTP/1.1 The server doesn't accept these two slashes and generates an error response. To fix this issue this patch removes trailing slashes from the URL prefix. Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Bug-Url: https://bugzilla.redhat.com/1063746 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 61ac75bc23f8aa9346ab774ee272894fb8259595) --- M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.3 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Remove trailing slashes from URL prefix
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Remove trailing slashes from URL prefix ...................................................................... sdk: Remove trailing slashes from URL prefix Currently we get the URL prefix of the RESTAPI from the URL provided by the user, without modification. If this prefix contains trailing slashes we end up building complete URLs that contain two slashes. For example, if the user writes this code: api = ovirtsdk.api.API(url='https://whatever/api/', ...) api.clusters.list() We send the following request to the server: GET /api//clusters HTTP/1.1 The server doesn't accept these two slashes and generates an error response. To fix this issue this patch removes trailing slashes from the URL prefix. Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Bug-Url: https://bugzilla.redhat.com/1063746 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 61ac75bc23f8aa9346ab774ee272894fb8259595) --- M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: Remove trailing slashes from URL prefix
by juan.hernandez＠redhat.com 11 Feb '14

11 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Remove trailing slashes from URL prefix ...................................................................... sdk: Remove trailing slashes from URL prefix Currently we get the URL prefix of the RESTAPI from the URL provided by the user, without modification. If this prefix contains trailing slashes we end up building complete URLs that contain two slashes. For example, if the user writes this code: api = ovirtsdk.api.API(url='https://whatever/api/', ...) api.clusters.list() We send the following request to the server: GET /api//clusters HTTP/1.1 The server doesn't accept these two slashes and generates an error response. To fix this issue this patch removes trailing slashes from the URL prefix. Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Bug-Url: https://bugzilla.redhat.com/1063746 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a75aeccd7ba42fa3d49c4cebb9fc0ab3eff5cb9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0