Change in gerrit-admin[master]: Added first python hooks and libs
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added first python hooks and libs
......................................................................
Added first python hooks and libs
* Added basic config.py lib
* Added basic gerrit.py lib
* Added hook to check if the patch is merged on all newer branches when
in stable branch
Change-Id: I985113f5a228ccc128eaad3dbf45c918b7fc093a
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
A hooks/bz/patchset-created.warn_if_not_merged_to_previous_branch
M hooks/hook-dispatcher
A hooks/lib/config.py
A hooks/lib/gerrit.py
4 files changed, 252 insertions(+), 1 deletion(-)
Approvals:
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I985113f5a228ccc128eaad3dbf45c918b7fc093a
Gerrit-PatchSet: 4
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Fix NPE in DbUserCacheManager
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Fix NPE in DbUserCacheManager
......................................................................
core: Fix NPE in DbUserCacheManager
Fix NPE in DbUserCacheManager causing inability to login as
admin@internal if LDAP domain has been add prior to first execution of
engine.
Change-Id: I7703d446841bea47222a066fe0a2b51827f12430
Bug-Url: https://bugzilla.redhat.com/1063276
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Itamar Heim: Verified; Looks good to me, approved
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7703d446841bea47222a066fe0a2b51827f12430
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: upgrade only from >= 3.3.2
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: spec: upgrade only from >= 3.3.2
......................................................................
packaging: spec: upgrade only from >= 3.3.2
Upgrade to 3.4.0 is allowed only from >= 3.3.2.
Avoid to pull in a version of ovirt-engine-setup that will
need to be downgraded in order to allow the upgrade
from a legacy version.
Change-Id: I151c5b1156f4c9a91da0e5bd3e6d52149ae65cd5
Bug-Url: https://bugzilla.redhat.com/1054080
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I151c5b1156f4c9a91da0e5bd3e6d52149ae65cd5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Make VM disks editable
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Make VM disks editable
......................................................................
core: Make VM disks editable
When a VM is updated the data from the database is compared to the
updated VM object provided by the caller. But the VM object loaded from
the database doesn't contain the list of disks, so if the caller
provides an VM object that contains the list of disks the UpdateVM
command will wrongly assume that the caller is trying to modify this
list. To avoid this issue this patch marks the list of disks as
editable, so that the UpdateVM command will ignore it.
Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600
Bug-Url: https://bugzilla.redhat.com/1059713
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: restapi: Assure network existence when adding a vnic profile
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Assure network existence when adding a vnic profile
......................................................................
restapi: Assure network existence when adding a vnic profile
In order to create a vnic profile, the user must provide
the network id to which he wishes to add the profile.
If a network cannot be obtained by the id, the parameters
should consider invalid and a proper message should be
returned.
The backend has logic for this scenario, however when performing
this action with a user that its permissions should be verified,
there is a generic "User is not authorized to perform this action"
even though the message refers to a non-existing network entity.
Change-Id: Ib517cc0fd04c4f0e12fd6bdbdca8c6277600e325
Bug-Url: https://bugzilla.redhat.com/1031369
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfilesResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfilesResourceTest.java
3 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/24304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib517cc0fd04c4f0e12fd6bdbdca8c6277600e325
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: packaging: build: helptag_checker: fix pep8 issue with old pep8
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: build: helptag_checker: fix pep8 issue with old pep8
......................................................................
packaging: build: helptag_checker: fix pep8 issue with old pep8
Change-Id: I659c7d1e990693fe6fdbf3b713334d7a5460a1af
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M build/helptag_checker.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Tal Nisan: Verified; Looks good to me, approved
Greg Sheremeta: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I659c7d1e990693fe6fdbf3b713334d7a5460a1af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[master]: engine: Log mass network operations
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Log mass network operations
......................................................................
engine: Log mass network operations
Added logging of mass operations of networking commands so that each
network change that causes update of the network on multiple hosts would
output a log similar to:
(7/11): Applying changes for network red on host vds1.
Both start and end (successful or failed) are logged.
Change-Id: Ie86bd5368052b4ed3bd18cff567c39daef911b31
Bug-Url: https://bugzilla.redhat.com/1055161
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworksByLabelParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworksToClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PersistentSetupNetworksParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
15 files changed, 106 insertions(+), 1 deletion(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie86bd5368052b4ed3bd18cff567c39daef911b31
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: Add PersistentSetupNetworksParameters
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Add PersistentSetupNetworksParameters
......................................................................
engine: Add PersistentSetupNetworksParameters
This parameters class will be used to print audit logging where
it's necessary due to running multiple PersistentSetupNetworks commands.
Change-Id: I94972492a2c87c302f07d4ccc5b7ed9e204d27dc
Related-To: https://bugzilla.redhat.com/1055161
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworksByLabelParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PersistentSetupNetworksParameters.java
9 files changed, 40 insertions(+), 27 deletions(-)
Approvals:
Mike Kolesnik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94972492a2c87c302f07d4ccc5b7ed9e204d27dc
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: Use collection for object names
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Use collection for object names
......................................................................
engine: Use collection for object names
For nameable objects, there's no need to use a list for creating a set
of the object names, just use any collection.
Change-Id: I9451323cf5b9a3edd5f538ada69d8427a7bd4145
Related-To: https://bugzilla.redhat.com/1055161
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Mike Kolesnik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24262
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9451323cf5b9a3edd5f538ada69d8427a7bd4145
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Confirmation window when putting storage domain on...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Confirmation window when putting storage domain on maintenance
......................................................................
webadmin: Confirmation window when putting storage domain on maintenance
Change-Id: If6c673291b4a1fc2610b99710cdcdfab11ad9bd4
Bug-Url: https://bugzilla.redhat.com/1018847
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 80 insertions(+), 3 deletions(-)
Approvals:
Sergey Gotliv: Verified
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24267
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6c673291b4a1fc2610b99710cdcdfab11ad9bd4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months